diff options
| author | Salem Talha <salem.a.talha@gmail.com> | 2014-01-26 03:43:42 -0500 |
|---|---|---|
| committer | Salem Talha <salem.a.talha@gmail.com> | 2014-01-26 14:42:53 -0500 |
| commit | cc61fc09945aeec6fc71a07e91b8610fa71f6425 (patch) | |
| tree | 28b2a4a2742d0f8fa29c19bca7b6f35f441a7a2a /src/libstd/io | |
| parent | 838b5a4cc072057f31453cdd1b50345f92e1a772 (diff) | |
| download | rust-cc61fc09945aeec6fc71a07e91b8610fa71f6425.tar.gz rust-cc61fc09945aeec6fc71a07e91b8610fa71f6425.zip | |
Removed all instances of XXX in preparation for relaxing of FIXME rule
Diffstat (limited to 'src/libstd/io')
| -rw-r--r-- | src/libstd/io/extensions.rs | 4 | ||||
| -rw-r--r-- | src/libstd/io/mod.rs | 24 | ||||
| -rw-r--r-- | src/libstd/io/net/addrinfo.rs | 2 | ||||
| -rw-r--r-- | src/libstd/io/net/tcp.rs | 2 |
4 files changed, 16 insertions, 16 deletions
diff --git a/src/libstd/io/extensions.rs b/src/libstd/io/extensions.rs index 6a9da944f8b..26e0a0d09ad 100644 --- a/src/libstd/io/extensions.rs +++ b/src/libstd/io/extensions.rs @@ -10,8 +10,8 @@ //! Utility mixins that apply to all Readers and Writers -// XXX: Not sure how this should be structured -// XXX: Iteration should probably be considered separately +// FIXME: Not sure how this should be structured +// FIXME: Iteration should probably be considered separately use container::Container; use iter::Iterator; diff --git a/src/libstd/io/mod.rs b/src/libstd/io/mod.rs index 6141faa90da..8531edeb2c6 100644 --- a/src/libstd/io/mod.rs +++ b/src/libstd/io/mod.rs @@ -84,7 +84,7 @@ Some examples of obvious things you might want to do ``` * Make an simple HTTP request - XXX This needs more improvement: TcpStream constructor taking &str, + FIXME This needs more improvement: TcpStream constructor taking &str, `write_str` and `write_line` methods. ```rust,should_fail @@ -101,7 +101,7 @@ Some examples of obvious things you might want to do * Connect based on URL? Requires thinking about where the URL type lives and how to make protocol handlers extensible, e.g. the "tcp" protocol yields a `TcpStream`. - XXX this is not implemented now. + FIXME this is not implemented now. ```rust // connect("tcp://localhost:8080"); @@ -209,7 +209,7 @@ if error.is_some() { # ::std::io::fs::unlink(&Path::new("diary.txt")); ``` -XXX: Need better condition handling syntax +FIXME: Need better condition handling syntax In this case the condition handler will have the opportunity to inspect the IoError raised by either the call to `new` or the call to @@ -232,8 +232,8 @@ to errors similar to null pointer dereferences. In particular code written to ignore errors and expect conditions to be unhandled will start passing around null or zero objects when wrapped in a condition handler. -* XXX: How should we use condition handlers that return values? -* XXX: Should EOF raise default conditions when EOF is not an error? +* FIXME: How should we use condition handlers that return values? +* FIXME: Should EOF raise default conditions when EOF is not an error? # Issues with i/o scheduler affinity, work stealing, task pinning @@ -263,7 +263,7 @@ Out of scope * Async I/O. We'll probably want it eventually -# XXX Questions and issues +# FIXME Questions and issues * Should default constructors take `Path` or `&str`? `Path` makes simple cases verbose. Overloading would be nice. @@ -375,7 +375,7 @@ static DEFAULT_BUF_SIZE: uint = 1024 * 64; /// The type passed to I/O condition handlers to indicate error /// -/// # XXX +/// # FIXME /// /// Is something like this sufficient? It's kind of archaic pub struct IoError { @@ -446,7 +446,7 @@ impl ToStr for IoErrorKind { } } -// XXX: Can't put doc comments on macros +// FIXME: Can't put doc comments on macros // Raised by `I/O` operations on error. condition! { pub io_error: IoError -> (); @@ -491,9 +491,9 @@ pub trait Reader { /// Raises the `io_error` condition on error. If the condition /// is handled then no guarantee is made about the number of bytes /// read and the contents of `buf`. If the condition is handled - /// returns `None` (XXX see below). + /// returns `None` (FIXME see below). /// - /// # XXX + /// # FIXME /// /// * Should raise_default error on eof? /// * If the condition is handled it should still return the bytes read, @@ -1218,7 +1218,7 @@ pub enum SeekStyle { SeekCur, } -/// # XXX +/// # FIXME /// * Are `u64` and `i64` the right choices? pub trait Seek { /// Return position of file cursor in the stream @@ -1228,7 +1228,7 @@ pub trait Seek { /// /// A successful seek clears the EOF indicator. /// - /// # XXX + /// # FIXME /// /// * What is the behavior when seeking past the end of a stream? fn seek(&mut self, pos: i64, style: SeekStyle); diff --git a/src/libstd/io/net/addrinfo.rs b/src/libstd/io/net/addrinfo.rs index 4a8529d0a0a..a1650c9a3a3 100644 --- a/src/libstd/io/net/addrinfo.rs +++ b/src/libstd/io/net/addrinfo.rs @@ -91,7 +91,7 @@ pub fn get_host_addresses(host: &str) -> Option<~[IpAddr]> { /// /// On failure, this will raise on the `io_error` condition. /// -/// XXX: this is not public because the `Hint` structure is not ready for public +/// FIXME: this is not public because the `Hint` structure is not ready for public /// consumption just yet. fn lookup(hostname: Option<&str>, servname: Option<&str>, hint: Option<Hint>) -> Option<~[Info]> { diff --git a/src/libstd/io/net/tcp.rs b/src/libstd/io/net/tcp.rs index b901ea99cbe..9f0bf84c8d8 100644 --- a/src/libstd/io/net/tcp.rs +++ b/src/libstd/io/net/tcp.rs @@ -584,7 +584,7 @@ mod test { }) iotest!(fn socket_and_peer_name_ip6() { - // XXX: peer name is not consistent + // FIXME: peer name is not consistent //peer_name(next_test_ip6()); socket_name(next_test_ip6()); }) |
