about summary refs log tree commit diff
path: root/src/libstd/net
diff options
context:
space:
mode:
authorAlex Crichton <alex@alexcrichton.com>2017-01-05 22:58:37 -0800
committerAlex Crichton <alex@alexcrichton.com>2017-01-05 22:58:37 -0800
commit7eb43f1b20d352c69cb888c39409786b7dd78ffe (patch)
tree542afa79c11d9b245ad7038841e209b23fa408d0 /src/libstd/net
parent42bed7238534b50178cb2bd275f1153d67cc3ece (diff)
downloadrust-7eb43f1b20d352c69cb888c39409786b7dd78ffe.tar.gz
rust-7eb43f1b20d352c69cb888c39409786b7dd78ffe.zip
std: Ignore close_read_wakes_up on Windows
It looks like in practice at least this test will not pass on Windows.
Empirically it is prone to blocking forever, presumably because a call to
`shutdown` doesn't actually wake up other threads on Windows.

We don't document this as a guarantee for `shutdown`, nor do we internally rely
on it. This test originated in a time long since passed when it was leveraged
for canceling I/O, but nowadays there's nothing fancy happening in the standard
library so it's not really a productive test anyway, hence just ignoring it on
Windows.

Closes #31657
Diffstat (limited to 'src/libstd/net')
-rw-r--r--src/libstd/net/tcp.rs1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libstd/net/tcp.rs b/src/libstd/net/tcp.rs
index 63817c9f10f..e4bf25dee88 100644
--- a/src/libstd/net/tcp.rs
+++ b/src/libstd/net/tcp.rs
@@ -1179,6 +1179,7 @@ mod tests {
     }
 
     #[test]
+    #[cfg(unix)] // test doesn't work on Windows, see #31657
     fn close_read_wakes_up() {
         each_ip(&mut |addr| {
             let a = t!(TcpListener::bind(&addr));