diff options
| author | Steven Fackler <sfackler@gmail.com> | 2020-01-03 11:26:05 -0800 |
|---|---|---|
| committer | Steven Fackler <sfackler@gmail.com> | 2020-04-26 04:23:39 -0700 |
| commit | 15262ec6be6fcfc9f27e174a0714d5a62e775fb0 (patch) | |
| tree | a962ae80ff3cbdb331c76426c200cdec0d82219c /src/libstd/process.rs | |
| parent | 019ab732ce63a117cbb446db1488916c5c0bd2a7 (diff) | |
| download | rust-15262ec6be6fcfc9f27e174a0714d5a62e775fb0.tar.gz rust-15262ec6be6fcfc9f27e174a0714d5a62e775fb0.zip | |
Add Read/Write::can_read/write_vectored
When working with an arbitrary reader or writer, code that uses vectored operations may end up being slower than code that copies into a single buffer when the underlying reader or writer doesn't actually support vectored operations. These new methods allow you to ask the reader or witer up front if vectored operations are efficiently supported. Currently, you have to use some heuristics to guess by e.g. checking if the read or write only accessed the first buffer. Hyper is one concrete example of a library that has to do this dynamically: https://github.com/hyperium/hyper/blob/0eaf304644a396895a4ce1f0146e596640bb666a/src/proto/h1/io.rs#L582-L594
Diffstat (limited to 'src/libstd/process.rs')
| -rw-r--r-- | src/libstd/process.rs | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/src/libstd/process.rs b/src/libstd/process.rs index 3eee45d000c..2d22eb4ceaf 100644 --- a/src/libstd/process.rs +++ b/src/libstd/process.rs @@ -245,6 +245,10 @@ impl Write for ChildStdin { self.inner.write_vectored(bufs) } + fn can_write_vectored(&self) -> bool { + self.inner.can_write_vectored() + } + fn flush(&mut self) -> io::Result<()> { Ok(()) } @@ -301,6 +305,11 @@ impl Read for ChildStdout { } #[inline] + fn can_read_vectored(&self) -> bool { + self.inner.can_read_vectored() + } + + #[inline] unsafe fn initializer(&self) -> Initializer { Initializer::nop() } @@ -357,6 +366,11 @@ impl Read for ChildStderr { } #[inline] + fn can_read_vectored(&self) -> bool { + self.inner.can_read_vectored() + } + + #[inline] unsafe fn initializer(&self) -> Initializer { Initializer::nop() } |
