about summary refs log tree commit diff
path: root/src/libstd/rt
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2013-06-11 09:52:40 -0700
committerbors <bors@rust-lang.org>2013-06-11 09:52:40 -0700
commitd1d855993d0386fc13ad1b74df565b5ba6f6e4ea (patch)
treef4c3d0397b96ac2a4d324e29ea1118f9223a7e3c /src/libstd/rt
parentbf41586a1835790b7294c658f4dae484f738ce03 (diff)
parent8081aea3b86d9e25746ff03acabe53c3644b600c (diff)
downloadrust-d1d855993d0386fc13ad1b74df565b5ba6f6e4ea.tar.gz
rust-d1d855993d0386fc13ad1b74df565b5ba6f6e4ea.zip
auto merge of #7047 : bblum/rust/bug_triage, r=graydon
r? anybody
Diffstat (limited to 'src/libstd/rt')
-rw-r--r--src/libstd/rt/rc.rs2
-rw-r--r--src/libstd/rt/uv/mod.rs16
2 files changed, 2 insertions, 16 deletions
diff --git a/src/libstd/rt/rc.rs b/src/libstd/rt/rc.rs
index 1c0c8c14fdf..2977d081508 100644
--- a/src/libstd/rt/rc.rs
+++ b/src/libstd/rt/rc.rs
@@ -78,7 +78,7 @@ impl<T> Drop for RC<T> {
         assert!(self.refcount() > 0);
 
         unsafe {
-            // XXX: Mutable finalizer
+            // FIXME(#4330) Need self by value to get mutability.
             let this: &mut RC<T> = cast::transmute_mut(self);
 
             match *this.get_mut_state() {
diff --git a/src/libstd/rt/uv/mod.rs b/src/libstd/rt/uv/mod.rs
index 10c8b84bc51..dd66a76eead 100644
--- a/src/libstd/rt/uv/mod.rs
+++ b/src/libstd/rt/uv/mod.rs
@@ -238,20 +238,6 @@ pub fn last_uv_error<H, W: Watcher + NativeHandle<*H>>(watcher: &W) -> UvError {
 }
 
 pub fn uv_error_to_io_error(uverr: UvError) -> IoError {
-
-    // XXX: Could go in str::raw
-    unsafe fn c_str_to_static_slice(s: *libc::c_char) -> &'static str {
-        let s = s as *u8;
-        let mut (curr, len) = (s, 0u);
-        while *curr != 0u8 {
-            len += 1u;
-            curr = ptr::offset(s, len);
-        }
-
-        str::raw::buf_as_slice(s, len, |d| cast::transmute(d))
-    }
-
-
     unsafe {
         // Importing error constants
         use rt::uv::uvll::*;
@@ -259,7 +245,7 @@ pub fn uv_error_to_io_error(uverr: UvError) -> IoError {
 
         // uv error descriptions are static
         let c_desc = uvll::strerror(&*uverr);
-        let desc = c_str_to_static_slice(c_desc);
+        let desc = str::raw::c_str_to_static_slice(c_desc);
 
         let kind = match uverr.code {
             UNKNOWN => OtherIoError,