about summary refs log tree commit diff
path: root/src/libstd/rt
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2014-02-22 10:26:46 -0800
committerbors <bors@rust-lang.org>2014-02-22 10:26:46 -0800
commiteb5ba4d2690f29c8ced9092fe4af719e27991bbc (patch)
treebcc3c41d0a1a93db75b1013029b0ed56a126ee45 /src/libstd/rt
parent87e3b5fe7fc5e601f502a82b4bd73da5c07c59f2 (diff)
parent9982de6397197a63a093e7b79851d1915ef783d7 (diff)
downloadrust-eb5ba4d2690f29c8ced9092fe4af719e27991bbc.tar.gz
rust-eb5ba4d2690f29c8ced9092fe4af719e27991bbc.zip
auto merge of #12366 : aepsil0n/rust/feature/unnecessary_parens_around_assigned_values, r=alexcrichton
Fixes #12350.

Parentheses around assignment statements such as

```rust
let mut a = (0);
a = (1);
a += (2);
```

are not necessary and therefore an unnecessary_parens warning is raised when
statements like this occur.

NOTE: In `let` declarations this does not work as intended. Is it possible that they do not count as assignment expressions (`ExprAssign`)? (edit: this is fixed by now)

Furthermore, there are some cases that I fixed in the rest of the code, where parentheses could potentially enhance readability. Compare these lines:

```rust
a = b == c;
a = (b == c);
```

Thus, after having worked on this I'm not entirely sure, whether we should go through with this patch or not. Probably a matter of debate. ;)
Diffstat (limited to 'src/libstd/rt')
0 files changed, 0 insertions, 0 deletions