diff options
| author | bors <bors@rust-lang.org> | 2015-01-06 13:30:29 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2015-01-06 13:30:29 +0000 |
| commit | 8efd9901b628d687d11a4d0ccc153553b38ada49 (patch) | |
| tree | f6b1a31cdbbc5a5873b0b7d549f4842ddf888a83 /src/libstd/sys/common/helper_thread.rs | |
| parent | 340ac040f7603e169a3739c65956ed2213622be5 (diff) | |
| parent | f3a80ab9d2f6ce61c4b7500fb23f4c6f59175770 (diff) | |
| download | rust-8efd9901b628d687d11a4d0ccc153553b38ada49.tar.gz rust-8efd9901b628d687d11a4d0ccc153553b38ada49.zip | |
auto merge of #20573 : huonw/rust/num-stab-2, r=alexcrichton
cc #19260
Open questions:
- I still feel weird about marking functions like `exp` as `#[stable]` in `core` since they're highly likely to call into libm which is theoretically something core is designed to avoid and so we may be forced/want to move it at some point in the future, and so it feels like a lie to call it `#[stable]` (I know `core` is `#[experimental]`, but still...)
- `abs_sub` is a horrible name IMO: it feels like it is `(a - b).abs()`, but it is actually `(a - b).max(0.)`. maybe something along the lines of `pos_diff` ("positive difference") is better.
- the associated-function nature of `Int::from_be` and `Int::from_le` feel strange to me, it feels like they should be methods, but I cannot think of a good name.
I'm also not hugely in favour of `ldexp` and `frexp` but the precedent from C is large. (e.g. AFAICT, `ldexp` must mean "load exponent" which is essentially what it does... but only for a subset of its inputs.)
Diffstat (limited to 'src/libstd/sys/common/helper_thread.rs')
0 files changed, 0 insertions, 0 deletions
