about summary refs log tree commit diff
path: root/src/libstd/sys/unix/stack_overflow.rs
diff options
context:
space:
mode:
authorAlex Crichton <alex@alexcrichton.com>2017-11-30 07:59:35 -0800
committerAlex Crichton <alex@alexcrichton.com>2017-11-30 08:03:04 -0800
commit4e74eb5ba0bbf60ab70a0680d1e07d7a0f59d383 (patch)
tree914130863c32f37553779a7ba4f03fcb2b3b4aaa /src/libstd/sys/unix/stack_overflow.rs
parent4fa202d23b4c8c81b8ac6cf89cf843d35854d437 (diff)
downloadrust-4e74eb5ba0bbf60ab70a0680d1e07d7a0f59d383.tar.gz
rust-4e74eb5ba0bbf60ab70a0680d1e07d7a0f59d383.zip
rustc: Filter out bogus extern crate warnings
Rustdoc has for some time now used the "everybody loops" pass in the compiler to
avoid typechecking and otherwise avoid looking at implementation details.
In #46115 the placement of this pass was pushed back in the compiler to after
macro expansion to ensure that it works with macro-expanded code as well. This
in turn caused the regression in #46271.

The bug here was that the resolver was producing `def_id` instances for
"possibly unused extern crates" which would then later get processed during
typeck to actually issue lint warnings. The problem was that *after* resolution
these `def_id` nodes were actually removed from the AST by the "everybody loops"
pass. This later, when we tried to take a look at `def_id`, caused the compiler
to panic.

The fix applied here is a bit of a heavy hammer which is to just, in this one
case, ignore the `extern crate` lints if the `def_id` looks "bogus" in any way
(basically if it looks like the node was removed after resolution). The real
underlying bug here is probably that the "everybody loops" AST pass is being
stressed to much beyond what it was originally intended to do, but this should
at least fix the ICE for now...

Closes #46271
Diffstat (limited to 'src/libstd/sys/unix/stack_overflow.rs')
0 files changed, 0 insertions, 0 deletions