about summary refs log tree commit diff
path: root/src/libstd/sys/unix/stack_overflow.rs
diff options
context:
space:
mode:
authorDylan DPC <dylan.dpc@gmail.com>2020-04-28 13:12:17 +0200
committerGitHub <noreply@github.com>2020-04-28 13:12:17 +0200
commit6cad1e30061a80a47faf6a2e1b3626de5af3c48d (patch)
treee3a052466fe03a2c9675a874485b567c80152e96 /src/libstd/sys/unix/stack_overflow.rs
parent8e025db59234f0e29d9c331c7d21e775cbd28630 (diff)
parent4d67c8da5563f7398dd7373b24bccd46c96ebb77 (diff)
downloadrust-6cad1e30061a80a47faf6a2e1b3626de5af3c48d.tar.gz
rust-6cad1e30061a80a47faf6a2e1b3626de5af3c48d.zip
Rollup merge of #71634 - eddyb:revert-71372, r=petrochenkov
Revert #71372 ("Fix #! (shebang) stripping account space issue").

While #71372 fixed some of the problems `#!`-stripping had, it introduced others:
* inefficient implementation (`.chars().filter(...).collect()` on the entire input file)
  * this also means the length returned isn't always correct, leading to e.g. #71471
* it ignores whitespace anywhere, stripping ` # ! ...` which isn't a valid shebang
  * the definition of "whitespace" it uses includes newlines, which means even `\n#\n!\n...` is stripped as a shebang (and anything matching the regex `\s*#\s*!\s*`, and not followed by `[`, really)
* it's backward-incompatible but didn't go through Crater

Now, #71487 is already open and will solve all of these issues. But for running Crater, and just in case #71487 takes a bit longer, I decided it's safer to just revert #71372.

This will also make #71372's diff clearer, as it will start again from the original whitespace-unaware version.

r? @petrochenkov
Diffstat (limited to 'src/libstd/sys/unix/stack_overflow.rs')
0 files changed, 0 insertions, 0 deletions