diff options
| author | Huon Wilson <dbau.pp+github@gmail.com> | 2014-03-25 00:39:40 +1100 |
|---|---|---|
| committer | Huon Wilson <dbau.pp+github@gmail.com> | 2014-04-01 20:46:09 +1100 |
| commit | 119289b0f2359472ff07b4fac14188c3dc37b63c (patch) | |
| tree | f14d1573479651a6f72a1b4e85fc955daffee247 /src/libstd | |
| parent | c329a17461b29da3c9f004154d32e4f153d727df (diff) | |
| download | rust-119289b0f2359472ff07b4fac14188c3dc37b63c.tar.gz rust-119289b0f2359472ff07b4fac14188c3dc37b63c.zip | |
std: migrate the errno -> IoError converter from libnative.
This also adds a direct `errno` -> `~str` converter, rather than only being possible to get a string for the very last error.
Diffstat (limited to 'src/libstd')
| -rw-r--r-- | src/libstd/io/mod.rs | 84 | ||||
| -rw-r--r-- | src/libstd/os.rs | 26 |
2 files changed, 99 insertions, 11 deletions
diff --git a/src/libstd/io/mod.rs b/src/libstd/io/mod.rs index 3e193f246a8..92c4171efc8 100644 --- a/src/libstd/io/mod.rs +++ b/src/libstd/io/mod.rs @@ -216,6 +216,8 @@ use container::Container; use fmt; use int; use iter::Iterator; +use libc; +use os; use option::{Option, Some, None}; use path::Path; use result::{Ok, Err, Result}; @@ -290,6 +292,88 @@ pub struct IoError { detail: Option<~str> } +impl IoError { + /// Convert an `errno` value into an `IoError`. + /// + /// If `detail` is `true`, the `detail` field of the `IoError` + /// struct is filled with an allocated string describing the error + /// in more detail, retrieved from the operating system. + pub fn from_errno(errno: uint, detail: bool) -> IoError { + #[cfg(windows)] + fn get_err(errno: i32) -> (IoErrorKind, &'static str) { + match errno { + libc::EOF => (EndOfFile, "end of file"), + libc::ERROR_NO_DATA => (BrokenPipe, "the pipe is being closed"), + libc::ERROR_FILE_NOT_FOUND => (FileNotFound, "file not found"), + libc::ERROR_INVALID_NAME => (InvalidInput, "invalid file name"), + libc::WSAECONNREFUSED => (ConnectionRefused, "connection refused"), + libc::WSAECONNRESET => (ConnectionReset, "connection reset"), + libc::WSAEACCES => (PermissionDenied, "permission denied"), + libc::WSAEWOULDBLOCK => { + (ResourceUnavailable, "resource temporarily unavailable") + } + libc::WSAENOTCONN => (NotConnected, "not connected"), + libc::WSAECONNABORTED => (ConnectionAborted, "connection aborted"), + libc::WSAEADDRNOTAVAIL => (ConnectionRefused, "address not available"), + libc::WSAEADDRINUSE => (ConnectionRefused, "address in use"), + libc::ERROR_BROKEN_PIPE => (EndOfFile, "the pipe has ended"), + + // libuv maps this error code to EISDIR. we do too. if it is found + // to be incorrect, we can add in some more machinery to only + // return this message when ERROR_INVALID_FUNCTION after certain + // win32 calls. + libc::ERROR_INVALID_FUNCTION => (InvalidInput, + "illegal operation on a directory"), + + _ => (OtherIoError, "unknown error") + } + } + + #[cfg(not(windows))] + fn get_err(errno: i32) -> (IoErrorKind, &'static str) { + // FIXME: this should probably be a bit more descriptive... + match errno { + libc::EOF => (EndOfFile, "end of file"), + libc::ECONNREFUSED => (ConnectionRefused, "connection refused"), + libc::ECONNRESET => (ConnectionReset, "connection reset"), + libc::EPERM | libc::EACCES => + (PermissionDenied, "permission denied"), + libc::EPIPE => (BrokenPipe, "broken pipe"), + libc::ENOTCONN => (NotConnected, "not connected"), + libc::ECONNABORTED => (ConnectionAborted, "connection aborted"), + libc::EADDRNOTAVAIL => (ConnectionRefused, "address not available"), + libc::EADDRINUSE => (ConnectionRefused, "address in use"), + libc::ENOENT => (FileNotFound, "no such file or directory"), + libc::EISDIR => (InvalidInput, "illegal operation on a directory"), + + // These two constants can have the same value on some systems, but + // different values on others, so we can't use a match clause + x if x == libc::EAGAIN || x == libc::EWOULDBLOCK => + (ResourceUnavailable, "resource temporarily unavailable"), + + _ => (OtherIoError, "unknown error") + } + } + + let (kind, desc) = get_err(errno as i32); + IoError { + kind: kind, + desc: desc, + detail: if detail {Some(os::error_string(errno))} else {None}, + } + } + + /// Retrieve the last error to occur as a (detailed) IoError. + /// + /// This uses the OS `errno`, and so there should not be any task + /// descheduling or migration (other than that performed by the + /// operating system) between the call(s) for which errors are + /// being checked and the call of this function. + pub fn last_error() -> IoError { + IoError::from_errno(os::errno() as uint, true) + } +} + impl fmt::Show for IoError { fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result { try!(fmt.buf.write_str(self.desc)); diff --git a/src/libstd/os.rs b/src/libstd/os.rs index eeebede6c58..f0695b2ef75 100644 --- a/src/libstd/os.rs +++ b/src/libstd/os.rs @@ -663,10 +663,12 @@ pub fn errno() -> uint { } } -/// Get a string representing the platform-dependent last error -pub fn last_os_error() -> ~str { +/// Return the string corresponding to an `errno()` value of `errnum`. +pub fn error_string(errnum: uint) -> ~str { + return strerror(errnum); + #[cfg(unix)] - fn strerror() -> ~str { + fn strerror(errnum: uint) -> ~str { #[cfg(target_os = "macos")] #[cfg(target_os = "android")] #[cfg(target_os = "freebsd")] @@ -702,7 +704,7 @@ pub fn last_os_error() -> ~str { let p = buf.as_mut_ptr(); unsafe { - if strerror_r(errno() as c_int, p, buf.len() as libc::size_t) < 0 { + if strerror_r(errnum as c_int, p, buf.len() as libc::size_t) < 0 { fail!("strerror_r failure"); } @@ -711,7 +713,7 @@ pub fn last_os_error() -> ~str { } #[cfg(windows)] - fn strerror() -> ~str { + fn strerror(errnum: uint) -> ~str { use libc::types::os::arch::extra::DWORD; use libc::types::os::arch::extra::LPWSTR; use libc::types::os::arch::extra::LPVOID; @@ -735,7 +737,6 @@ pub fn last_os_error() -> ~str { // This value is calculated from the macro // MAKELANGID(LANG_SYSTEM_DEFAULT, SUBLANG_SYS_DEFAULT) let langId = 0x0800 as DWORD; - let err = errno() as DWORD; let mut buf = [0 as WCHAR, ..TMPBUF_SZ]; @@ -743,7 +744,7 @@ pub fn last_os_error() -> ~str { let res = FormatMessageW(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS, ptr::mut_null(), - err, + errnum as DWORD, langId, buf.as_mut_ptr(), buf.len() as DWORD, @@ -751,18 +752,21 @@ pub fn last_os_error() -> ~str { if res == 0 { // Sometimes FormatMessageW can fail e.g. system doesn't like langId, let fm_err = errno(); - return format!("OS Error {} (FormatMessageW() returned error {})", err, fm_err); + return format!("OS Error {} (FormatMessageW() returned error {})", errnum, fm_err); } let msg = str::from_utf16(str::truncate_utf16_at_nul(buf)); match msg { - Some(msg) => format!("OS Error {}: {}", err, msg), - None => format!("OS Error {} (FormatMessageW() returned invalid UTF-16)", err), + Some(msg) => format!("OS Error {}: {}", errnum, msg), + None => format!("OS Error {} (FormatMessageW() returned invalid UTF-16)", errnum), } } } +} - strerror() +/// Get a string representing the platform-dependent last error +pub fn last_os_error() -> ~str { + error_string(errno() as uint) } static mut EXIT_STATUS: AtomicInt = INIT_ATOMIC_INT; |
