diff options
| author | bors <bors@rust-lang.org> | 2014-08-28 23:56:20 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2014-08-28 23:56:20 +0000 |
| commit | 2e92c67dc0318a52fe42c3c0bca408f76c7feb61 (patch) | |
| tree | 1a90b5802f53f36eda0212ac1b02ebd521161f25 /src/libstd | |
| parent | 1a33d7a54170cd2904cebc7a6fd2d1da471ff64e (diff) | |
| parent | 9a8233d3772fbdb3d496aac3e4693e6d4c30e125 (diff) | |
| download | rust-2e92c67dc0318a52fe42c3c0bca408f76c7feb61.tar.gz rust-2e92c67dc0318a52fe42c3c0bca408f76c7feb61.zip | |
auto merge of #16664 : aturon/rust/stabilize-option-result, r=alexcrichton
Per API meeting https://github.com/rust-lang/meeting-minutes/blob/master/Meeting-API-review-2014-08-13.md # Changes to `core::option` Most of the module is marked as stable or unstable; most of the unstable items are awaiting resolution of conventions issues. However, a few methods have been deprecated, either due to lack of use or redundancy: * `take_unwrap`, `get_ref` and `get_mut_ref` (redundant, and we prefer for this functionality to go through an explicit .unwrap) * `filtered` and `while` * `mutate` and `mutate_or_set` * `collect`: this functionality is being moved to a new `FromIterator` impl. # Changes to `core::result` Most of the module is marked as stable or unstable; most of the unstable items are awaiting resolution of conventions issues. * `collect`: this functionality is being moved to a new `FromIterator` impl. * `fold_` is deprecated due to lack of use * Several methods found in `core::option` are added here, including `iter`, `as_slice`, and variants. Due to deprecations, this is a: [breaking-change]
Diffstat (limited to 'src/libstd')
| -rw-r--r-- | src/libstd/io/buffered.rs | 2 | ||||
| -rw-r--r-- | src/libstd/io/process.rs | 4 | ||||
| -rw-r--r-- | src/libstd/io/tempfile.rs | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/libstd/io/buffered.rs b/src/libstd/io/buffered.rs index 1d638e498d4..0c63f1a901f 100644 --- a/src/libstd/io/buffered.rs +++ b/src/libstd/io/buffered.rs @@ -182,7 +182,7 @@ impl<W: Writer> BufferedWriter<W> { pub fn unwrap(mut self) -> W { // FIXME(#12628): is failing the right thing to do if flushing fails? self.flush_buf().unwrap(); - self.inner.take_unwrap() + self.inner.take().unwrap() } } diff --git a/src/libstd/io/process.rs b/src/libstd/io/process.rs index dd6c1f6016c..c1f4161fe18 100644 --- a/src/libstd/io/process.rs +++ b/src/libstd/io/process.rs @@ -54,7 +54,7 @@ use collections::HashMap; /// Err(e) => fail!("failed to execute child: {}", e), /// }; /// -/// let contents = child.stdout.get_mut_ref().read_to_end(); +/// let contents = child.stdout.as_mut().unwrap().read_to_end(); /// assert!(child.wait().unwrap().success()); /// ``` pub struct Process { @@ -95,7 +95,7 @@ pub type EnvMap = HashMap<CString, CString>; /// Err(e) => fail!("failed to execute process: {}", e), /// }; /// -/// let output = process.stdout.get_mut_ref().read_to_end(); +/// let output = process.stdout.as_mut().unwrap().read_to_end(); /// ``` #[deriving(Clone)] pub struct Command { diff --git a/src/libstd/io/tempfile.rs b/src/libstd/io/tempfile.rs index 2faa23a6aa0..8def5d5c997 100644 --- a/src/libstd/io/tempfile.rs +++ b/src/libstd/io/tempfile.rs @@ -70,7 +70,7 @@ impl TempDir { /// temporary directory is prevented. pub fn unwrap(self) -> Path { let mut tmpdir = self; - tmpdir.path.take_unwrap() + tmpdir.path.take().unwrap() } /// Access the wrapped `std::path::Path` to the temporary directory. |
