about summary refs log tree commit diff
path: root/src/libstd
diff options
context:
space:
mode:
authorRyan Thomas <ryan@ryant.org>2016-02-02 17:15:27 +1100
committerRyan Thomas <ryan@ryant.org>2016-02-02 17:17:24 +1100
commit8aae7f78ce16c3386652ab909c1d1318dc780ddd (patch)
tree4eb0ce3b26becd306b8a8215d299435be03fdb7a /src/libstd
parentb94cd7a5bd488324e39047682e1e4dad9c08fa93 (diff)
downloadrust-8aae7f78ce16c3386652ab909c1d1318dc780ddd.tar.gz
rust-8aae7f78ce16c3386652ab909c1d1318dc780ddd.zip
Ensure capacity returned of HashMap is max(capacity, length).
r? @Gankro
Diffstat (limited to 'src/libstd')
-rw-r--r--src/libstd/collections/hash/map.rs30
1 files changed, 29 insertions, 1 deletions
diff --git a/src/libstd/collections/hash/map.rs b/src/libstd/collections/hash/map.rs
index 173214eda44..7ce4aa07b50 100644
--- a/src/libstd/collections/hash/map.rs
+++ b/src/libstd/collections/hash/map.rs
@@ -72,7 +72,10 @@ impl DefaultResizePolicy {
         //
         // This doesn't have to be checked for overflow since allocation size
         // in bytes will overflow earlier than multiplication by 10.
-        cap * 10 / 11
+        //
+        // As per https://github.com/rust-lang/rust/pull/30991 this is updated
+        // to be: (cap * den + den - 1) / num
+        (cap * 10 + 10 - 1) / 11
     }
 }
 
@@ -2418,4 +2421,29 @@ mod test_map {
         assert_eq!(a[&2], "two");
         assert_eq!(a[&3], "three");
     }
+
+    #[test]
+    fn test_capacity_not_less_than_len() {
+        let mut a = HashMap::new();
+        let mut item = 0;
+
+        for _ in 0..116 {
+            a.insert(item, 0);
+            item += 1;
+        }
+
+        assert!(a.capacity() > a.len());
+
+        let free = a.capacity() - a.len();
+        for _ in 0..free {
+            a.insert(item, 0);
+            item += 1;
+        }
+
+        assert_eq!(a.len(), a.capacity());
+
+        // Insert at capacity should cause allocation.
+        a.insert(item, 0);
+        assert!(a.capacity() > a.len());
+    }
 }