diff options
| author | bors <bors@rust-lang.org> | 2014-05-15 23:26:26 -0700 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2014-05-15 23:26:26 -0700 |
| commit | b545a499fad8d58f858e7c14bcdc90171b97efdf (patch) | |
| tree | e4bebf36fa24fe0fe4dd6846291c59520ef1be28 /src/libstd | |
| parent | 84406d438c6c49aa63875096e5f3cca1a3879f17 (diff) | |
| parent | 2e2160b026d7a2b2d13c3a2b4d6aa073ab3ff43f (diff) | |
| download | rust-b545a499fad8d58f858e7c14bcdc90171b97efdf.tar.gz rust-b545a499fad8d58f858e7c14bcdc90171b97efdf.zip | |
auto merge of #14115 : alexcrichton/rust/core-fmt, r=brson
This was a more difficult change than I thought it would be, and it is unfortunately a breaking change rather than a drop-in replacement. Most of the rationale can be found in the third commit. cc #13851
Diffstat (limited to 'src/libstd')
37 files changed, 729 insertions, 3089 deletions
diff --git a/src/libstd/bitflags.rs b/src/libstd/bitflags.rs index 163ccd22552..6b393987281 100644 --- a/src/libstd/bitflags.rs +++ b/src/libstd/bitflags.rs @@ -59,7 +59,7 @@ //! //! impl fmt::Show for Flags { //! fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { -//! write!(f.buf, "hi!") +//! write!(f, "hi!") //! } //! } //! diff --git a/src/libstd/fmt.rs b/src/libstd/fmt.rs new file mode 100644 index 00000000000..86b77a46a39 --- /dev/null +++ b/src/libstd/fmt.rs @@ -0,0 +1,588 @@ +// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or +// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license +// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +/*! + +Utilities for formatting and printing strings + +This module contains the runtime support for the `format!` syntax extension. +This macro is implemented in the compiler to emit calls to this module in order +to format arguments at runtime into strings and streams. + +The functions contained in this module should not normally be used in everyday +use cases of `format!`. The assumptions made by these functions are unsafe for +all inputs, and the compiler performs a large amount of validation on the +arguments to `format!` in order to ensure safety at runtime. While it is +possible to call these functions directly, it is not recommended to do so in the +general case. + +## Usage + +The `format!` macro is intended to be familiar to those coming from C's +printf/fprintf functions or Python's `str.format` function. In its current +revision, the `format!` macro returns a `~str` type which is the result of the +formatting. In the future it will also be able to pass in a stream to format +arguments directly while performing minimal allocations. + +Some examples of the `format!` extension are: + +```rust +format!("Hello"); // => "Hello".to_owned() +format!("Hello, {:s}!", "world"); // => "Hello, world!".to_owned() +format!("The number is {:d}", 1); // => "The number is 1".to_owned() +format!("{:?}", ~[3, 4]); // => "~[3, 4]".to_owned() +format!("{value}", value=4); // => "4".to_owned() +format!("{} {}", 1, 2); // => "1 2".to_owned() +``` + +From these, you can see that the first argument is a format string. It is +required by the compiler for this to be a string literal; it cannot be a +variable passed in (in order to perform validity checking). The compiler will +then parse the format string and determine if the list of arguments provided is +suitable to pass to this format string. + +### Positional parameters + +Each formatting argument is allowed to specify which value argument it's +referencing, and if omitted it is assumed to be "the next argument". For +example, the format string `{} {} {}` would take three parameters, and they +would be formatted in the same order as they're given. The format string +`{2} {1} {0}`, however, would format arguments in reverse order. + +Things can get a little tricky once you start intermingling the two types of +positional specifiers. The "next argument" specifier can be thought of as an +iterator over the argument. Each time a "next argument" specifier is seen, the +iterator advances. This leads to behavior like this: + +```rust +format!("{1} {} {0} {}", 1, 2); // => "2 1 1 2".to_owned() +``` + +The internal iterator over the argument has not been advanced by the time the +first `{}` is seen, so it prints the first argument. Then upon reaching the +second `{}`, the iterator has advanced forward to the second argument. +Essentially, parameters which explicitly name their argument do not affect +parameters which do not name an argument in terms of positional specifiers. + +A format string is required to use all of its arguments, otherwise it is a +compile-time error. You may refer to the same argument more than once in the +format string, although it must always be referred to with the same type. + +### Named parameters + +Rust itself does not have a Python-like equivalent of named parameters to a +function, but the `format!` macro is a syntax extension which allows it to +leverage named parameters. Named parameters are listed at the end of the +argument list and have the syntax: + +```notrust +identifier '=' expression +``` + +For example, the following `format!` expressions all use named argument: + +```rust +format!("{argument}", argument = "test"); // => "test".to_owned() +format!("{name} {}", 1, name = 2); // => "2 1".to_owned() +format!("{a:s} {c:d} {b:?}", a="a", b=(), c=3); // => "a 3 ()".to_owned() +``` + +It is illegal to put positional parameters (those without names) after arguments +which have names. Like positional parameters, it is illegal to provided named +parameters that are unused by the format string. + +### Argument types + +Each argument's type is dictated by the format string. It is a requirement that +every argument is only ever referred to by one type. When specifying the format +of an argument, however, a string like `{}` indicates no type. This is allowed, +and if all references to one argument do not provide a type, then the format `?` +is used (the type's rust-representation is printed). For example, this is an +invalid format string: + +```notrust +{0:d} {0:s} +``` + +Because the first argument is both referred to as an integer as well as a +string. + +Because formatting is done via traits, there is no requirement that the +`d` format actually takes an `int`, but rather it simply requires a type which +ascribes to the `Signed` formatting trait. There are various parameters which do +require a particular type, however. Namely if the syntax `{:.*s}` is used, then +the number of characters to print from the string precedes the actual string and +must have the type `uint`. Although a `uint` can be printed with `{:u}`, it is +illegal to reference an argument as such. For example, this is another invalid +format string: + +```notrust +{:.*s} {0:u} +``` + +### Formatting traits + +When requesting that an argument be formatted with a particular type, you are +actually requesting that an argument ascribes to a particular trait. This allows +multiple actual types to be formatted via `{:d}` (like `i8` as well as `int`). +The current mapping of types to traits is: + +* `?` ⇒ `Poly` +* `d` ⇒ `Signed` +* `i` ⇒ `Signed` +* `u` ⇒ `Unsigned` +* `b` ⇒ `Bool` +* `c` ⇒ `Char` +* `o` ⇒ `Octal` +* `x` ⇒ `LowerHex` +* `X` ⇒ `UpperHex` +* `s` ⇒ `String` +* `p` ⇒ `Pointer` +* `t` ⇒ `Binary` +* `f` ⇒ `Float` +* `e` ⇒ `LowerExp` +* `E` ⇒ `UpperExp` +* *nothing* ⇒ `Show` + +What this means is that any type of argument which implements the +`std::fmt::Binary` trait can then be formatted with `{:t}`. Implementations are +provided for these traits for a number of primitive types by the standard +library as well. If no format is specified (as in `{}` or `{:6}`), then the +format trait used is the `Show` trait. This is one of the more commonly +implemented traits when formatting a custom type. + +When implementing a format trait for your own type, you will have to implement a +method of the signature: + +```rust +# use std; +# mod fmt { pub type Result = (); } +# struct T; +# trait SomeName<T> { +fn fmt(&self, f: &mut std::fmt::Formatter) -> fmt::Result; +# } +``` + +Your type will be passed as `self` by-reference, and then the function should +emit output into the `f.buf` stream. It is up to each format trait +implementation to correctly adhere to the requested formatting parameters. The +values of these parameters will be listed in the fields of the `Formatter` +struct. In order to help with this, the `Formatter` struct also provides some +helper methods. + +Additionally, the return value of this function is `fmt::Result` which is a +typedef to `Result<(), IoError>` (also known as `IoError<()>`). Formatting +implementations should ensure that they return errors from `write!` correctly +(propagating errors upward). + +An example of implementing the formatting traits would look +like: + +```rust +use std::fmt; +use std::f64; + +struct Vector2D { + x: int, + y: int, +} + +impl fmt::Show for Vector2D { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + // The `f` value implements the `Writer` trait, which is what the + // write! macro is expecting. Note that this formatting ignores the + // various flags provided to format strings. + write!(f, "({}, {})", self.x, self.y) + } +} + +// Different traits allow different forms of output of a type. The meaning of +// this format is to print the magnitude of a vector. +impl fmt::Binary for Vector2D { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + let magnitude = (self.x * self.x + self.y * self.y) as f64; + let magnitude = magnitude.sqrt(); + + // Respect the formatting flags by using the helper method + // `pad_integral` on the Formatter object. See the method documentation + // for details, and the function `pad` can be used to pad strings. + let decimals = f.precision.unwrap_or(3); + let string = f64::to_str_exact(magnitude, decimals); + f.pad_integral(true, "", string.as_bytes()) + } +} + +fn main() { + let myvector = Vector2D { x: 3, y: 4 }; + + println!("{}", myvector); // => "(3, 4)" + println!("{:10.3t}", myvector); // => " 5.000" +} +``` + +### Related macros + +There are a number of related macros in the `format!` family. The ones that are +currently implemented are: + +```ignore +format! // described above +write! // first argument is a &mut io::Writer, the destination +writeln! // same as write but appends a newline +print! // the format string is printed to the standard output +println! // same as print but appends a newline +format_args! // described below. +``` + + +#### `write!` + +This and `writeln` are two macros which are used to emit the format string to a +specified stream. This is used to prevent intermediate allocations of format +strings and instead directly write the output. Under the hood, this function is +actually invoking the `write` function defined in this module. Example usage is: + +```rust +# #![allow(unused_must_use)] +use std::io; + +let mut w = io::MemWriter::new(); +write!(&mut w as &mut io::Writer, "Hello {}!", "world"); +``` + +#### `print!` + +This and `println` emit their output to stdout. Similarly to the `write!` macro, +the goal of these macros is to avoid intermediate allocations when printing +output. Example usage is: + +```rust +print!("Hello {}!", "world"); +println!("I have a newline {}", "character at the end"); +``` + +#### `format_args!` +This is a curious macro which is used to safely pass around +an opaque object describing the format string. This object +does not require any heap allocations to create, and it only +references information on the stack. Under the hood, all of +the related macros are implemented in terms of this. First +off, some example usage is: + +``` +use std::fmt; +use std::io; + +# #[allow(unused_must_use)] +# fn main() { +format_args!(fmt::format, "this returns {}", "~str"); + +let some_writer: &mut io::Writer = &mut io::stdout(); +format_args!(|args| { write!(some_writer, "{}", args) }, "print with a {}", "closure"); + +fn my_fmt_fn(args: &fmt::Arguments) { + write!(&mut io::stdout(), "{}", args); +} +format_args!(my_fmt_fn, "or a {} too", "function"); +# } +``` + +The first argument of the `format_args!` macro is a function (or closure) which +takes one argument of type `&fmt::Arguments`. This structure can then be +passed to the `write` and `format` functions inside this module in order to +process the format string. The goal of this macro is to even further prevent +intermediate allocations when dealing formatting strings. + +For example, a logging library could use the standard formatting syntax, but it +would internally pass around this structure until it has been determined where +output should go to. + +It is unsafe to programmatically create an instance of `fmt::Arguments` because +the operations performed when executing a format string require the compile-time +checks provided by the compiler. The `format_args!` macro is the only method of +safely creating these structures, but they can be unsafely created with the +constructor provided. + +## Internationalization + +The formatting syntax supported by the `format!` extension supports +internationalization by providing "methods" which execute various different +outputs depending on the input. The syntax and methods provided are similar to +other internationalization systems, so again nothing should seem alien. +Currently two methods are supported by this extension: "select" and "plural". + +Each method will execute one of a number of clauses, and then the value of the +clause will become what's the result of the argument's format. Inside of the +cases, nested argument strings may be provided, but all formatting arguments +must not be done through implicit positional means. All arguments inside of each +case of a method must be explicitly selected by their name or their integer +position. + +Furthermore, whenever a case is running, the special character `#` can be used +to reference the string value of the argument which was selected upon. As an +example: + +```rust +format!("{0, select, other{#}}", "hello"); // => "hello".to_owned() +``` + +This example is the equivalent of `{0:s}` essentially. + +### Select + +The select method is a switch over a `&str` parameter, and the parameter *must* +be of the type `&str`. An example of the syntax is: + +```notrust +{0, select, male{...} female{...} other{...}} +``` + +Breaking this down, the `0`-th argument is selected upon with the `select` +method, and then a number of cases follow. Each case is preceded by an +identifier which is the match-clause to execute the given arm. In this case, +there are two explicit cases, `male` and `female`. The case will be executed if +the string argument provided is an exact match to the case selected. + +The `other` case is also a required case for all `select` methods. This arm will +be executed if none of the other arms matched the word being selected over. + +### Plural + +The plural method is a switch statement over a `uint` parameter, and the +parameter *must* be a `uint`. A plural method in its full glory can be specified +as: + +```notrust +{0, plural, offset=1 =1{...} two{...} many{...} other{...}} +``` + +To break this down, the first `0` indicates that this method is selecting over +the value of the first positional parameter to the format string. Next, the +`plural` method is being executed. An optionally-supplied `offset` is then given +which indicates a number to subtract from argument `0` when matching. This is +then followed by a list of cases. + +Each case is allowed to supply a specific value to match upon with the syntax +`=N`. This case is executed if the value at argument `0` matches N exactly, +without taking the offset into account. A case may also be specified by one of +five keywords: `zero`, `one`, `two`, `few`, and `many`. These cases are matched +on after argument `0` has the offset taken into account. Currently the +definitions of `many` and `few` are hardcoded, but they are in theory defined by +the current locale. + +Finally, all `plural` methods must have an `other` case supplied which will be +executed if none of the other cases match. + +## Syntax + +The syntax for the formatting language used is drawn from other languages, so it +should not be too alien. Arguments are formatted with python-like syntax, +meaning that arguments are surrounded by `{}` instead of the C-like `%`. The +actual grammar for the formatting syntax is: + +```notrust +format_string := <text> [ format <text> ] * +format := '{' [ argument ] [ ':' format_spec ] [ ',' function_spec ] '}' +argument := integer | identifier + +format_spec := [[fill]align][sign]['#'][0][width]['.' precision][type] +fill := character +align := '<' | '>' +sign := '+' | '-' +width := count +precision := count | '*' +type := identifier | '' +count := parameter | integer +parameter := integer '$' + +function_spec := plural | select +select := 'select' ',' ( identifier arm ) * +plural := 'plural' ',' [ 'offset:' integer ] ( selector arm ) * +selector := '=' integer | keyword +keyword := 'zero' | 'one' | 'two' | 'few' | 'many' | 'other' +arm := '{' format_string '}' +``` + +## Formatting Parameters + +Each argument being formatted can be transformed by a number of formatting +parameters (corresponding to `format_spec` in the syntax above). These +parameters affect the string representation of what's being formatted. This +syntax draws heavily from Python's, so it may seem a bit familiar. + +### Fill/Alignment + +The fill character is provided normally in conjunction with the `width` +parameter. This indicates that if the value being formatted is smaller than +`width` some extra characters will be printed around it. The extra characters +are specified by `fill`, and the alignment can be one of two options: + +* `<` - the argument is left-aligned in `width` columns +* `>` - the argument is right-aligned in `width` columns + +### Sign/#/0 + +These can all be interpreted as flags for a particular formatter. + +* '+' - This is intended for numeric types and indicates that the sign should + always be printed. Positive signs are never printed by default, and the + negative sign is only printed by default for the `Signed` trait. This + flag indicates that the correct sign (+ or -) should always be printed. +* '-' - Currently not used +* '#' - This flag is indicates that the "alternate" form of printing should be + used. By default, this only applies to the integer formatting traits and + performs like: + * `x` - precedes the argument with a "0x" + * `X` - precedes the argument with a "0x" + * `t` - precedes the argument with a "0b" + * `o` - precedes the argument with a "0o" +* '0' - This is used to indicate for integer formats that the padding should + both be done with a `0` character as well as be sign-aware. A format + like `{:08d}` would yield `00000001` for the integer `1`, while the same + format would yield `-0000001` for the integer `-1`. Notice that the + negative version has one fewer zero than the positive version. + +### Width + +This is a parameter for the "minimum width" that the format should take up. If +the value's string does not fill up this many characters, then the padding +specified by fill/alignment will be used to take up the required space. + +The default fill/alignment for non-numerics is a space and left-aligned. The +defaults for numeric formatters is also a space but with right-alignment. If the +'0' flag is specified for numerics, then the implicit fill character is '0'. + +The value for the width can also be provided as a `uint` in the list of +parameters by using the `2$` syntax indicating that the second argument is a +`uint` specifying the width. + +### Precision + +For non-numeric types, this can be considered a "maximum width". If the +resulting string is longer than this width, then it is truncated down to this +many characters and only those are emitted. + +For integral types, this has no meaning currently. + +For floating-point types, this indicates how many digits after the decimal point +should be printed. + +## Escaping + +The literal characters `{`, `}`, or `#` may be included in a string by +preceding them with the `\` character. Since `\` is already an +escape character in Rust strings, a string literal using this escape +will look like `"\\{"`. + +*/ + +use io::Writer; +use io; +use option::None; +use repr; +use result::{Ok, Err}; +use str::{StrAllocating}; +use str; +use strbuf::StrBuf; +use slice::Vector; + +pub use core::fmt::{Formatter, Result, FormatWriter, Show, rt}; +pub use core::fmt::{Show, Bool, Char, Signed, Unsigned, Octal, Binary}; +pub use core::fmt::{LowerHex, UpperHex, String, Pointer}; +pub use core::fmt::{Float, LowerExp, UpperExp}; +pub use core::fmt::{FormatError, WriteError}; +pub use core::fmt::{Argument, Arguments, write, radix, Radix, RadixFmt}; + +#[doc(hidden)] +pub use core::fmt::{argument, argumentstr, argumentuint}; +#[doc(hidden)] +pub use core::fmt::{secret_show, secret_string, secret_unsigned}; +#[doc(hidden)] +pub use core::fmt::{secret_signed, secret_lower_hex, secret_upper_hex}; +#[doc(hidden)] +pub use core::fmt::{secret_bool, secret_char, secret_octal, secret_binary}; +#[doc(hidden)] +pub use core::fmt::{secret_bool, secret_char, secret_octal, secret_binary}; +#[doc(hidden)] +pub use core::fmt::{secret_float, secret_upper_exp, secret_lower_exp}; +#[doc(hidden)] +pub use core::fmt::{secret_pointer}; + +#[doc(hidden)] +pub fn secret_poly<T: Poly>(x: &T, fmt: &mut Formatter) -> Result { + // FIXME #11938 - UFCS would make us able call the this method + // directly Poly::fmt(x, fmt). + x.fmt(fmt) +} + +/// Format trait for the `?` character +pub trait Poly { + /// Formats the value using the given formatter. + fn fmt(&self, &mut Formatter) -> Result; +} + +/// The format function takes a precompiled format string and a list of +/// arguments, to return the resulting formatted string. +/// +/// # Arguments +/// +/// * args - a structure of arguments generated via the `format_args!` macro. +/// Because this structure can only be safely generated at +/// compile-time, this function is safe. +/// +/// # Example +/// +/// ```rust +/// use std::fmt; +/// +/// let s = format_args!(fmt::format, "Hello, {}!", "world"); +/// assert_eq!(s, "Hello, world!".to_owned()); +/// ``` +pub fn format(args: &Arguments) -> ~str { + let mut output = io::MemWriter::new(); + let _ = write!(&mut output, "{}", args); + str::from_utf8(output.unwrap().as_slice()).unwrap().to_owned() +} + +/// Temporary transition utility +pub fn format_strbuf(args: &Arguments) -> StrBuf { + let mut output = io::MemWriter::new(); + let _ = write!(&mut output, "{}", args); + str::from_utf8(output.unwrap().as_slice()).unwrap().into_strbuf() +} + +impl<T> Poly for T { + fn fmt(&self, f: &mut Formatter) -> Result { + match (f.width, f.precision) { + (None, None) => { + match repr::write_repr(f, self) { + Ok(()) => Ok(()), + Err(..) => Err(WriteError), + } + } + + // If we have a specified width for formatting, then we have to make + // this allocation of a new string + _ => { + let s = repr::repr_to_str(self); + f.pad(s) + } + } + } +} + +impl<'a> Writer for Formatter<'a> { + fn write(&mut self, b: &[u8]) -> io::IoResult<()> { + match (*self).write(b) { + Ok(()) => Ok(()), + Err(WriteError) => Err(io::standard_error(io::OtherIoError)) + } + } +} diff --git a/src/libstd/fmt/mod.rs b/src/libstd/fmt/mod.rs deleted file mode 100644 index d4f12f590ae..00000000000 --- a/src/libstd/fmt/mod.rs +++ /dev/null @@ -1,1405 +0,0 @@ -// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT -// file at the top-level directory of this distribution and at -// http://rust-lang.org/COPYRIGHT. -// -// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or -// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license -// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your -// option. This file may not be copied, modified, or distributed -// except according to those terms. - -/*! - -Utilities for formatting and printing strings - -This module contains the runtime support for the `format!` syntax extension. -This macro is implemented in the compiler to emit calls to this module in order -to format arguments at runtime into strings and streams. - -The functions contained in this module should not normally be used in everyday -use cases of `format!`. The assumptions made by these functions are unsafe for -all inputs, and the compiler performs a large amount of validation on the -arguments to `format!` in order to ensure safety at runtime. While it is -possible to call these functions directly, it is not recommended to do so in the -general case. - -## Usage - -The `format!` macro is intended to be familiar to those coming from C's -printf/fprintf functions or Python's `str.format` function. In its current -revision, the `format!` macro returns a `~str` type which is the result of the -formatting. In the future it will also be able to pass in a stream to format -arguments directly while performing minimal allocations. - -Some examples of the `format!` extension are: - -```rust -format!("Hello"); // => "Hello".to_owned() -format!("Hello, {:s}!", "world"); // => "Hello, world!".to_owned() -format!("The number is {:d}", 1); // => "The number is 1".to_owned() -format!("{:?}", ~[3, 4]); // => "~[3, 4]".to_owned() -format!("{value}", value=4); // => "4".to_owned() -format!("{} {}", 1, 2); // => "1 2".to_owned() -``` - -From these, you can see that the first argument is a format string. It is -required by the compiler for this to be a string literal; it cannot be a -variable passed in (in order to perform validity checking). The compiler will -then parse the format string and determine if the list of arguments provided is -suitable to pass to this format string. - -### Positional parameters - -Each formatting argument is allowed to specify which value argument it's -referencing, and if omitted it is assumed to be "the next argument". For -example, the format string `{} {} {}` would take three parameters, and they -would be formatted in the same order as they're given. The format string -`{2} {1} {0}`, however, would format arguments in reverse order. - -Things can get a little tricky once you start intermingling the two types of -positional specifiers. The "next argument" specifier can be thought of as an -iterator over the argument. Each time a "next argument" specifier is seen, the -iterator advances. This leads to behavior like this: - -```rust -format!("{1} {} {0} {}", 1, 2); // => "2 1 1 2".to_owned() -``` - -The internal iterator over the argument has not been advanced by the time the -first `{}` is seen, so it prints the first argument. Then upon reaching the -second `{}`, the iterator has advanced forward to the second argument. -Essentially, parameters which explicitly name their argument do not affect -parameters which do not name an argument in terms of positional specifiers. - -A format string is required to use all of its arguments, otherwise it is a -compile-time error. You may refer to the same argument more than once in the -format string, although it must always be referred to with the same type. - -### Named parameters - -Rust itself does not have a Python-like equivalent of named parameters to a -function, but the `format!` macro is a syntax extension which allows it to -leverage named parameters. Named parameters are listed at the end of the -argument list and have the syntax: - -```notrust -identifier '=' expression -``` - -For example, the following `format!` expressions all use named argument: - -```rust -format!("{argument}", argument = "test"); // => "test".to_owned() -format!("{name} {}", 1, name = 2); // => "2 1".to_owned() -format!("{a:s} {c:d} {b:?}", a="a", b=(), c=3); // => "a 3 ()".to_owned() -``` - -It is illegal to put positional parameters (those without names) after arguments -which have names. Like positional parameters, it is illegal to provided named -parameters that are unused by the format string. - -### Argument types - -Each argument's type is dictated by the format string. It is a requirement that -every argument is only ever referred to by one type. When specifying the format -of an argument, however, a string like `{}` indicates no type. This is allowed, -and if all references to one argument do not provide a type, then the format `?` -is used (the type's rust-representation is printed). For example, this is an -invalid format string: - -```notrust -{0:d} {0:s} -``` - -Because the first argument is both referred to as an integer as well as a -string. - -Because formatting is done via traits, there is no requirement that the -`d` format actually takes an `int`, but rather it simply requires a type which -ascribes to the `Signed` formatting trait. There are various parameters which do -require a particular type, however. Namely if the syntax `{:.*s}` is used, then -the number of characters to print from the string precedes the actual string and -must have the type `uint`. Although a `uint` can be printed with `{:u}`, it is -illegal to reference an argument as such. For example, this is another invalid -format string: - -```notrust -{:.*s} {0:u} -``` - -### Formatting traits - -When requesting that an argument be formatted with a particular type, you are -actually requesting that an argument ascribes to a particular trait. This allows -multiple actual types to be formatted via `{:d}` (like `i8` as well as `int`). -The current mapping of types to traits is: - -* `?` ⇒ `Poly` -* `d` ⇒ `Signed` -* `i` ⇒ `Signed` -* `u` ⇒ `Unsigned` -* `b` ⇒ `Bool` -* `c` ⇒ `Char` -* `o` ⇒ `Octal` -* `x` ⇒ `LowerHex` -* `X` ⇒ `UpperHex` -* `s` ⇒ `String` -* `p` ⇒ `Pointer` -* `t` ⇒ `Binary` -* `f` ⇒ `Float` -* `e` ⇒ `LowerExp` -* `E` ⇒ `UpperExp` -* *nothing* ⇒ `Show` - -What this means is that any type of argument which implements the -`std::fmt::Binary` trait can then be formatted with `{:t}`. Implementations are -provided for these traits for a number of primitive types by the standard -library as well. If no format is specified (as in `{}` or `{:6}`), then the -format trait used is the `Show` trait. This is one of the more commonly -implemented traits when formatting a custom type. - -When implementing a format trait for your own type, you will have to implement a -method of the signature: - -```rust -# use std; -# mod fmt { pub type Result = (); } -# struct T; -# trait SomeName<T> { -fn fmt(&self, f: &mut std::fmt::Formatter) -> fmt::Result; -# } -``` - -Your type will be passed as `self` by-reference, and then the function should -emit output into the `f.buf` stream. It is up to each format trait -implementation to correctly adhere to the requested formatting parameters. The -values of these parameters will be listed in the fields of the `Formatter` -struct. In order to help with this, the `Formatter` struct also provides some -helper methods. - -Additionally, the return value of this function is `fmt::Result` which is a -typedef to `Result<(), IoError>` (also known as `IoError<()>`). Formatting -implementations should ensure that they return errors from `write!` correctly -(propagating errors upward). - -An example of implementing the formatting traits would look -like: - -```rust -use std::fmt; -use std::f64; - -struct Vector2D { - x: int, - y: int, -} - -impl fmt::Show for Vector2D { - fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - // The `f.buf` value is of the type `&mut io::Writer`, which is what the - // write! macro is expecting. Note that this formatting ignores the - // various flags provided to format strings. - write!(f.buf, "({}, {})", self.x, self.y) - } -} - -// Different traits allow different forms of output of a type. The meaning of -// this format is to print the magnitude of a vector. -impl fmt::Binary for Vector2D { - fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - let magnitude = (self.x * self.x + self.y * self.y) as f64; - let magnitude = magnitude.sqrt(); - - // Respect the formatting flags by using the helper method - // `pad_integral` on the Formatter object. See the method documentation - // for details, and the function `pad` can be used to pad strings. - let decimals = f.precision.unwrap_or(3); - let string = f64::to_str_exact(magnitude, decimals); - f.pad_integral(true, "", string.as_bytes()) - } -} - -fn main() { - let myvector = Vector2D { x: 3, y: 4 }; - - println!("{}", myvector); // => "(3, 4)" - println!("{:10.3t}", myvector); // => " 5.000" -} -``` - -### Related macros - -There are a number of related macros in the `format!` family. The ones that are -currently implemented are: - -```ignore -format! // described above -write! // first argument is a &mut io::Writer, the destination -writeln! // same as write but appends a newline -print! // the format string is printed to the standard output -println! // same as print but appends a newline -format_args! // described below. -``` - - -#### `write!` - -This and `writeln` are two macros which are used to emit the format string to a -specified stream. This is used to prevent intermediate allocations of format -strings and instead directly write the output. Under the hood, this function is -actually invoking the `write` function defined in this module. Example usage is: - -```rust -# #![allow(unused_must_use)] -use std::io; - -let mut w = io::MemWriter::new(); -write!(&mut w as &mut io::Writer, "Hello {}!", "world"); -``` - -#### `print!` - -This and `println` emit their output to stdout. Similarly to the `write!` macro, -the goal of these macros is to avoid intermediate allocations when printing -output. Example usage is: - -```rust -print!("Hello {}!", "world"); -println!("I have a newline {}", "character at the end"); -``` - -#### `format_args!` -This is a curious macro which is used to safely pass around -an opaque object describing the format string. This object -does not require any heap allocations to create, and it only -references information on the stack. Under the hood, all of -the related macros are implemented in terms of this. First -off, some example usage is: - -``` -use std::fmt; -use std::io; - -# #[allow(unused_must_use)] -# fn main() { -format_args!(fmt::format, "this returns {}", "~str"); - -let some_writer: &mut io::Writer = &mut io::stdout(); -format_args!(|args| { fmt::write(some_writer, args) }, "print with a {}", "closure"); - -fn my_fmt_fn(args: &fmt::Arguments) { - fmt::write(&mut io::stdout(), args); -} -format_args!(my_fmt_fn, "or a {} too", "function"); -# } -``` - -The first argument of the `format_args!` macro is a function (or closure) which -takes one argument of type `&fmt::Arguments`. This structure can then be -passed to the `write` and `format` functions inside this module in order to -process the format string. The goal of this macro is to even further prevent -intermediate allocations when dealing formatting strings. - -For example, a logging library could use the standard formatting syntax, but it -would internally pass around this structure until it has been determined where -output should go to. - -It is unsafe to programmatically create an instance of `fmt::Arguments` because -the operations performed when executing a format string require the compile-time -checks provided by the compiler. The `format_args!` macro is the only method of -safely creating these structures, but they can be unsafely created with the -constructor provided. - -## Internationalization - -The formatting syntax supported by the `format!` extension supports -internationalization by providing "methods" which execute various different -outputs depending on the input. The syntax and methods provided are similar to -other internationalization systems, so again nothing should seem alien. -Currently two methods are supported by this extension: "select" and "plural". - -Each method will execute one of a number of clauses, and then the value of the -clause will become what's the result of the argument's format. Inside of the -cases, nested argument strings may be provided, but all formatting arguments -must not be done through implicit positional means. All arguments inside of each -case of a method must be explicitly selected by their name or their integer -position. - -Furthermore, whenever a case is running, the special character `#` can be used -to reference the string value of the argument which was selected upon. As an -example: - -```rust -format!("{0, select, other{#}}", "hello"); // => "hello".to_owned() -``` - -This example is the equivalent of `{0:s}` essentially. - -### Select - -The select method is a switch over a `&str` parameter, and the parameter *must* -be of the type `&str`. An example of the syntax is: - -```notrust -{0, select, male{...} female{...} other{...}} -``` - -Breaking this down, the `0`-th argument is selected upon with the `select` -method, and then a number of cases follow. Each case is preceded by an -identifier which is the match-clause to execute the given arm. In this case, -there are two explicit cases, `male` and `female`. The case will be executed if -the string argument provided is an exact match to the case selected. - -The `other` case is also a required case for all `select` methods. This arm will -be executed if none of the other arms matched the word being selected over. - -### Plural - -The plural method is a switch statement over a `uint` parameter, and the -parameter *must* be a `uint`. A plural method in its full glory can be specified -as: - -```notrust -{0, plural, offset=1 =1{...} two{...} many{...} other{...}} -``` - -To break this down, the first `0` indicates that this method is selecting over -the value of the first positional parameter to the format string. Next, the -`plural` method is being executed. An optionally-supplied `offset` is then given -which indicates a number to subtract from argument `0` when matching. This is -then followed by a list of cases. - -Each case is allowed to supply a specific value to match upon with the syntax -`=N`. This case is executed if the value at argument `0` matches N exactly, -without taking the offset into account. A case may also be specified by one of -five keywords: `zero`, `one`, `two`, `few`, and `many`. These cases are matched -on after argument `0` has the offset taken into account. Currently the -definitions of `many` and `few` are hardcoded, but they are in theory defined by -the current locale. - -Finally, all `plural` methods must have an `other` case supplied which will be -executed if none of the other cases match. - -## Syntax - -The syntax for the formatting language used is drawn from other languages, so it -should not be too alien. Arguments are formatted with python-like syntax, -meaning that arguments are surrounded by `{}` instead of the C-like `%`. The -actual grammar for the formatting syntax is: - -```notrust -format_string := <text> [ format <text> ] * -format := '{' [ argument ] [ ':' format_spec ] [ ',' function_spec ] '}' -argument := integer | identifier - -format_spec := [[fill]align][sign]['#'][0][width]['.' precision][type] -fill := character -align := '<' | '>' -sign := '+' | '-' -width := count -precision := count | '*' -type := identifier | '' -count := parameter | integer -parameter := integer '$' - -function_spec := plural | select -select := 'select' ',' ( identifier arm ) * -plural := 'plural' ',' [ 'offset:' integer ] ( selector arm ) * -selector := '=' integer | keyword -keyword := 'zero' | 'one' | 'two' | 'few' | 'many' | 'other' -arm := '{' format_string '}' -``` - -## Formatting Parameters - -Each argument being formatted can be transformed by a number of formatting -parameters (corresponding to `format_spec` in the syntax above). These -parameters affect the string representation of what's being formatted. This -syntax draws heavily from Python's, so it may seem a bit familiar. - -### Fill/Alignment - -The fill character is provided normally in conjunction with the `width` -parameter. This indicates that if the value being formatted is smaller than -`width` some extra characters will be printed around it. The extra characters -are specified by `fill`, and the alignment can be one of two options: - -* `<` - the argument is left-aligned in `width` columns -* `>` - the argument is right-aligned in `width` columns - -### Sign/#/0 - -These can all be interpreted as flags for a particular formatter. - -* '+' - This is intended for numeric types and indicates that the sign should - always be printed. Positive signs are never printed by default, and the - negative sign is only printed by default for the `Signed` trait. This - flag indicates that the correct sign (+ or -) should always be printed. -* '-' - Currently not used -* '#' - This flag is indicates that the "alternate" form of printing should be - used. By default, this only applies to the integer formatting traits and - performs like: - * `x` - precedes the argument with a "0x" - * `X` - precedes the argument with a "0x" - * `t` - precedes the argument with a "0b" - * `o` - precedes the argument with a "0o" -* '0' - This is used to indicate for integer formats that the padding should - both be done with a `0` character as well as be sign-aware. A format - like `{:08d}` would yield `00000001` for the integer `1`, while the same - format would yield `-0000001` for the integer `-1`. Notice that the - negative version has one fewer zero than the positive version. - -### Width - -This is a parameter for the "minimum width" that the format should take up. If -the value's string does not fill up this many characters, then the padding -specified by fill/alignment will be used to take up the required space. - -The default fill/alignment for non-numerics is a space and left-aligned. The -defaults for numeric formatters is also a space but with right-alignment. If the -'0' flag is specified for numerics, then the implicit fill character is '0'. - -The value for the width can also be provided as a `uint` in the list of -parameters by using the `2$` syntax indicating that the second argument is a -`uint` specifying the width. - -### Precision - -For non-numeric types, this can be considered a "maximum width". If the -resulting string is longer than this width, then it is truncated down to this -many characters and only those are emitted. - -For integral types, this has no meaning currently. - -For floating-point types, this indicates how many digits after the decimal point -should be printed. - -## Escaping - -The literal characters `{`, `}`, or `#` may be included in a string by -preceding them with the `\` character. Since `\` is already an -escape character in Rust strings, a string literal using this escape -will look like `"\\{"`. - -*/ - -use any; -use cell::Cell; -use char::Char; -use cmp; -use container::Container; -use intrinsics::TypeId; -use io::MemWriter; -use io; -use iter::{Iterator, range}; -use iter; -use kinds::Copy; -use mem; -use num::Signed; -use option::{Option, Some, None}; -use owned::Box; -use repr; -use result::{Ok, Err, ResultUnwrap}; -use slice::{Vector, ImmutableVector}; -use slice; -use str::{StrSlice, StrAllocating, UTF16Item, ScalarValue, LoneSurrogate}; -use str; -use strbuf::StrBuf; - -pub use self::num::radix; -pub use self::num::Radix; -pub use self::num::RadixFmt; - -mod num; -pub mod rt; - -pub type Result = io::IoResult<()>; - -/// A struct to represent both where to emit formatting strings to and how they -/// should be formatted. A mutable version of this is passed to all formatting -/// traits. -pub struct Formatter<'a> { - /// Flags for formatting (packed version of rt::Flag) - pub flags: uint, - /// Character used as 'fill' whenever there is alignment - pub fill: char, - /// Boolean indication of whether the output should be left-aligned - pub align: rt::Alignment, - /// Optionally specified integer width that the output should be - pub width: Option<uint>, - /// Optionally specified precision for numeric types - pub precision: Option<uint>, - - /// Output buffer. - pub buf: &'a mut io::Writer, - curarg: slice::Items<'a, Argument<'a>>, - args: &'a [Argument<'a>], -} - -/// This struct represents the generic "argument" which is taken by the Xprintf -/// family of functions. It contains a function to format the given value. At -/// compile time it is ensured that the function and the value have the correct -/// types, and then this struct is used to canonicalize arguments to one type. -pub struct Argument<'a> { - formatter: extern "Rust" fn(&any::Void, &mut Formatter) -> Result, - value: &'a any::Void, -} - -impl<'a> Arguments<'a> { - /// When using the format_args!() macro, this function is used to generate the - /// Arguments structure. The compiler inserts an `unsafe` block to call this, - /// which is valid because the compiler performs all necessary validation to - /// ensure that the resulting call to format/write would be safe. - #[doc(hidden)] #[inline] - pub unsafe fn new<'a>(fmt: &'static [rt::Piece<'static>], - args: &'a [Argument<'a>]) -> Arguments<'a> { - Arguments{ fmt: mem::transmute(fmt), args: args } - } -} - -/// This structure represents a safely precompiled version of a format string -/// and its arguments. This cannot be generated at runtime because it cannot -/// safely be done so, so no constructors are given and the fields are private -/// to prevent modification. -/// -/// The `format_args!` macro will safely create an instance of this structure -/// and pass it to a user-supplied function. The macro validates the format -/// string at compile-time so usage of the `write` and `format` functions can -/// be safely performed. -pub struct Arguments<'a> { - fmt: &'a [rt::Piece<'a>], - args: &'a [Argument<'a>], -} - -impl<'a> Show for Arguments<'a> { - fn fmt(&self, fmt: &mut Formatter) -> Result { - write(fmt.buf, self) - } -} - -/// When a format is not otherwise specified, types are formatted by ascribing -/// to this trait. There is not an explicit way of selecting this trait to be -/// used for formatting, it is only if no other format is specified. -pub trait Show { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `b` character -pub trait Bool { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `c` character -pub trait Char { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `i` and `d` characters -pub trait Signed { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `u` character -pub trait Unsigned { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `o` character -pub trait Octal { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `t` character -pub trait Binary { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `x` character -pub trait LowerHex { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `X` character -pub trait UpperHex { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `s` character -pub trait String { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `?` character -pub trait Poly { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `p` character -pub trait Pointer { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `f` character -pub trait Float { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `e` character -pub trait LowerExp { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -/// Format trait for the `E` character -pub trait UpperExp { - /// Formats the value using the given formatter. - fn fmt(&self, &mut Formatter) -> Result; -} - -// FIXME #11938 - UFCS would make us able call the above methods -// directly Show::show(x, fmt). -macro_rules! uniform_fn_call_workaround { - ($( $name: ident, $trait_: ident; )*) => { - $( - #[doc(hidden)] - pub fn $name<T: $trait_>(x: &T, fmt: &mut Formatter) -> Result { - x.fmt(fmt) - } - )* - } -} -uniform_fn_call_workaround! { - secret_show, Show; - secret_bool, Bool; - secret_char, Char; - secret_signed, Signed; - secret_unsigned, Unsigned; - secret_octal, Octal; - secret_binary, Binary; - secret_lower_hex, LowerHex; - secret_upper_hex, UpperHex; - secret_string, String; - secret_poly, Poly; - secret_pointer, Pointer; - secret_float, Float; - secret_lower_exp, LowerExp; - secret_upper_exp, UpperExp; -} - -/// The `write` function takes an output stream, a precompiled format string, -/// and a list of arguments. The arguments will be formatted according to the -/// specified format string into the output stream provided. -/// -/// # Arguments -/// -/// * output - the buffer to write output to -/// * args - the precompiled arguments generated by `format_args!` -/// -/// # Example -/// -/// ```rust -/// # #![allow(unused_must_use)] -/// use std::fmt; -/// use std::io; -/// -/// let mut w = io::stdout(); -/// format_args!(|args| { fmt::write(&mut w, args); }, "Hello, {}!", "world"); -/// ``` -pub fn write(output: &mut io::Writer, args: &Arguments) -> Result { - unsafe { write_unsafe(output, args.fmt, args.args) } -} - -/// The `writeln` function takes the same arguments as `write`, except that it -/// will also write a newline (`\n`) character at the end of the format string. -pub fn writeln(output: &mut io::Writer, args: &Arguments) -> Result { - let first = unsafe { write_unsafe(output, args.fmt, args.args) }; - first.and_then(|()| output.write(['\n' as u8])) -} - -/// The `write_unsafe` function takes an output stream, a precompiled format -/// string, and a list of arguments. The arguments will be formatted according -/// to the specified format string into the output stream provided. -/// -/// See the documentation for `format` for why this function is unsafe and care -/// should be taken if calling it manually. -/// -/// Thankfully the rust compiler provides macros like `write!` and -/// `format_args!` which perform all of this validation at compile-time -/// and provide a safe interface for invoking this function. -/// -/// # Arguments -/// -/// * output - the buffer to write output to -/// * fmts - the precompiled format string to emit -/// * args - the list of arguments to the format string. These are only the -/// positional arguments (not named) -/// -/// Note that this function assumes that there are enough arguments for the -/// format string. -pub unsafe fn write_unsafe(output: &mut io::Writer, - fmt: &[rt::Piece], - args: &[Argument]) -> Result { - let mut formatter = Formatter { - flags: 0, - width: None, - precision: None, - buf: output, - align: rt::AlignUnknown, - fill: ' ', - args: args, - curarg: args.iter(), - }; - for piece in fmt.iter() { - try!(formatter.run(piece, None)); - } - Ok(()) -} - -/// The format function takes a precompiled format string and a list of -/// arguments, to return the resulting formatted string. -/// -/// # Arguments -/// -/// * args - a structure of arguments generated via the `format_args!` macro. -/// Because this structure can only be safely generated at -/// compile-time, this function is safe. -/// -/// # Example -/// -/// ```rust -/// use std::fmt; -/// -/// let s = format_args!(fmt::format, "Hello, {}!", "world"); -/// assert_eq!(s, "Hello, world!".to_owned()); -/// ``` -pub fn format(args: &Arguments) -> ~str { - unsafe { format_unsafe(args.fmt, args.args) } -} - -/// Temporary transitionary thing. -pub fn format_strbuf(args: &Arguments) -> StrBuf { - unsafe { format_unsafe_strbuf(args.fmt, args.args) } -} - -/// The unsafe version of the formatting function. -/// -/// This is currently an unsafe function because the types of all arguments -/// aren't verified by immediate callers of this function. This currently does -/// not validate that the correct types of arguments are specified for each -/// format specifier, nor that each argument itself contains the right function -/// for formatting the right type value. Because of this, the function is marked -/// as `unsafe` if this is being called manually. -/// -/// Thankfully the rust compiler provides the macro `format!` which will perform -/// all of this validation at compile-time and provides a safe interface for -/// invoking this function. -/// -/// # Arguments -/// -/// * fmts - the precompiled format string to emit. -/// * args - the list of arguments to the format string. These are only the -/// positional arguments (not named) -/// -/// Note that this function assumes that there are enough arguments for the -/// format string. -pub unsafe fn format_unsafe(fmt: &[rt::Piece], args: &[Argument]) -> ~str { - let mut output = MemWriter::new(); - write_unsafe(&mut output as &mut io::Writer, fmt, args).unwrap(); - return str::from_utf8(output.unwrap().as_slice()).unwrap().to_owned(); -} - -/// Temporary transitionary thing. -pub unsafe fn format_unsafe_strbuf(fmt: &[rt::Piece], args: &[Argument]) - -> StrBuf { - let mut output = MemWriter::new(); - write_unsafe(&mut output as &mut io::Writer, fmt, args).unwrap(); - return str::from_utf8(output.unwrap().as_slice()).unwrap().into_strbuf(); -} - -impl<'a> Formatter<'a> { - - // First up is the collection of functions used to execute a format string - // at runtime. This consumes all of the compile-time statics generated by - // the format! syntax extension. - - fn run(&mut self, piece: &rt::Piece, cur: Option<&str>) -> Result { - match *piece { - rt::String(s) => self.buf.write(s.as_bytes()), - rt::CurrentArgument(()) => self.buf.write(cur.unwrap().as_bytes()), - rt::Argument(ref arg) => { - // Fill in the format parameters into the formatter - self.fill = arg.format.fill; - self.align = arg.format.align; - self.flags = arg.format.flags; - self.width = self.getcount(&arg.format.width); - self.precision = self.getcount(&arg.format.precision); - - // Extract the correct argument - let value = match arg.position { - rt::ArgumentNext => { *self.curarg.next().unwrap() } - rt::ArgumentIs(i) => self.args[i], - }; - - // Then actually do some printing - match arg.method { - None => (value.formatter)(value.value, self), - Some(ref method) => self.execute(*method, value) - } - } - } - } - - fn getcount(&mut self, cnt: &rt::Count) -> Option<uint> { - match *cnt { - rt::CountIs(n) => { Some(n) } - rt::CountImplied => { None } - rt::CountIsParam(i) => { - let v = self.args[i].value; - unsafe { Some(*(v as *any::Void as *uint)) } - } - rt::CountIsNextParam => { - let v = self.curarg.next().unwrap().value; - unsafe { Some(*(v as *any::Void as *uint)) } - } - } - } - - fn execute(&mut self, method: &rt::Method, arg: Argument) -> Result { - match *method { - // Pluralization is selection upon a numeric value specified as the - // parameter. - rt::Plural(offset, ref selectors, ref default) => { - // This is validated at compile-time to be a pointer to a - // '&uint' value. - let value: &uint = unsafe { mem::transmute(arg.value) }; - let value = *value; - - // First, attempt to match against explicit values without the - // offsetted value - for s in selectors.iter() { - match s.selector { - rt::Literal(val) if value == val => { - return self.runplural(value, s.result); - } - _ => {} - } - } - - // Next, offset the value and attempt to match against the - // keyword selectors. - let value = value - match offset { Some(i) => i, None => 0 }; - for s in selectors.iter() { - let run = match s.selector { - rt::Keyword(rt::Zero) => value == 0, - rt::Keyword(rt::One) => value == 1, - rt::Keyword(rt::Two) => value == 2, - - // FIXME: Few/Many should have a user-specified boundary - // One possible option would be in the function - // pointer of the 'arg: Argument' struct. - rt::Keyword(rt::Few) => value < 8, - rt::Keyword(rt::Many) => value >= 8, - - rt::Literal(..) => false - }; - if run { - return self.runplural(value, s.result); - } - } - - self.runplural(value, *default) - } - - // Select is just a matching against the string specified. - rt::Select(ref selectors, ref default) => { - // This is validated at compile-time to be a pointer to a - // string slice, - let value: & &str = unsafe { mem::transmute(arg.value) }; - let value = *value; - - for s in selectors.iter() { - if s.selector == value { - for piece in s.result.iter() { - try!(self.run(piece, Some(value))); - } - return Ok(()); - } - } - for piece in default.iter() { - try!(self.run(piece, Some(value))); - } - Ok(()) - } - } - } - - fn runplural(&mut self, value: uint, pieces: &[rt::Piece]) -> Result { - ::uint::to_str_bytes(value, 10, |buf| { - let valuestr = str::from_utf8(buf).unwrap(); - for piece in pieces.iter() { - try!(self.run(piece, Some(valuestr))); - } - Ok(()) - }) - } - - // Helper methods used for padding and processing formatting arguments that - // all formatting traits can use. - - /// Performs the correct padding for an integer which has already been - /// emitted into a byte-array. The byte-array should *not* contain the sign - /// for the integer, that will be added by this method. - /// - /// # Arguments - /// - /// * is_positive - whether the original integer was positive or not. - /// * prefix - if the '#' character (FlagAlternate) is provided, this - /// is the prefix to put in front of the number. - /// * buf - the byte array that the number has been formatted into - /// - /// This function will correctly account for the flags provided as well as - /// the minimum width. It will not take precision into account. - pub fn pad_integral(&mut self, is_positive: bool, prefix: &str, buf: &[u8]) -> Result { - use fmt::rt::{FlagAlternate, FlagSignPlus, FlagSignAwareZeroPad}; - - let mut width = buf.len(); - - let mut sign = None; - if !is_positive { - sign = Some('-'); width += 1; - } else if self.flags & (1 << (FlagSignPlus as uint)) != 0 { - sign = Some('+'); width += 1; - } - - let mut prefixed = false; - if self.flags & (1 << (FlagAlternate as uint)) != 0 { - prefixed = true; width += prefix.len(); - } - - // Writes the sign if it exists, and then the prefix if it was requested - let write_prefix = |f: &mut Formatter| { - for c in sign.move_iter() { try!(f.buf.write_char(c)); } - if prefixed { f.buf.write_str(prefix) } - else { Ok(()) } - }; - - // The `width` field is more of a `min-width` parameter at this point. - match self.width { - // If there's no minimum length requirements then we can just - // write the bytes. - None => { - try!(write_prefix(self)); self.buf.write(buf) - } - // Check if we're over the minimum width, if so then we can also - // just write the bytes. - Some(min) if width >= min => { - try!(write_prefix(self)); self.buf.write(buf) - } - // The sign and prefix goes before the padding if the fill character - // is zero - Some(min) if self.flags & (1 << (FlagSignAwareZeroPad as uint)) != 0 => { - self.fill = '0'; - try!(write_prefix(self)); - self.with_padding(min - width, rt::AlignRight, |f| f.buf.write(buf)) - } - // Otherwise, the sign and prefix goes after the padding - Some(min) => { - self.with_padding(min - width, rt::AlignRight, |f| { - try!(write_prefix(f)); f.buf.write(buf) - }) - } - } - } - - /// This function takes a string slice and emits it to the internal buffer - /// after applying the relevant formatting flags specified. The flags - /// recognized for generic strings are: - /// - /// * width - the minimum width of what to emit - /// * fill/align - what to emit and where to emit it if the string - /// provided needs to be padded - /// * precision - the maximum length to emit, the string is truncated if it - /// is longer than this length - /// - /// Notably this function ignored the `flag` parameters - pub fn pad(&mut self, s: &str) -> Result { - // Make sure there's a fast path up front - if self.width.is_none() && self.precision.is_none() { - return self.buf.write(s.as_bytes()); - } - // The `precision` field can be interpreted as a `max-width` for the - // string being formatted - match self.precision { - Some(max) => { - // If there's a maximum width and our string is longer than - // that, then we must always have truncation. This is the only - // case where the maximum length will matter. - let char_len = s.char_len(); - if char_len >= max { - let nchars = ::cmp::min(max, char_len); - return self.buf.write(s.slice_chars(0, nchars).as_bytes()); - } - } - None => {} - } - // The `width` field is more of a `min-width` parameter at this point. - match self.width { - // If we're under the maximum length, and there's no minimum length - // requirements, then we can just emit the string - None => self.buf.write(s.as_bytes()), - // If we're under the maximum width, check if we're over the minimum - // width, if so it's as easy as just emitting the string. - Some(width) if s.char_len() >= width => { - self.buf.write(s.as_bytes()) - } - // If we're under both the maximum and the minimum width, then fill - // up the minimum width with the specified string + some alignment. - Some(width) => { - self.with_padding(width - s.len(), rt::AlignLeft, |me| { - me.buf.write(s.as_bytes()) - }) - } - } - } - - /// Runs a callback, emitting the correct padding either before or - /// afterwards depending on whether right or left alingment is requested. - fn with_padding(&mut self, - padding: uint, - default: rt::Alignment, - f: |&mut Formatter| -> Result) -> Result { - let align = match self.align { - rt::AlignUnknown => default, - rt::AlignLeft | rt::AlignRight => self.align - }; - if align == rt::AlignLeft { - try!(f(self)); - } - let mut fill = [0u8, ..4]; - let len = self.fill.encode_utf8(fill); - for _ in range(0, padding) { - try!(self.buf.write(fill.slice_to(len))); - } - if align == rt::AlignRight { - try!(f(self)); - } - Ok(()) - } -} - -/// This is a function which calls are emitted to by the compiler itself to -/// create the Argument structures that are passed into the `format` function. -#[doc(hidden)] #[inline] -pub fn argument<'a, T>(f: extern "Rust" fn(&T, &mut Formatter) -> Result, - t: &'a T) -> Argument<'a> { - unsafe { - Argument { - formatter: mem::transmute(f), - value: mem::transmute(t) - } - } -} - -/// When the compiler determines that the type of an argument *must* be a string -/// (such as for select), then it invokes this method. -#[doc(hidden)] #[inline] -pub fn argumentstr<'a>(s: &'a &str) -> Argument<'a> { - argument(secret_string, s) -} - -/// When the compiler determines that the type of an argument *must* be a uint -/// (such as for plural), then it invokes this method. -#[doc(hidden)] #[inline] -pub fn argumentuint<'a>(s: &'a uint) -> Argument<'a> { - argument(secret_unsigned, s) -} - -// Implementations of the core formatting traits - -impl<T: Show> Show for @T { - fn fmt(&self, f: &mut Formatter) -> Result { secret_show(&**self, f) } -} -impl<T: Show> Show for Box<T> { - fn fmt(&self, f: &mut Formatter) -> Result { secret_show(&**self, f) } -} -impl<'a, T: Show> Show for &'a T { - fn fmt(&self, f: &mut Formatter) -> Result { secret_show(*self, f) } -} -impl<'a, T: Show> Show for &'a mut T { - fn fmt(&self, f: &mut Formatter) -> Result { secret_show(*self, f) } -} - -impl Bool for bool { - fn fmt(&self, f: &mut Formatter) -> Result { - secret_string(&(if *self {"true"} else {"false"}), f) - } -} - -impl<'a, T: str::Str> String for T { - fn fmt(&self, f: &mut Formatter) -> Result { - f.pad(self.as_slice()) - } -} - -impl Char for char { - fn fmt(&self, f: &mut Formatter) -> Result { - let mut utf8 = [0u8, ..4]; - let amt = self.encode_utf8(utf8); - let s: &str = unsafe { mem::transmute(utf8.slice_to(amt)) }; - secret_string(&s, f) - } -} - -macro_rules! floating(($ty:ident) => { - impl Float for $ty { - fn fmt(&self, fmt: &mut Formatter) -> Result { - // FIXME: this shouldn't perform an allocation - let s = match fmt.precision { - Some(i) => ::$ty::to_str_exact(self.abs(), i), - None => ::$ty::to_str_digits(self.abs(), 6) - }; - fmt.pad_integral(*self >= 0.0, "", s.as_bytes()) - } - } - - impl LowerExp for $ty { - fn fmt(&self, fmt: &mut Formatter) -> Result { - // FIXME: this shouldn't perform an allocation - let s = match fmt.precision { - Some(i) => ::$ty::to_str_exp_exact(self.abs(), i, false), - None => ::$ty::to_str_exp_digits(self.abs(), 6, false) - }; - fmt.pad_integral(*self >= 0.0, "", s.as_bytes()) - } - } - - impl UpperExp for $ty { - fn fmt(&self, fmt: &mut Formatter) -> Result { - // FIXME: this shouldn't perform an allocation - let s = match fmt.precision { - Some(i) => ::$ty::to_str_exp_exact(self.abs(), i, true), - None => ::$ty::to_str_exp_digits(self.abs(), 6, true) - }; - fmt.pad_integral(*self >= 0.0, "", s.as_bytes()) - } - } -}) -floating!(f32) -floating!(f64) - -impl<T> Poly for T { - fn fmt(&self, f: &mut Formatter) -> Result { - match (f.width, f.precision) { - (None, None) => { - repr::write_repr(f.buf, self) - } - - // If we have a specified width for formatting, then we have to make - // this allocation of a new string - _ => { - let s = repr::repr_to_str(self); - f.pad(s) - } - } - } -} - -impl<T> Pointer for *T { - fn fmt(&self, f: &mut Formatter) -> Result { - f.flags |= 1 << (rt::FlagAlternate as uint); - secret_lower_hex::<uint>(&(*self as uint), f) - } -} -impl<T> Pointer for *mut T { - fn fmt(&self, f: &mut Formatter) -> Result { - secret_pointer::<*T>(&(*self as *T), f) - } -} -impl<'a, T> Pointer for &'a T { - fn fmt(&self, f: &mut Formatter) -> Result { - secret_pointer::<*T>(&(&**self as *T), f) - } -} -impl<'a, T> Pointer for &'a mut T { - fn fmt(&self, f: &mut Formatter) -> Result { - secret_pointer::<*T>(&(&**self as *T), f) - } -} - -// Implementation of Show for various core types - -macro_rules! delegate(($ty:ty to $other:ident) => { - impl<'a> Show for $ty { - fn fmt(&self, f: &mut Formatter) -> Result { - (concat_idents!(secret_, $other)(self, f)) - } - } -}) -delegate!(~str to string) -delegate!(&'a str to string) -delegate!(bool to bool) -delegate!(char to char) -delegate!(f32 to float) -delegate!(f64 to float) - -impl<T> Show for *T { - fn fmt(&self, f: &mut Formatter) -> Result { secret_pointer(self, f) } -} -impl<T> Show for *mut T { - fn fmt(&self, f: &mut Formatter) -> Result { secret_pointer(self, f) } -} - -macro_rules! peel(($name:ident, $($other:ident,)*) => (tuple!($($other,)*))) - -macro_rules! tuple ( - () => (); - ( $($name:ident,)+ ) => ( - impl<$($name:Show),*> Show for ($($name,)*) { - #[allow(uppercase_variables, dead_assignment)] - fn fmt(&self, f: &mut Formatter) -> Result { - try!(write!(f.buf, "(")); - let ($(ref $name,)*) = *self; - let mut n = 0; - $( - if n > 0 { - try!(write!(f.buf, ", ")); - } - try!(write!(f.buf, "{}", *$name)); - n += 1; - )* - if n == 1 { - try!(write!(f.buf, ",")); - } - write!(f.buf, ")") - } - } - peel!($($name,)*) - ) -) - -tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } - -impl Show for Box<any::Any> { - fn fmt(&self, f: &mut Formatter) -> Result { f.pad("Box<Any>") } -} - -impl<'a> Show for &'a any::Any { - fn fmt(&self, f: &mut Formatter) -> Result { f.pad("&Any") } -} - -impl<T: Show> Show for Option<T> { - fn fmt(&self, f: &mut Formatter) -> Result { - match *self { - Some(ref t) => write!(f.buf, "Some({})", *t), - None => write!(f.buf, "None"), - } - } -} - -impl<T: Show, U: Show> Show for ::result::Result<T, U> { - fn fmt(&self, f: &mut Formatter) -> Result { - match *self { - Ok(ref t) => write!(f.buf, "Ok({})", *t), - Err(ref t) => write!(f.buf, "Err({})", *t), - } - } -} - -impl<'a, T: Show> Show for &'a [T] { - fn fmt(&self, f: &mut Formatter) -> Result { - if f.flags & (1 << (rt::FlagAlternate as uint)) == 0 { - try!(write!(f.buf, "[")); - } - let mut is_first = true; - for x in self.iter() { - if is_first { - is_first = false; - } else { - try!(write!(f.buf, ", ")); - } - try!(write!(f.buf, "{}", *x)) - } - if f.flags & (1 << (rt::FlagAlternate as uint)) == 0 { - try!(write!(f.buf, "]")); - } - Ok(()) - } -} - -impl<'a, T: Show> Show for &'a mut [T] { - fn fmt(&self, f: &mut Formatter) -> Result { - secret_show(&self.as_slice(), f) - } -} - -impl<T: Show> Show for ~[T] { - fn fmt(&self, f: &mut Formatter) -> Result { - secret_show(&self.as_slice(), f) - } -} - -impl Show for () { - fn fmt(&self, f: &mut Formatter) -> Result { - f.pad("()") - } -} - -impl Show for TypeId { - fn fmt(&self, f: &mut Formatter) -> Result { - write!(f.buf, "TypeId \\{ {} \\}", self.hash()) - } -} - -impl<T: Show> Show for iter::MinMaxResult<T> { - fn fmt(&self, f: &mut Formatter) -> Result { - match *self { - iter::NoElements => - write!(f.buf, "NoElements"), - iter::OneElement(ref t) => - write!(f.buf, "OneElement({})", *t), - iter::MinMax(ref t1, ref t2) => - write!(f.buf, "MinMax({}, {})", *t1, *t2), - } - } -} - -impl Show for cmp::Ordering { - fn fmt(&self, f: &mut Formatter) -> Result { - match *self { - cmp::Less => write!(f.buf, "Less"), - cmp::Greater => write!(f.buf, "Greater"), - cmp::Equal => write!(f.buf, "Equal"), - } - } -} - -impl<T: Copy + Show> Show for Cell<T> { - fn fmt(&self, f: &mut Formatter) -> Result { - write!(f.buf, r"Cell \{ value: {} \}", self.get()) - } -} - -impl Show for UTF16Item { - fn fmt(&self, f: &mut Formatter) -> Result { - match *self { - ScalarValue(c) => write!(f.buf, "ScalarValue({})", c), - LoneSurrogate(u) => write!(f.buf, "LoneSurrogate({})", u), - } - } -} - -// If you expected tests to be here, look instead at the run-pass/ifmt.rs test, -// it's a lot easier than creating all of the rt::Piece structures here. diff --git a/src/libstd/fmt/num.rs b/src/libstd/fmt/num.rs deleted file mode 100644 index 839b7407e55..00000000000 --- a/src/libstd/fmt/num.rs +++ /dev/null @@ -1,472 +0,0 @@ -// Copyright 2014 The Rust Project Developers. See the COPYRIGHT -// file at the top-level directory of this distribution and at -// http://rust-lang.org/COPYRIGHT. -// -// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or -// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license -// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your -// option. This file may not be copied, modified, or distributed -// except according to those terms. - -//! Integer and floating-point number formatting - -// FIXME: #6220 Implement floating point formatting - -#![allow(unsigned_negate)] - -use container::Container; -use fmt; -use iter::{Iterator, DoubleEndedIterator}; -use num::{Int, cast, zero}; -use option::{Some, None}; -use slice::{ImmutableVector, MutableVector}; - -/// A type that represents a specific radix -trait GenericRadix { - /// The number of digits. - fn base(&self) -> u8; - - /// A radix-specific prefix string. - fn prefix(&self) -> &'static str { "" } - - /// Converts an integer to corresponding radix digit. - fn digit(&self, x: u8) -> u8; - - /// Format an integer using the radix using a formatter. - fn fmt_int<T: Int>(&self, mut x: T, f: &mut fmt::Formatter) -> fmt::Result { - // The radix can be as low as 2, so we need a buffer of at least 64 - // characters for a base 2 number. - let mut buf = [0u8, ..64]; - let base = cast(self.base()).unwrap(); - let mut curr = buf.len(); - let is_positive = x >= zero(); - if is_positive { - // Accumulate each digit of the number from the least significant - // to the most significant figure. - for byte in buf.mut_iter().rev() { - let n = x % base; // Get the current place value. - x = x / base; // Deaccumulate the number. - *byte = self.digit(cast(n).unwrap()); // Store the digit in the buffer. - curr -= 1; - if x == zero() { break; } // No more digits left to accumulate. - } - } else { - // Do the same as above, but accounting for two's complement. - for byte in buf.mut_iter().rev() { - let n = -(x % base); // Get the current place value. - x = x / base; // Deaccumulate the number. - *byte = self.digit(cast(n).unwrap()); // Store the digit in the buffer. - curr -= 1; - if x == zero() { break; } // No more digits left to accumulate. - } - } - f.pad_integral(is_positive, self.prefix(), buf.slice_from(curr)) - } -} - -/// A binary (base 2) radix -#[deriving(Clone, Eq)] -struct Binary; - -/// An octal (base 8) radix -#[deriving(Clone, Eq)] -struct Octal; - -/// A decimal (base 10) radix -#[deriving(Clone, Eq)] -struct Decimal; - -/// A hexadecimal (base 16) radix, formatted with lower-case characters -#[deriving(Clone, Eq)] -struct LowerHex; - -/// A hexadecimal (base 16) radix, formatted with upper-case characters -#[deriving(Clone, Eq)] -pub struct UpperHex; - -macro_rules! radix { - ($T:ident, $base:expr, $prefix:expr, $($x:pat => $conv:expr),+) => { - impl GenericRadix for $T { - fn base(&self) -> u8 { $base } - fn prefix(&self) -> &'static str { $prefix } - fn digit(&self, x: u8) -> u8 { - match x { - $($x => $conv,)+ - x => fail!("number not in the range 0..{}: {}", self.base() - 1, x), - } - } - } - } -} - -radix!(Binary, 2, "0b", x @ 0 .. 2 => '0' as u8 + x) -radix!(Octal, 8, "0o", x @ 0 .. 7 => '0' as u8 + x) -radix!(Decimal, 10, "", x @ 0 .. 9 => '0' as u8 + x) -radix!(LowerHex, 16, "0x", x @ 0 .. 9 => '0' as u8 + x, - x @ 10 ..15 => 'a' as u8 + (x - 10)) -radix!(UpperHex, 16, "0x", x @ 0 .. 9 => '0' as u8 + x, - x @ 10 ..15 => 'A' as u8 + (x - 10)) - -/// A radix with in the range of `2..36`. -#[deriving(Clone, Eq)] -pub struct Radix { - base: u8, -} - -impl Radix { - fn new(base: u8) -> Radix { - assert!(2 <= base && base <= 36, "the base must be in the range of 0..36: {}", base); - Radix { base: base } - } -} - -impl GenericRadix for Radix { - fn base(&self) -> u8 { self.base } - fn digit(&self, x: u8) -> u8 { - match x { - x @ 0 ..9 => '0' as u8 + x, - x if x < self.base() => 'a' as u8 + (x - 10), - x => fail!("number not in the range 0..{}: {}", self.base() - 1, x), - } - } -} - -/// A helper type for formatting radixes. -pub struct RadixFmt<T, R>(T, R); - -/// Constructs a radix formatter in the range of `2..36`. -/// -/// # Example -/// -/// ~~~ -/// use std::fmt::radix; -/// assert_eq!(format!("{}", radix(55, 36)), "1j".to_owned()); -/// ~~~ -pub fn radix<T>(x: T, base: u8) -> RadixFmt<T, Radix> { - RadixFmt(x, Radix::new(base)) -} - -macro_rules! radix_fmt { - ($T:ty as $U:ty, $fmt:ident) => { - impl fmt::Show for RadixFmt<$T, Radix> { - fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - match *self { RadixFmt(ref x, radix) => radix.$fmt(*x as $U, f) } - } - } - } -} -macro_rules! int_base { - ($Trait:ident for $T:ident as $U:ident -> $Radix:ident) => { - impl fmt::$Trait for $T { - fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - $Radix.fmt_int(*self as $U, f) - } - } - } -} -macro_rules! integer { - ($Int:ident, $Uint:ident) => { - int_base!(Show for $Int as $Int -> Decimal) - int_base!(Signed for $Int as $Int -> Decimal) - int_base!(Binary for $Int as $Uint -> Binary) - int_base!(Octal for $Int as $Uint -> Octal) - int_base!(LowerHex for $Int as $Uint -> LowerHex) - int_base!(UpperHex for $Int as $Uint -> UpperHex) - radix_fmt!($Int as $Uint, fmt_int) - - int_base!(Show for $Uint as $Uint -> Decimal) - int_base!(Unsigned for $Uint as $Uint -> Decimal) - int_base!(Binary for $Uint as $Uint -> Binary) - int_base!(Octal for $Uint as $Uint -> Octal) - int_base!(LowerHex for $Uint as $Uint -> LowerHex) - int_base!(UpperHex for $Uint as $Uint -> UpperHex) - radix_fmt!($Uint as $Uint, fmt_int) - } -} -integer!(int, uint) -integer!(i8, u8) -integer!(i16, u16) -integer!(i32, u32) -integer!(i64, u64) - -#[cfg(test)] -mod tests { - use fmt::radix; - use super::{Binary, Octal, Decimal, LowerHex, UpperHex}; - use super::{GenericRadix, Radix}; - use str::StrAllocating; - - #[test] - fn test_radix_base() { - assert_eq!(Binary.base(), 2); - assert_eq!(Octal.base(), 8); - assert_eq!(Decimal.base(), 10); - assert_eq!(LowerHex.base(), 16); - assert_eq!(UpperHex.base(), 16); - assert_eq!(Radix { base: 36 }.base(), 36); - } - - #[test] - fn test_radix_prefix() { - assert_eq!(Binary.prefix(), "0b"); - assert_eq!(Octal.prefix(), "0o"); - assert_eq!(Decimal.prefix(), ""); - assert_eq!(LowerHex.prefix(), "0x"); - assert_eq!(UpperHex.prefix(), "0x"); - assert_eq!(Radix { base: 36 }.prefix(), ""); - } - - #[test] - fn test_radix_digit() { - assert_eq!(Binary.digit(0), '0' as u8); - assert_eq!(Binary.digit(2), '2' as u8); - assert_eq!(Octal.digit(0), '0' as u8); - assert_eq!(Octal.digit(7), '7' as u8); - assert_eq!(Decimal.digit(0), '0' as u8); - assert_eq!(Decimal.digit(9), '9' as u8); - assert_eq!(LowerHex.digit(0), '0' as u8); - assert_eq!(LowerHex.digit(10), 'a' as u8); - assert_eq!(LowerHex.digit(15), 'f' as u8); - assert_eq!(UpperHex.digit(0), '0' as u8); - assert_eq!(UpperHex.digit(10), 'A' as u8); - assert_eq!(UpperHex.digit(15), 'F' as u8); - assert_eq!(Radix { base: 36 }.digit(0), '0' as u8); - assert_eq!(Radix { base: 36 }.digit(15), 'f' as u8); - assert_eq!(Radix { base: 36 }.digit(35), 'z' as u8); - } - - #[test] - #[should_fail] - fn test_hex_radix_digit_overflow() { - let _ = LowerHex.digit(16); - } - - #[test] - fn test_format_int() { - // Formatting integers should select the right implementation based off - // the type of the argument. Also, hex/octal/binary should be defined - // for integers, but they shouldn't emit the negative sign. - assert_eq!(format!("{}", 1i), "1".to_owned()); - assert_eq!(format!("{}", 1i8), "1".to_owned()); - assert_eq!(format!("{}", 1i16), "1".to_owned()); - assert_eq!(format!("{}", 1i32), "1".to_owned()); - assert_eq!(format!("{}", 1i64), "1".to_owned()); - assert_eq!(format!("{:d}", -1i), "-1".to_owned()); - assert_eq!(format!("{:d}", -1i8), "-1".to_owned()); - assert_eq!(format!("{:d}", -1i16), "-1".to_owned()); - assert_eq!(format!("{:d}", -1i32), "-1".to_owned()); - assert_eq!(format!("{:d}", -1i64), "-1".to_owned()); - assert_eq!(format!("{:t}", 1i), "1".to_owned()); - assert_eq!(format!("{:t}", 1i8), "1".to_owned()); - assert_eq!(format!("{:t}", 1i16), "1".to_owned()); - assert_eq!(format!("{:t}", 1i32), "1".to_owned()); - assert_eq!(format!("{:t}", 1i64), "1".to_owned()); - assert_eq!(format!("{:x}", 1i), "1".to_owned()); - assert_eq!(format!("{:x}", 1i8), "1".to_owned()); - assert_eq!(format!("{:x}", 1i16), "1".to_owned()); - assert_eq!(format!("{:x}", 1i32), "1".to_owned()); - assert_eq!(format!("{:x}", 1i64), "1".to_owned()); - assert_eq!(format!("{:X}", 1i), "1".to_owned()); - assert_eq!(format!("{:X}", 1i8), "1".to_owned()); - assert_eq!(format!("{:X}", 1i16), "1".to_owned()); - assert_eq!(format!("{:X}", 1i32), "1".to_owned()); - assert_eq!(format!("{:X}", 1i64), "1".to_owned()); - assert_eq!(format!("{:o}", 1i), "1".to_owned()); - assert_eq!(format!("{:o}", 1i8), "1".to_owned()); - assert_eq!(format!("{:o}", 1i16), "1".to_owned()); - assert_eq!(format!("{:o}", 1i32), "1".to_owned()); - assert_eq!(format!("{:o}", 1i64), "1".to_owned()); - - assert_eq!(format!("{}", 1u), "1".to_owned()); - assert_eq!(format!("{}", 1u8), "1".to_owned()); - assert_eq!(format!("{}", 1u16), "1".to_owned()); - assert_eq!(format!("{}", 1u32), "1".to_owned()); - assert_eq!(format!("{}", 1u64), "1".to_owned()); - assert_eq!(format!("{:u}", 1u), "1".to_owned()); - assert_eq!(format!("{:u}", 1u8), "1".to_owned()); - assert_eq!(format!("{:u}", 1u16), "1".to_owned()); - assert_eq!(format!("{:u}", 1u32), "1".to_owned()); - assert_eq!(format!("{:u}", 1u64), "1".to_owned()); - assert_eq!(format!("{:t}", 1u), "1".to_owned()); - assert_eq!(format!("{:t}", 1u8), "1".to_owned()); - assert_eq!(format!("{:t}", 1u16), "1".to_owned()); - assert_eq!(format!("{:t}", 1u32), "1".to_owned()); - assert_eq!(format!("{:t}", 1u64), "1".to_owned()); - assert_eq!(format!("{:x}", 1u), "1".to_owned()); - assert_eq!(format!("{:x}", 1u8), "1".to_owned()); - assert_eq!(format!("{:x}", 1u16), "1".to_owned()); - assert_eq!(format!("{:x}", 1u32), "1".to_owned()); - assert_eq!(format!("{:x}", 1u64), "1".to_owned()); - assert_eq!(format!("{:X}", 1u), "1".to_owned()); - assert_eq!(format!("{:X}", 1u8), "1".to_owned()); - assert_eq!(format!("{:X}", 1u16), "1".to_owned()); - assert_eq!(format!("{:X}", 1u32), "1".to_owned()); - assert_eq!(format!("{:X}", 1u64), "1".to_owned()); - assert_eq!(format!("{:o}", 1u), "1".to_owned()); - assert_eq!(format!("{:o}", 1u8), "1".to_owned()); - assert_eq!(format!("{:o}", 1u16), "1".to_owned()); - assert_eq!(format!("{:o}", 1u32), "1".to_owned()); - assert_eq!(format!("{:o}", 1u64), "1".to_owned()); - - // Test a larger number - assert_eq!(format!("{:t}", 55), "110111".to_owned()); - assert_eq!(format!("{:o}", 55), "67".to_owned()); - assert_eq!(format!("{:d}", 55), "55".to_owned()); - assert_eq!(format!("{:x}", 55), "37".to_owned()); - assert_eq!(format!("{:X}", 55), "37".to_owned()); - } - - #[test] - fn test_format_int_zero() { - assert_eq!(format!("{}", 0i), "0".to_owned()); - assert_eq!(format!("{:d}", 0i), "0".to_owned()); - assert_eq!(format!("{:t}", 0i), "0".to_owned()); - assert_eq!(format!("{:o}", 0i), "0".to_owned()); - assert_eq!(format!("{:x}", 0i), "0".to_owned()); - assert_eq!(format!("{:X}", 0i), "0".to_owned()); - - assert_eq!(format!("{}", 0u), "0".to_owned()); - assert_eq!(format!("{:u}", 0u), "0".to_owned()); - assert_eq!(format!("{:t}", 0u), "0".to_owned()); - assert_eq!(format!("{:o}", 0u), "0".to_owned()); - assert_eq!(format!("{:x}", 0u), "0".to_owned()); - assert_eq!(format!("{:X}", 0u), "0".to_owned()); - } - - #[test] - fn test_format_int_flags() { - assert_eq!(format!("{:3d}", 1), " 1".to_owned()); - assert_eq!(format!("{:>3d}", 1), " 1".to_owned()); - assert_eq!(format!("{:>+3d}", 1), " +1".to_owned()); - assert_eq!(format!("{:<3d}", 1), "1 ".to_owned()); - assert_eq!(format!("{:#d}", 1), "1".to_owned()); - assert_eq!(format!("{:#x}", 10), "0xa".to_owned()); - assert_eq!(format!("{:#X}", 10), "0xA".to_owned()); - assert_eq!(format!("{:#5x}", 10), " 0xa".to_owned()); - assert_eq!(format!("{:#o}", 10), "0o12".to_owned()); - assert_eq!(format!("{:08x}", 10), "0000000a".to_owned()); - assert_eq!(format!("{:8x}", 10), " a".to_owned()); - assert_eq!(format!("{:<8x}", 10), "a ".to_owned()); - assert_eq!(format!("{:>8x}", 10), " a".to_owned()); - assert_eq!(format!("{:#08x}", 10), "0x00000a".to_owned()); - assert_eq!(format!("{:08d}", -10), "-0000010".to_owned()); - assert_eq!(format!("{:x}", -1u8), "ff".to_owned()); - assert_eq!(format!("{:X}", -1u8), "FF".to_owned()); - assert_eq!(format!("{:t}", -1u8), "11111111".to_owned()); - assert_eq!(format!("{:o}", -1u8), "377".to_owned()); - assert_eq!(format!("{:#x}", -1u8), "0xff".to_owned()); - assert_eq!(format!("{:#X}", -1u8), "0xFF".to_owned()); - assert_eq!(format!("{:#t}", -1u8), "0b11111111".to_owned()); - assert_eq!(format!("{:#o}", -1u8), "0o377".to_owned()); - } - - #[test] - fn test_format_int_sign_padding() { - assert_eq!(format!("{:+5d}", 1), " +1".to_owned()); - assert_eq!(format!("{:+5d}", -1), " -1".to_owned()); - assert_eq!(format!("{:05d}", 1), "00001".to_owned()); - assert_eq!(format!("{:05d}", -1), "-0001".to_owned()); - assert_eq!(format!("{:+05d}", 1), "+0001".to_owned()); - assert_eq!(format!("{:+05d}", -1), "-0001".to_owned()); - } - - #[test] - fn test_format_int_twos_complement() { - use {i8, i16, i32, i64}; - assert_eq!(format!("{}", i8::MIN), "-128".to_owned()); - assert_eq!(format!("{}", i16::MIN), "-32768".to_owned()); - assert_eq!(format!("{}", i32::MIN), "-2147483648".to_owned()); - assert_eq!(format!("{}", i64::MIN), "-9223372036854775808".to_owned()); - } - - #[test] - fn test_format_radix() { - assert_eq!(format!("{:04}", radix(3, 2)), "0011".to_owned()); - assert_eq!(format!("{}", radix(55, 36)), "1j".to_owned()); - } - - #[test] - #[should_fail] - fn test_radix_base_too_large() { - let _ = radix(55, 37); - } -} - -#[cfg(test)] -mod bench { - extern crate test; - - mod uint { - use super::test::Bencher; - use fmt::radix; - use rand::{XorShiftRng, Rng}; - use realstd::result::ResultUnwrap; - - #[bench] - fn format_bin(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{:t}", rng.gen::<uint>()); }) - } - - #[bench] - fn format_oct(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{:o}", rng.gen::<uint>()); }) - } - - #[bench] - fn format_dec(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{:u}", rng.gen::<uint>()); }) - } - - #[bench] - fn format_hex(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{:x}", rng.gen::<uint>()); }) - } - - #[bench] - fn format_base_36(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{}", radix(rng.gen::<uint>(), 36)); }) - } - } - - mod int { - use super::test::Bencher; - use fmt::radix; - use rand::{XorShiftRng, Rng}; - use realstd::result::ResultUnwrap; - - #[bench] - fn format_bin(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{:t}", rng.gen::<int>()); }) - } - - #[bench] - fn format_oct(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{:o}", rng.gen::<int>()); }) - } - - #[bench] - fn format_dec(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{:d}", rng.gen::<int>()); }) - } - - #[bench] - fn format_hex(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{:x}", rng.gen::<int>()); }) - } - - #[bench] - fn format_base_36(b: &mut Bencher) { - let mut rng = XorShiftRng::new().unwrap(); - b.iter(|| { format!("{}", radix(rng.gen::<int>(), 36)); }) - } - } -} diff --git a/src/libstd/fmt/rt.rs b/src/libstd/fmt/rt.rs deleted file mode 100644 index 00c8661c8e3..00000000000 --- a/src/libstd/fmt/rt.rs +++ /dev/null @@ -1,91 +0,0 @@ -// Copyright 2013 The Rust Project Developers. See the COPYRIGHT -// file at the top-level directory of this distribution and at -// http://rust-lang.org/COPYRIGHT. -// -// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or -// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license -// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your -// option. This file may not be copied, modified, or distributed -// except according to those terms. - -//! This is an internal module used by the ifmt! runtime. These structures are -//! emitted to static arrays to precompile format strings ahead of time. -//! -//! These definitions are similar to their `ct` equivalents, but differ in that -//! these can be statically allocated and are slightly optimized for the runtime - -#![allow(missing_doc)] -#![doc(hidden)] - -use option::Option; - -pub enum Piece<'a> { - String(&'a str), - // FIXME(#8259): this shouldn't require the unit-value here - CurrentArgument(()), - Argument(Argument<'a>), -} - -pub struct Argument<'a> { - pub position: Position, - pub format: FormatSpec, - pub method: Option<&'a Method<'a>> -} - -pub struct FormatSpec { - pub fill: char, - pub align: Alignment, - pub flags: uint, - pub precision: Count, - pub width: Count, -} - -#[deriving(Eq)] -pub enum Alignment { - AlignLeft, - AlignRight, - AlignUnknown, -} - -pub enum Count { - CountIs(uint), CountIsParam(uint), CountIsNextParam, CountImplied, -} - -pub enum Position { - ArgumentNext, ArgumentIs(uint) -} - -pub enum Flag { - FlagSignPlus, - FlagSignMinus, - FlagAlternate, - FlagSignAwareZeroPad, -} - -pub enum Method<'a> { - Plural(Option<uint>, &'a [PluralArm<'a>], &'a [Piece<'a>]), - Select(&'a [SelectArm<'a>], &'a [Piece<'a>]), -} - -pub enum PluralSelector { - Keyword(PluralKeyword), - Literal(uint), -} - -pub enum PluralKeyword { - Zero, - One, - Two, - Few, - Many, -} - -pub struct PluralArm<'a> { - pub selector: PluralSelector, - pub result: &'a [Piece<'a>], -} - -pub struct SelectArm<'a> { - pub selector: &'a str, - pub result: &'a [Piece<'a>], -} diff --git a/src/libstd/io/buffered.rs b/src/libstd/io/buffered.rs index 68cbdd2e0aa..2880365cf34 100644 --- a/src/libstd/io/buffered.rs +++ b/src/libstd/io/buffered.rs @@ -16,7 +16,7 @@ use io::{Reader, Writer, Stream, Buffer, DEFAULT_BUF_SIZE, IoResult}; use iter::ExactSize; use ops::Drop; use option::{Some, None, Option}; -use result::{Ok, Err, ResultUnwrap}; +use result::{Ok, Err}; use slice::{ImmutableVector, MutableVector}; use slice; use vec::Vec; diff --git a/src/libstd/io/mod.rs b/src/libstd/io/mod.rs index 5c9d5feab10..a043722581b 100644 --- a/src/libstd/io/mod.rs +++ b/src/libstd/io/mod.rs @@ -381,9 +381,9 @@ impl IoError { impl fmt::Show for IoError { fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result { - try!(fmt.buf.write_str(self.desc)); + try!(write!(fmt, "{}", self.desc)); match self.detail { - Some(ref s) => write!(fmt.buf, " ({})", *s), + Some(ref s) => write!(fmt, " ({})", *s), None => Ok(()) } } @@ -964,6 +964,42 @@ pub trait Writer { /// decide whether their stream needs to be buffered or not. fn flush(&mut self) -> IoResult<()> { Ok(()) } + /// Writes a formatted string into this writer, returning any error + /// encountered. + /// + /// This method is primarily used to interface with the `format_args!` + /// macro, but it is rare that this should explicitly be called. The + /// `write!` macro should be favored to invoke this method instead. + /// + /// # Errors + /// + /// This function will return any I/O error reported while formatting. + fn write_fmt(&mut self, fmt: &fmt::Arguments) -> IoResult<()> { + // Create a shim which translates a Writer to a FormatWriter and saves + // off I/O errors. instead of discarding them + struct Adaptor<'a, T> { + inner: &'a mut T, + error: IoResult<()>, + } + impl<'a, T: Writer> fmt::FormatWriter for Adaptor<'a, T> { + fn write(&mut self, bytes: &[u8]) -> fmt::Result { + match self.inner.write(bytes) { + Ok(()) => Ok(()), + Err(e) => { + self.error = Err(e); + Err(fmt::WriteError) + } + } + } + } + + let mut output = Adaptor { inner: self, error: Ok(()) }; + match fmt::write(&mut output, fmt) { + Ok(()) => Ok(()), + Err(..) => output.error + } + } + /// Write a rust string into this sink. /// /// The bytes written will be the UTF-8 encoded version of the input string. diff --git a/src/libstd/io/net/ip.rs b/src/libstd/io/net/ip.rs index 7621a7ec4cd..f469c419e8e 100644 --- a/src/libstd/io/net/ip.rs +++ b/src/libstd/io/net/ip.rs @@ -35,22 +35,22 @@ impl fmt::Show for IpAddr { fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result { match *self { Ipv4Addr(a, b, c, d) => - write!(fmt.buf, "{}.{}.{}.{}", a, b, c, d), + write!(fmt, "{}.{}.{}.{}", a, b, c, d), // Ipv4 Compatible address Ipv6Addr(0, 0, 0, 0, 0, 0, g, h) => { - write!(fmt.buf, "::{}.{}.{}.{}", (g >> 8) as u8, g as u8, + write!(fmt, "::{}.{}.{}.{}", (g >> 8) as u8, g as u8, (h >> 8) as u8, h as u8) } // Ipv4-Mapped address Ipv6Addr(0, 0, 0, 0, 0, 0xFFFF, g, h) => { - write!(fmt.buf, "::FFFF:{}.{}.{}.{}", (g >> 8) as u8, g as u8, + write!(fmt, "::FFFF:{}.{}.{}.{}", (g >> 8) as u8, g as u8, (h >> 8) as u8, h as u8) } Ipv6Addr(a, b, c, d, e, f, g, h) => - write!(fmt.buf, "{:x}:{:x}:{:x}:{:x}:{:x}:{:x}:{:x}:{:x}", + write!(fmt, "{:x}:{:x}:{:x}:{:x}:{:x}:{:x}:{:x}:{:x}", a, b, c, d, e, f, g, h) } } @@ -65,8 +65,8 @@ pub struct SocketAddr { impl fmt::Show for SocketAddr { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { match self.ip { - Ipv4Addr(..) => write!(f.buf, "{}:{}", self.ip, self.port), - Ipv6Addr(..) => write!(f.buf, "[{}]:{}", self.ip, self.port), + Ipv4Addr(..) => write!(f, "{}:{}", self.ip, self.port), + Ipv6Addr(..) => write!(f, "[{}]:{}", self.ip, self.port), } } } diff --git a/src/libstd/io/net/udp.rs b/src/libstd/io/net/udp.rs index 864a7010541..875dd01be82 100644 --- a/src/libstd/io/net/udp.rs +++ b/src/libstd/io/net/udp.rs @@ -384,8 +384,6 @@ mod test { }) pub fn socket_name(addr: SocketAddr) { - use result::ResultUnwrap; - let server = UdpSocket::bind(addr); assert!(server.is_ok()); diff --git a/src/libstd/io/process.rs b/src/libstd/io/process.rs index fe51615285a..fc760e6fe4c 100644 --- a/src/libstd/io/process.rs +++ b/src/libstd/io/process.rs @@ -308,9 +308,9 @@ impl fmt::Show for Command { /// non-utf8 data is lossily converted using the utf8 replacement /// character. fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - try!(write!(f.buf, "{}", str::from_utf8_lossy(self.program.as_bytes_no_nul()))); + try!(write!(f, "{}", str::from_utf8_lossy(self.program.as_bytes_no_nul()))); for arg in self.args.iter() { - try!(write!(f.buf, " '{}'", str::from_utf8_lossy(arg.as_bytes_no_nul()))); + try!(write!(f, " '{}'", str::from_utf8_lossy(arg.as_bytes_no_nul()))); } Ok(()) } @@ -361,8 +361,8 @@ impl fmt::Show for ProcessExit { /// Format a ProcessExit enum, to nicely present the information. fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { match *self { - ExitStatus(code) => write!(f.buf, "exit code: {}", code), - ExitSignal(code) => write!(f.buf, "signal: {}", code), + ExitStatus(code) => write!(f, "exit code: {}", code), + ExitSignal(code) => write!(f, "signal: {}", code), } } } diff --git a/src/libstd/io/stdio.rs b/src/libstd/io/stdio.rs index 69ba0fb20ee..e6d416164d0 100644 --- a/src/libstd/io/stdio.rs +++ b/src/libstd/io/stdio.rs @@ -36,7 +36,7 @@ use mem::replace; use option::{Option, Some, None}; use owned::Box; use prelude::drop; -use result::{Ok, Err, ResultUnwrap}; +use result::{Ok, Err}; use rt; use rt::local::Local; use rt::rtio::{DontClose, IoFactory, LocalIo, RtioFileStream, RtioTTY}; @@ -276,13 +276,13 @@ pub fn println(s: &str) { /// Similar to `print`, but takes a `fmt::Arguments` structure to be compatible /// with the `format_args!` macro. pub fn print_args(fmt: &fmt::Arguments) { - with_task_stdout(|io| fmt::write(io, fmt)) + with_task_stdout(|io| write!(io, "{}", fmt)) } /// Similar to `println`, but takes a `fmt::Arguments` structure to be /// compatible with the `format_args!` macro. pub fn println_args(fmt: &fmt::Arguments) { - with_task_stdout(|io| fmt::writeln(io, fmt)) + with_task_stdout(|io| writeln!(io, "{}", fmt)) } /// Representation of a reader of a standard input stream diff --git a/src/libstd/lib.rs b/src/libstd/lib.rs index 87c4ef1046f..119cd9aa2ca 100644 --- a/src/libstd/lib.rs +++ b/src/libstd/lib.rs @@ -153,6 +153,7 @@ pub use core::mem; pub use core::ptr; pub use core::raw; pub use core::tuple; +pub use core::result; // Run tests with libgreen instead of libnative. // @@ -218,7 +219,6 @@ pub mod hash; /* Common data structures */ -pub mod result; pub mod option; /* Tasks and communication */ diff --git a/src/libstd/macros.rs b/src/libstd/macros.rs index 3a0e78b39d1..b260f685a34 100644 --- a/src/libstd/macros.rs +++ b/src/libstd/macros.rs @@ -251,10 +251,17 @@ macro_rules! format_strbuf( /// write!(&mut w, "formatted {}", "arguments"); /// ``` #[macro_export] +#[cfg(not(stage0))] macro_rules! write( ($dst:expr, $($arg:tt)*) => ({ - let dst: &mut ::std::io::Writer = $dst; - format_args!(|args| { ::std::fmt::write(dst, args) }, $($arg)*) + format_args_method!($dst, write_fmt, $($arg)*) + }) +) +#[cfg(stage0)] +#[macro_export] +macro_rules! write( + ($dst:expr, $($arg:tt)*) => ({ + format_args!(|args| { $dst.write_fmt(args) }, $($arg)*) }) ) @@ -262,10 +269,9 @@ macro_rules! write( /// the message is written. #[macro_export] macro_rules! writeln( - ($dst:expr, $($arg:tt)*) => ({ - let dst: &mut ::std::io::Writer = $dst; - format_args!(|args| { ::std::fmt::writeln(dst, args) }, $($arg)*) - }) + ($dst:expr, $fmt:expr $($arg:tt)*) => ( + write!($dst, concat!($fmt, "\n") $($arg)*) + ) ) /// Equivalent to the `println!` macro except that a newline is not printed at diff --git a/src/libstd/num/f32.rs b/src/libstd/num/f32.rs index 29c206b32fc..e9ea0df2a7b 100644 --- a/src/libstd/num/f32.rs +++ b/src/libstd/num/f32.rs @@ -18,9 +18,7 @@ use prelude::*; use from_str::FromStr; use intrinsics; use libc::c_int; -use mem; use num::strconv; -use num::{FPCategory, FPNaN, FPInfinite , FPZero, FPSubnormal, FPNormal}; use num; pub use core::f32::{RADIX, MANTISSA_DIGITS, DIGITS, EPSILON, MIN_VALUE}; @@ -69,82 +67,7 @@ mod cmath { } } -impl Float for f32 { - #[inline] - fn nan() -> f32 { NAN } - - #[inline] - fn infinity() -> f32 { INFINITY } - - #[inline] - fn neg_infinity() -> f32 { NEG_INFINITY } - - #[inline] - fn neg_zero() -> f32 { -0.0 } - - /// Returns `true` if the number is NaN - #[inline] - fn is_nan(self) -> bool { self != self } - - /// Returns `true` if the number is infinite - #[inline] - fn is_infinite(self) -> bool { - self == Float::infinity() || self == Float::neg_infinity() - } - - /// Returns `true` if the number is neither infinite or NaN - #[inline] - fn is_finite(self) -> bool { - !(self.is_nan() || self.is_infinite()) - } - - /// Returns `true` if the number is neither zero, infinite, subnormal or NaN - #[inline] - fn is_normal(self) -> bool { - self.classify() == FPNormal - } - - /// Returns the floating point category of the number. If only one property - /// is going to be tested, it is generally faster to use the specific - /// predicate instead. - fn classify(self) -> FPCategory { - static EXP_MASK: u32 = 0x7f800000; - static MAN_MASK: u32 = 0x007fffff; - - let bits: u32 = unsafe { mem::transmute(self) }; - match (bits & MAN_MASK, bits & EXP_MASK) { - (0, 0) => FPZero, - (_, 0) => FPSubnormal, - (0, EXP_MASK) => FPInfinite, - (_, EXP_MASK) => FPNaN, - _ => FPNormal, - } - } - - #[inline] - fn mantissa_digits(_: Option<f32>) -> uint { MANTISSA_DIGITS } - - #[inline] - fn digits(_: Option<f32>) -> uint { DIGITS } - - #[inline] - fn epsilon() -> f32 { EPSILON } - - #[inline] - fn min_exp(_: Option<f32>) -> int { MIN_EXP } - - #[inline] - fn max_exp(_: Option<f32>) -> int { MAX_EXP } - - #[inline] - fn min_10_exp(_: Option<f32>) -> int { MIN_10_EXP } - - #[inline] - fn max_10_exp(_: Option<f32>) -> int { MAX_10_EXP } - - #[inline] - fn min_pos_value(_: Option<f32>) -> f32 { MIN_POS_VALUE } - +impl FloatMath for f32 { /// Constructs a floating point number by multiplying `x` by 2 raised to the /// power of `exp` #[inline] @@ -166,21 +89,6 @@ impl Float for f32 { } } - /// Returns the mantissa, exponent and sign as integers. - fn integer_decode(self) -> (u64, i16, i8) { - let bits: u32 = unsafe { mem::transmute(self) }; - let sign: i8 = if bits >> 31 == 0 { 1 } else { -1 }; - let mut exponent: i16 = ((bits >> 23) & 0xff) as i16; - let mantissa = if exponent == 0 { - (bits & 0x7fffff) << 1 - } else { - (bits & 0x7fffff) | 0x800000 - }; - // Exponent bias + mantissa shift - exponent -= 127 + 23; - (mantissa as u64, exponent, sign) - } - /// Returns the next representable floating-point value in the direction of /// `other`. #[inline] @@ -188,39 +96,6 @@ impl Float for f32 { unsafe { cmath::nextafterf(self, other) } } - /// Round half-way cases toward `NEG_INFINITY` - #[inline] - fn floor(self) -> f32 { - unsafe { intrinsics::floorf32(self) } - } - - /// Round half-way cases toward `INFINITY` - #[inline] - fn ceil(self) -> f32 { - unsafe { intrinsics::ceilf32(self) } - } - - /// Round half-way cases away from `0.0` - #[inline] - fn round(self) -> f32 { - unsafe { intrinsics::roundf32(self) } - } - - /// The integer part of the number (rounds towards `0.0`) - #[inline] - fn trunc(self) -> f32 { - unsafe { intrinsics::truncf32(self) } - } - - /// The fractional part of the number, satisfying: - /// - /// ```rust - /// let x = 1.65f32; - /// assert!(x == x.trunc() + x.fract()) - /// ``` - #[inline] - fn fract(self) -> f32 { self - self.trunc() } - #[inline] fn max(self, other: f32) -> f32 { unsafe { cmath::fmaxf(self, other) } @@ -231,43 +106,6 @@ impl Float for f32 { unsafe { cmath::fminf(self, other) } } - /// Fused multiply-add. Computes `(self * a) + b` with only one rounding - /// error. This produces a more accurate result with better performance than - /// a separate multiplication operation followed by an add. - #[inline] - fn mul_add(self, a: f32, b: f32) -> f32 { - unsafe { intrinsics::fmaf32(self, a, b) } - } - - /// The reciprocal (multiplicative inverse) of the number - #[inline] - fn recip(self) -> f32 { 1.0 / self } - - fn powi(self, n: i32) -> f32 { - unsafe { intrinsics::powif32(self, n) } - } - - #[inline] - fn powf(self, n: f32) -> f32 { - unsafe { intrinsics::powf32(self, n) } - } - - /// sqrt(2.0) - #[inline] - fn sqrt2() -> f32 { consts::SQRT2 } - - /// 1.0 / sqrt(2.0) - #[inline] - fn frac_1_sqrt2() -> f32 { consts::FRAC_1_SQRT2 } - - #[inline] - fn sqrt(self) -> f32 { - unsafe { intrinsics::sqrtf32(self) } - } - - #[inline] - fn rsqrt(self) -> f32 { self.sqrt().recip() } - #[inline] fn cbrt(self) -> f32 { unsafe { cmath::cbrtf(self) } @@ -278,46 +116,6 @@ impl Float for f32 { unsafe { cmath::hypotf(self, other) } } - /// Archimedes' constant - #[inline] - fn pi() -> f32 { consts::PI } - - /// 2.0 * pi - #[inline] - fn two_pi() -> f32 { consts::PI_2 } - - /// pi / 2.0 - #[inline] - fn frac_pi_2() -> f32 { consts::FRAC_PI_2 } - - /// pi / 3.0 - #[inline] - fn frac_pi_3() -> f32 { consts::FRAC_PI_3 } - - /// pi / 4.0 - #[inline] - fn frac_pi_4() -> f32 { consts::FRAC_PI_4 } - - /// pi / 6.0 - #[inline] - fn frac_pi_6() -> f32 { consts::FRAC_PI_6 } - - /// pi / 8.0 - #[inline] - fn frac_pi_8() -> f32 { consts::FRAC_PI_8 } - - /// 1 .0/ pi - #[inline] - fn frac_1_pi() -> f32 { consts::FRAC_1_PI } - - /// 2.0 / pi - #[inline] - fn frac_2_pi() -> f32 { consts::FRAC_2_PI } - - /// 2.0 / sqrt(pi) - #[inline] - fn frac_2_sqrtpi() -> f32 { consts::FRAC_2_SQRTPI } - #[inline] fn sin(self) -> f32 { unsafe { intrinsics::sinf32(self) } @@ -359,38 +157,6 @@ impl Float for f32 { (self.sin(), self.cos()) } - /// Euler's number - #[inline] - fn e() -> f32 { consts::E } - - /// log2(e) - #[inline] - fn log2_e() -> f32 { consts::LOG2_E } - - /// log10(e) - #[inline] - fn log10_e() -> f32 { consts::LOG10_E } - - /// ln(2.0) - #[inline] - fn ln_2() -> f32 { consts::LN_2 } - - /// ln(10.0) - #[inline] - fn ln_10() -> f32 { consts::LN_10 } - - /// Returns the exponential of the number - #[inline] - fn exp(self) -> f32 { - unsafe { intrinsics::expf32(self) } - } - - /// Returns 2 raised to the power of the number - #[inline] - fn exp2(self) -> f32 { - unsafe { intrinsics::exp2f32(self) } - } - /// Returns the exponential of the number, minus `1`, in a way that is /// accurate even if the number is close to zero #[inline] @@ -398,28 +164,6 @@ impl Float for f32 { unsafe { cmath::expm1f(self) } } - /// Returns the natural logarithm of the number - #[inline] - fn ln(self) -> f32 { - unsafe { intrinsics::logf32(self) } - } - - /// Returns the logarithm of the number with respect to an arbitrary base - #[inline] - fn log(self, base: f32) -> f32 { self.ln() / base.ln() } - - /// Returns the base 2 logarithm of the number - #[inline] - fn log2(self) -> f32 { - unsafe { intrinsics::log2f32(self) } - } - - /// Returns the base 10 logarithm of the number - #[inline] - fn log10(self) -> f32 { - unsafe { intrinsics::log10f32(self) } - } - /// Returns the natural logarithm of the number plus `1` (`ln(1+n)`) more /// accurately than if the operations were performed separately #[inline] @@ -486,17 +230,6 @@ impl Float for f32 { fn atanh(self) -> f32 { 0.5 * ((2.0 * self) / (1.0 - self)).ln_1p() } - - /// Converts to degrees, assuming the number is in radians - #[inline] - fn to_degrees(self) -> f32 { self * (180.0f32 / Float::pi()) } - - /// Converts to radians, assuming the number is in degrees - #[inline] - fn to_radians(self) -> f32 { - let value: f32 = Float::pi(); - self * (value / 180.0f32) - } } // @@ -1000,18 +733,18 @@ mod tests { // are supported in floating-point literals let f1: f32 = from_str_hex("1p-123").unwrap(); let f2: f32 = from_str_hex("1p-111").unwrap(); - assert_eq!(Float::ldexp(1f32, -123), f1); - assert_eq!(Float::ldexp(1f32, -111), f2); + assert_eq!(FloatMath::ldexp(1f32, -123), f1); + assert_eq!(FloatMath::ldexp(1f32, -111), f2); - assert_eq!(Float::ldexp(0f32, -123), 0f32); - assert_eq!(Float::ldexp(-0f32, -123), -0f32); + assert_eq!(FloatMath::ldexp(0f32, -123), 0f32); + assert_eq!(FloatMath::ldexp(-0f32, -123), -0f32); let inf: f32 = Float::infinity(); let neg_inf: f32 = Float::neg_infinity(); let nan: f32 = Float::nan(); - assert_eq!(Float::ldexp(inf, -123), inf); - assert_eq!(Float::ldexp(neg_inf, -123), neg_inf); - assert!(Float::ldexp(nan, -123).is_nan()); + assert_eq!(FloatMath::ldexp(inf, -123), inf); + assert_eq!(FloatMath::ldexp(neg_inf, -123), neg_inf); + assert!(FloatMath::ldexp(nan, -123).is_nan()); } #[test] @@ -1024,8 +757,8 @@ mod tests { let (x2, exp2) = f2.frexp(); assert_eq!((x1, exp1), (0.5f32, -122)); assert_eq!((x2, exp2), (0.5f32, -110)); - assert_eq!(Float::ldexp(x1, exp1), f1); - assert_eq!(Float::ldexp(x2, exp2), f2); + assert_eq!(FloatMath::ldexp(x1, exp1), f1); + assert_eq!(FloatMath::ldexp(x2, exp2), f2); assert_eq!(0f32.frexp(), (0f32, 0)); assert_eq!((-0f32).frexp(), (-0f32, 0)); diff --git a/src/libstd/num/f64.rs b/src/libstd/num/f64.rs index c18ea5caba6..869a275b1d4 100644 --- a/src/libstd/num/f64.rs +++ b/src/libstd/num/f64.rs @@ -16,10 +16,8 @@ use prelude::*; use from_str::FromStr; use intrinsics; -use libc::{c_int}; -use mem; -use num::{FPCategory, FPNaN, FPInfinite , FPZero, FPSubnormal, FPNormal}; -use num::{strconv}; +use libc::c_int; +use num::strconv; use num; pub use core::f64::{RADIX, MANTISSA_DIGITS, DIGITS, EPSILON, MIN_VALUE}; @@ -77,82 +75,7 @@ mod cmath { } } -impl Float for f64 { - #[inline] - fn nan() -> f64 { NAN } - - #[inline] - fn infinity() -> f64 { INFINITY } - - #[inline] - fn neg_infinity() -> f64 { NEG_INFINITY } - - #[inline] - fn neg_zero() -> f64 { -0.0 } - - /// Returns `true` if the number is NaN - #[inline] - fn is_nan(self) -> bool { self != self } - - /// Returns `true` if the number is infinite - #[inline] - fn is_infinite(self) -> bool { - self == Float::infinity() || self == Float::neg_infinity() - } - - /// Returns `true` if the number is neither infinite or NaN - #[inline] - fn is_finite(self) -> bool { - !(self.is_nan() || self.is_infinite()) - } - - /// Returns `true` if the number is neither zero, infinite, subnormal or NaN - #[inline] - fn is_normal(self) -> bool { - self.classify() == FPNormal - } - - /// Returns the floating point category of the number. If only one property - /// is going to be tested, it is generally faster to use the specific - /// predicate instead. - fn classify(self) -> FPCategory { - static EXP_MASK: u64 = 0x7ff0000000000000; - static MAN_MASK: u64 = 0x000fffffffffffff; - - let bits: u64 = unsafe { mem::transmute(self) }; - match (bits & MAN_MASK, bits & EXP_MASK) { - (0, 0) => FPZero, - (_, 0) => FPSubnormal, - (0, EXP_MASK) => FPInfinite, - (_, EXP_MASK) => FPNaN, - _ => FPNormal, - } - } - - #[inline] - fn mantissa_digits(_: Option<f64>) -> uint { MANTISSA_DIGITS } - - #[inline] - fn digits(_: Option<f64>) -> uint { DIGITS } - - #[inline] - fn epsilon() -> f64 { EPSILON } - - #[inline] - fn min_exp(_: Option<f64>) -> int { MIN_EXP } - - #[inline] - fn max_exp(_: Option<f64>) -> int { MAX_EXP } - - #[inline] - fn min_10_exp(_: Option<f64>) -> int { MIN_10_EXP } - - #[inline] - fn max_10_exp(_: Option<f64>) -> int { MAX_10_EXP } - - #[inline] - fn min_pos_value(_: Option<f64>) -> f64 { MIN_POS_VALUE } - +impl FloatMath for f64 { /// Constructs a floating point number by multiplying `x` by 2 raised to the /// power of `exp` #[inline] @@ -174,21 +97,6 @@ impl Float for f64 { } } - /// Returns the mantissa, exponent and sign as integers. - fn integer_decode(self) -> (u64, i16, i8) { - let bits: u64 = unsafe { mem::transmute(self) }; - let sign: i8 = if bits >> 63 == 0 { 1 } else { -1 }; - let mut exponent: i16 = ((bits >> 52) & 0x7ff) as i16; - let mantissa = if exponent == 0 { - (bits & 0xfffffffffffff) << 1 - } else { - (bits & 0xfffffffffffff) | 0x10000000000000 - }; - // Exponent bias + mantissa shift - exponent -= 1023 + 52; - (mantissa, exponent, sign) - } - /// Returns the next representable floating-point value in the direction of /// `other`. #[inline] @@ -196,39 +104,6 @@ impl Float for f64 { unsafe { cmath::nextafter(self, other) } } - /// Round half-way cases toward `NEG_INFINITY` - #[inline] - fn floor(self) -> f64 { - unsafe { intrinsics::floorf64(self) } - } - - /// Round half-way cases toward `INFINITY` - #[inline] - fn ceil(self) -> f64 { - unsafe { intrinsics::ceilf64(self) } - } - - /// Round half-way cases away from `0.0` - #[inline] - fn round(self) -> f64 { - unsafe { intrinsics::roundf64(self) } - } - - /// The integer part of the number (rounds towards `0.0`) - #[inline] - fn trunc(self) -> f64 { - unsafe { intrinsics::truncf64(self) } - } - - /// The fractional part of the number, satisfying: - /// - /// ```rust - /// let x = 1.65f64; - /// assert!(x == x.trunc() + x.fract()) - /// ``` - #[inline] - fn fract(self) -> f64 { self - self.trunc() } - #[inline] fn max(self, other: f64) -> f64 { unsafe { cmath::fmax(self, other) } @@ -239,44 +114,6 @@ impl Float for f64 { unsafe { cmath::fmin(self, other) } } - /// Fused multiply-add. Computes `(self * a) + b` with only one rounding - /// error. This produces a more accurate result with better performance than - /// a separate multiplication operation followed by an add. - #[inline] - fn mul_add(self, a: f64, b: f64) -> f64 { - unsafe { intrinsics::fmaf64(self, a, b) } - } - - /// The reciprocal (multiplicative inverse) of the number - #[inline] - fn recip(self) -> f64 { 1.0 / self } - - #[inline] - fn powf(self, n: f64) -> f64 { - unsafe { intrinsics::powf64(self, n) } - } - - #[inline] - fn powi(self, n: i32) -> f64 { - unsafe { intrinsics::powif64(self, n) } - } - - /// sqrt(2.0) - #[inline] - fn sqrt2() -> f64 { consts::SQRT2 } - - /// 1.0 / sqrt(2.0) - #[inline] - fn frac_1_sqrt2() -> f64 { consts::FRAC_1_SQRT2 } - - #[inline] - fn sqrt(self) -> f64 { - unsafe { intrinsics::sqrtf64(self) } - } - - #[inline] - fn rsqrt(self) -> f64 { self.sqrt().recip() } - #[inline] fn cbrt(self) -> f64 { unsafe { cmath::cbrt(self) } @@ -287,46 +124,6 @@ impl Float for f64 { unsafe { cmath::hypot(self, other) } } - /// Archimedes' constant - #[inline] - fn pi() -> f64 { consts::PI } - - /// 2.0 * pi - #[inline] - fn two_pi() -> f64 { consts::PI_2 } - - /// pi / 2.0 - #[inline] - fn frac_pi_2() -> f64 { consts::FRAC_PI_2 } - - /// pi / 3.0 - #[inline] - fn frac_pi_3() -> f64 { consts::FRAC_PI_3 } - - /// pi / 4.0 - #[inline] - fn frac_pi_4() -> f64 { consts::FRAC_PI_4 } - - /// pi / 6.0 - #[inline] - fn frac_pi_6() -> f64 { consts::FRAC_PI_6 } - - /// pi / 8.0 - #[inline] - fn frac_pi_8() -> f64 { consts::FRAC_PI_8 } - - /// 1.0 / pi - #[inline] - fn frac_1_pi() -> f64 { consts::FRAC_1_PI } - - /// 2.0 / pi - #[inline] - fn frac_2_pi() -> f64 { consts::FRAC_2_PI } - - /// 2.0 / sqrt(pi) - #[inline] - fn frac_2_sqrtpi() -> f64 { consts::FRAC_2_SQRTPI } - #[inline] fn sin(self) -> f64 { unsafe { intrinsics::sinf64(self) } @@ -368,38 +165,6 @@ impl Float for f64 { (self.sin(), self.cos()) } - /// Euler's number - #[inline] - fn e() -> f64 { consts::E } - - /// log2(e) - #[inline] - fn log2_e() -> f64 { consts::LOG2_E } - - /// log10(e) - #[inline] - fn log10_e() -> f64 { consts::LOG10_E } - - /// ln(2.0) - #[inline] - fn ln_2() -> f64 { consts::LN_2 } - - /// ln(10.0) - #[inline] - fn ln_10() -> f64 { consts::LN_10 } - - /// Returns the exponential of the number - #[inline] - fn exp(self) -> f64 { - unsafe { intrinsics::expf64(self) } - } - - /// Returns 2 raised to the power of the number - #[inline] - fn exp2(self) -> f64 { - unsafe { intrinsics::exp2f64(self) } - } - /// Returns the exponential of the number, minus `1`, in a way that is /// accurate even if the number is close to zero #[inline] @@ -407,28 +172,6 @@ impl Float for f64 { unsafe { cmath::expm1(self) } } - /// Returns the natural logarithm of the number - #[inline] - fn ln(self) -> f64 { - unsafe { intrinsics::logf64(self) } - } - - /// Returns the logarithm of the number with respect to an arbitrary base - #[inline] - fn log(self, base: f64) -> f64 { self.ln() / base.ln() } - - /// Returns the base 2 logarithm of the number - #[inline] - fn log2(self) -> f64 { - unsafe { intrinsics::log2f64(self) } - } - - /// Returns the base 10 logarithm of the number - #[inline] - fn log10(self) -> f64 { - unsafe { intrinsics::log10f64(self) } - } - /// Returns the natural logarithm of the number plus `1` (`ln(1+n)`) more /// accurately than if the operations were performed separately #[inline] @@ -495,17 +238,6 @@ impl Float for f64 { fn atanh(self) -> f64 { 0.5 * ((2.0 * self) / (1.0 - self)).ln_1p() } - - /// Converts to degrees, assuming the number is in radians - #[inline] - fn to_degrees(self) -> f64 { self * (180.0f64 / Float::pi()) } - - /// Converts to radians, assuming the number is in degrees - #[inline] - fn to_radians(self) -> f64 { - let value: f64 = Float::pi(); - self * (value / 180.0) - } } // @@ -1003,18 +735,18 @@ mod tests { // are supported in floating-point literals let f1: f64 = from_str_hex("1p-123").unwrap(); let f2: f64 = from_str_hex("1p-111").unwrap(); - assert_eq!(Float::ldexp(1f64, -123), f1); - assert_eq!(Float::ldexp(1f64, -111), f2); + assert_eq!(FloatMath::ldexp(1f64, -123), f1); + assert_eq!(FloatMath::ldexp(1f64, -111), f2); - assert_eq!(Float::ldexp(0f64, -123), 0f64); - assert_eq!(Float::ldexp(-0f64, -123), -0f64); + assert_eq!(FloatMath::ldexp(0f64, -123), 0f64); + assert_eq!(FloatMath::ldexp(-0f64, -123), -0f64); let inf: f64 = Float::infinity(); let neg_inf: f64 = Float::neg_infinity(); let nan: f64 = Float::nan(); - assert_eq!(Float::ldexp(inf, -123), inf); - assert_eq!(Float::ldexp(neg_inf, -123), neg_inf); - assert!(Float::ldexp(nan, -123).is_nan()); + assert_eq!(FloatMath::ldexp(inf, -123), inf); + assert_eq!(FloatMath::ldexp(neg_inf, -123), neg_inf); + assert!(FloatMath::ldexp(nan, -123).is_nan()); } #[test] @@ -1027,8 +759,8 @@ mod tests { let (x2, exp2) = f2.frexp(); assert_eq!((x1, exp1), (0.5f64, -122)); assert_eq!((x2, exp2), (0.5f64, -110)); - assert_eq!(Float::ldexp(x1, exp1), f1); - assert_eq!(Float::ldexp(x2, exp2), f2); + assert_eq!(FloatMath::ldexp(x1, exp1), f1); + assert_eq!(FloatMath::ldexp(x2, exp2), f2); assert_eq!(0f64.frexp(), (0f64, 0)); assert_eq!((-0f64).frexp(), (-0f64, 0)); diff --git a/src/libstd/num/i16.rs b/src/libstd/num/i16.rs index d8f1c108b74..396037d0dba 100644 --- a/src/libstd/num/i16.rs +++ b/src/libstd/num/i16.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::i16::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/i32.rs b/src/libstd/num/i32.rs index 9cc8981fc13..5640e82d077 100644 --- a/src/libstd/num/i32.rs +++ b/src/libstd/num/i32.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::i32::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/i64.rs b/src/libstd/num/i64.rs index 4f7fe32cc70..40245691e34 100644 --- a/src/libstd/num/i64.rs +++ b/src/libstd/num/i64.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::i64::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/i8.rs b/src/libstd/num/i8.rs index bea315d8683..7ddddd893e2 100644 --- a/src/libstd/num/i8.rs +++ b/src/libstd/num/i8.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::i8::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/int.rs b/src/libstd/num/int.rs index d6a7fd1660b..dc4d80601b7 100644 --- a/src/libstd/num/int.rs +++ b/src/libstd/num/int.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::int::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/int_macros.rs b/src/libstd/num/int_macros.rs index fcdb63f5ad5..ddff42f68db 100644 --- a/src/libstd/num/int_macros.rs +++ b/src/libstd/num/int_macros.rs @@ -62,31 +62,23 @@ impl FromStrRadix for $T { /// ``` #[inline] pub fn to_str_bytes<U>(n: $T, radix: uint, f: |v: &[u8]| -> U) -> U { + use io::{Writer, Seek}; // The radix can be as low as 2, so we need at least 64 characters for a // base 2 number, and then we need another for a possible '-' character. let mut buf = [0u8, ..65]; - let mut cur = 0; - strconv::int_to_str_bytes_common(n, radix, strconv::SignNeg, |i| { - buf[cur] = i; - cur += 1; - }); - f(buf.slice(0, cur)) + let amt = { + let mut wr = ::io::BufWriter::new(buf); + (write!(&mut wr, "{}", ::fmt::radix(n, radix as u8))).unwrap(); + wr.tell().unwrap() as uint + }; + f(buf.slice(0, amt)) } impl ToStrRadix for $T { /// Convert to a string in a given base. #[inline] fn to_str_radix(&self, radix: uint) -> ~str { - use slice::Vector; - use str::StrAllocating; - - let mut buf = ::vec::Vec::new(); - strconv::int_to_str_bytes_common(*self, radix, strconv::SignNeg, |i| { - buf.push(i); - }); - // We know we generated valid utf-8, so we don't need to go through that - // check. - unsafe { str::raw::from_utf8(buf.as_slice()).to_owned() } + format!("{}", ::fmt::radix(*self, radix as u8)) } } diff --git a/src/libstd/num/mod.rs b/src/libstd/num/mod.rs index 1efd7cad300..3178fcbd66f 100644 --- a/src/libstd/num/mod.rs +++ b/src/libstd/num/mod.rs @@ -30,71 +30,13 @@ pub use core::num::{checked_next_power_of_two}; pub use core::num::{from_int, from_i8, from_i16, from_i32, from_i64}; pub use core::num::{from_uint, from_u8, from_u16, from_u32, from_u64}; pub use core::num::{from_f32, from_f64}; +pub use core::num::{FPCategory, FPNaN, FPInfinite, FPZero, FPSubnormal}; +pub use core::num::{FPNormal, Float}; pub mod strconv; -/// Used for representing the classification of floating point numbers -#[deriving(Eq, Show)] -pub enum FPCategory { - /// "Not a Number", often obtained by dividing by zero - FPNaN, - /// Positive or negative infinity - FPInfinite , - /// Positive or negative zero - FPZero, - /// De-normalized floating point representation (less precise than `FPNormal`) - FPSubnormal, - /// A regular floating point number - FPNormal, -} - -/// Operations on primitive floating point numbers. -// FIXME(#5527): In a future version of Rust, many of these functions will -// become constants. -// -// FIXME(#8888): Several of these functions have a parameter named -// `unused_self`. Removing it requires #8888 to be fixed. -pub trait Float: Signed + Primitive { - /// Returns the NaN value. - fn nan() -> Self; - /// Returns the infinite value. - fn infinity() -> Self; - /// Returns the negative infinite value. - fn neg_infinity() -> Self; - /// Returns -0.0. - fn neg_zero() -> Self; - - /// Returns true if this value is NaN and false otherwise. - fn is_nan(self) -> bool; - /// Returns true if this value is positive infinity or negative infinity and - /// false otherwise. - fn is_infinite(self) -> bool; - /// Returns true if this number is neither infinite nor NaN. - fn is_finite(self) -> bool; - /// Returns true if this number is neither zero, infinite, denormal, or NaN. - fn is_normal(self) -> bool; - /// Returns the category that this number falls into. - fn classify(self) -> FPCategory; - - // FIXME (#5527): These should be associated constants - - /// Returns the number of binary digits of mantissa that this type supports. - fn mantissa_digits(unused_self: Option<Self>) -> uint; - /// Returns the number of base-10 digits of precision that this type supports. - fn digits(unused_self: Option<Self>) -> uint; - /// Returns the difference between 1.0 and the smallest representable number larger than 1.0. - fn epsilon() -> Self; - /// Returns the minimum binary exponent that this type can represent. - fn min_exp(unused_self: Option<Self>) -> int; - /// Returns the maximum binary exponent that this type can represent. - fn max_exp(unused_self: Option<Self>) -> int; - /// Returns the minimum base-10 exponent that this type can represent. - fn min_10_exp(unused_self: Option<Self>) -> int; - /// Returns the maximum base-10 exponent that this type can represent. - fn max_10_exp(unused_self: Option<Self>) -> int; - /// Returns the smallest normalized positive number that this type can represent. - fn min_pos_value(unused_self: Option<Self>) -> Self; - +/// Mathematical operations on primitive floating point numbers. +pub trait FloatMath: Float { /// Constructs a floating point number created by multiplying `x` by 2 /// raised to the power of `exp`. fn ldexp(x: Self, exp: int) -> Self; @@ -105,82 +47,22 @@ pub trait Float: Signed + Primitive { /// /// * `0.5 <= abs(x) < 1.0` fn frexp(self) -> (Self, int); - /// Returns the mantissa, exponent and sign as integers, respectively. - fn integer_decode(self) -> (u64, i16, i8); /// Returns the next representable floating-point value in the direction of /// `other`. fn next_after(self, other: Self) -> Self; - /// Return the largest integer less than or equal to a number. - fn floor(self) -> Self; - /// Return the smallest integer greater than or equal to a number. - fn ceil(self) -> Self; - /// Return the nearest integer to a number. Round half-way cases away from - /// `0.0`. - fn round(self) -> Self; - /// Return the integer part of a number. - fn trunc(self) -> Self; - /// Return the fractional part of a number. - fn fract(self) -> Self; - /// Returns the maximum of the two numbers. fn max(self, other: Self) -> Self; /// Returns the minimum of the two numbers. fn min(self, other: Self) -> Self; - /// Fused multiply-add. Computes `(self * a) + b` with only one rounding - /// error. This produces a more accurate result with better performance than - /// a separate multiplication operation followed by an add. - fn mul_add(self, a: Self, b: Self) -> Self; - /// Take the reciprocal (inverse) of a number, `1/x`. - fn recip(self) -> Self; - - /// Raise a number to an integer power. - /// - /// Using this function is generally faster than using `powf` - fn powi(self, n: i32) -> Self; - /// Raise a number to a floating point power. - fn powf(self, n: Self) -> Self; - - /// sqrt(2.0). - fn sqrt2() -> Self; - /// 1.0 / sqrt(2.0). - fn frac_1_sqrt2() -> Self; - - /// Take the square root of a number. - fn sqrt(self) -> Self; - /// Take the reciprocal (inverse) square root of a number, `1/sqrt(x)`. - fn rsqrt(self) -> Self; /// Take the cubic root of a number. fn cbrt(self) -> Self; /// Calculate the length of the hypotenuse of a right-angle triangle given /// legs of length `x` and `y`. fn hypot(self, other: Self) -> Self; - // FIXME (#5527): These should be associated constants - - /// Archimedes' constant. - fn pi() -> Self; - /// 2.0 * pi. - fn two_pi() -> Self; - /// pi / 2.0. - fn frac_pi_2() -> Self; - /// pi / 3.0. - fn frac_pi_3() -> Self; - /// pi / 4.0. - fn frac_pi_4() -> Self; - /// pi / 6.0. - fn frac_pi_6() -> Self; - /// pi / 8.0. - fn frac_pi_8() -> Self; - /// 1.0 / pi. - fn frac_1_pi() -> Self; - /// 2.0 / pi. - fn frac_2_pi() -> Self; - /// 2.0 / sqrt(pi). - fn frac_2_sqrtpi() -> Self; - /// Computes the sine of a number (in radians). fn sin(self) -> Self; /// Computes the cosine of a number (in radians). @@ -206,32 +88,9 @@ pub trait Float: Signed + Primitive { /// `(sin(x), cos(x))`. fn sin_cos(self) -> (Self, Self); - /// Euler's number. - fn e() -> Self; - /// log2(e). - fn log2_e() -> Self; - /// log10(e). - fn log10_e() -> Self; - /// ln(2.0). - fn ln_2() -> Self; - /// ln(10.0). - fn ln_10() -> Self; - - /// Returns `e^(self)`, (the exponential function). - fn exp(self) -> Self; - /// Returns 2 raised to the power of the number, `2^(self)`. - fn exp2(self) -> Self; /// Returns the exponential of the number, minus 1, in a way that is /// accurate even if the number is close to zero. fn exp_m1(self) -> Self; - /// Returns the natural logarithm of the number. - fn ln(self) -> Self; - /// Returns the logarithm of the number with respect to an arbitrary base. - fn log(self, base: Self) -> Self; - /// Returns the base 2 logarithm of the number. - fn log2(self) -> Self; - /// Returns the base 10 logarithm of the number. - fn log10(self) -> Self; /// Returns the natural logarithm of the number plus 1 (`ln(1+n)`) more /// accurately than if the operations were performed separately. fn ln_1p(self) -> Self; @@ -248,11 +107,6 @@ pub trait Float: Signed + Primitive { fn acosh(self) -> Self; /// Inverse hyperbolic tangent function. fn atanh(self) -> Self; - - /// Convert radians to degrees. - fn to_degrees(self) -> Self; - /// Convert degrees to radians. - fn to_radians(self) -> Self; } /// A generic trait for converting a value to a string with a radix (base) diff --git a/src/libstd/num/strconv.rs b/src/libstd/num/strconv.rs index 63d6219ab8a..e58872b8395 100644 --- a/src/libstd/num/strconv.rs +++ b/src/libstd/num/strconv.rs @@ -19,7 +19,6 @@ use num::{Float, FPNaN, FPInfinite, ToPrimitive}; use num; use ops::{Add, Sub, Mul, Div, Rem, Neg}; use option::{None, Option, Some}; -use result::ResultUnwrap; use slice::{CloneableVector, ImmutableVector, MutableVector}; use std::cmp::{Ord, Eq}; use str::{StrAllocating, StrSlice}; @@ -170,6 +169,7 @@ static NAN_BUF: [u8, ..3] = ['N' as u8, 'a' as u8, 'N' as u8]; * # Failure * - Fails if `radix` < 2 or `radix` > 36. */ +#[deprecated = "format!() and friends should be favored instead"] pub fn int_to_str_bytes_common<T: Int>(num: T, radix: uint, sign: SignFormat, f: |u8|) { assert!(2 <= radix && radix <= 36); @@ -258,6 +258,7 @@ pub fn int_to_str_bytes_common<T: Int>(num: T, radix: uint, sign: SignFormat, f: * - Fails if `radix` > 25 and `exp_format` is `ExpBin` due to conflict * between digit and exponent sign `'p'`. */ +#[allow(deprecated)] pub fn float_to_str_bytes_common<T:NumCast+Zero+One+Eq+Ord+Float+ Div<T,T>+Neg<T>+Rem<T,T>+Mul<T,T>>( num: T, radix: uint, negative_zero: bool, @@ -820,7 +821,6 @@ mod bench { use super::test::Bencher; use rand::{XorShiftRng, Rng}; use num::ToStrRadix; - use realstd::result::ResultUnwrap; #[bench] fn to_str_bin(b: &mut Bencher) { @@ -857,7 +857,6 @@ mod bench { use super::test::Bencher; use rand::{XorShiftRng, Rng}; use num::ToStrRadix; - use realstd::result::ResultUnwrap; #[bench] fn to_str_bin(b: &mut Bencher) { @@ -894,7 +893,6 @@ mod bench { use super::test::Bencher; use rand::{XorShiftRng, Rng}; use f64; - use realstd::result::ResultUnwrap; #[bench] fn float_to_str(b: &mut Bencher) { diff --git a/src/libstd/num/u16.rs b/src/libstd/num/u16.rs index 5c93ca6c36b..65ac46af5aa 100644 --- a/src/libstd/num/u16.rs +++ b/src/libstd/num/u16.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::u16::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/u32.rs b/src/libstd/num/u32.rs index 436eae7cd14..d549e4d0d63 100644 --- a/src/libstd/num/u32.rs +++ b/src/libstd/num/u32.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::u32::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/u64.rs b/src/libstd/num/u64.rs index c654d6fbe31..3773e56f4d1 100644 --- a/src/libstd/num/u64.rs +++ b/src/libstd/num/u64.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::u64::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/u8.rs b/src/libstd/num/u8.rs index 7051b9191be..372e38d6652 100644 --- a/src/libstd/num/u8.rs +++ b/src/libstd/num/u8.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::u8::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/uint.rs b/src/libstd/num/uint.rs index d1c3e96b2c9..c419276fa24 100644 --- a/src/libstd/num/uint.rs +++ b/src/libstd/num/uint.rs @@ -15,7 +15,6 @@ use num::{ToStrRadix, FromStrRadix}; use num::strconv; use option::Option; use slice::ImmutableVector; -use str; pub use core::uint::{BITS, BYTES, MIN, MAX}; diff --git a/src/libstd/num/uint_macros.rs b/src/libstd/num/uint_macros.rs index 0795238a49c..7977c647606 100644 --- a/src/libstd/num/uint_macros.rs +++ b/src/libstd/num/uint_macros.rs @@ -63,31 +63,23 @@ impl FromStrRadix for $T { /// ``` #[inline] pub fn to_str_bytes<U>(n: $T, radix: uint, f: |v: &[u8]| -> U) -> U { + use io::{Writer, Seek}; // The radix can be as low as 2, so we need at least 64 characters for a - // base 2 number. - let mut buf = [0u8, ..64]; - let mut cur = 0; - strconv::int_to_str_bytes_common(n, radix, strconv::SignNone, |i| { - buf[cur] = i; - cur += 1; - }); - f(buf.slice(0, cur)) + // base 2 number, and then we need another for a possible '-' character. + let mut buf = [0u8, ..65]; + let amt = { + let mut wr = ::io::BufWriter::new(buf); + (write!(&mut wr, "{}", ::fmt::radix(n, radix as u8))).unwrap(); + wr.tell().unwrap() as uint + }; + f(buf.slice(0, amt)) } impl ToStrRadix for $T { /// Convert to a string in a given base. #[inline] fn to_str_radix(&self, radix: uint) -> ~str { - use slice::Vector; - use str::StrAllocating; - - let mut buf = ::vec::Vec::new(); - strconv::int_to_str_bytes_common(*self, radix, strconv::SignNone, |i| { - buf.push(i); - }); - // We know we generated valid utf-8, so we don't need to go through that - // check. - unsafe { str::raw::from_utf8(buf.as_slice()).to_owned() } + format!("{}", ::fmt::radix(*self, radix as u8)) } } diff --git a/src/libstd/os.rs b/src/libstd/os.rs index 88081d90b40..a4705b78caa 100644 --- a/src/libstd/os.rs +++ b/src/libstd/os.rs @@ -1073,19 +1073,19 @@ impl fmt::Show for MapError { ErrAlreadyExists => "File mapping for specified file already exists", ErrZeroLength => "Zero-length mapping not allowed", ErrUnknown(code) => { - return write!(out.buf, "Unknown error = {}", code) + return write!(out, "Unknown error = {}", code) }, ErrVirtualAlloc(code) => { - return write!(out.buf, "VirtualAlloc failure = {}", code) + return write!(out, "VirtualAlloc failure = {}", code) }, ErrCreateFileMappingW(code) => { - return write!(out.buf, "CreateFileMappingW failure = {}", code) + return write!(out, "CreateFileMappingW failure = {}", code) }, ErrMapViewOfFile(code) => { - return write!(out.buf, "MapViewOfFile failure = {}", code) + return write!(out, "MapViewOfFile failure = {}", code) } }; - write!(out.buf, "{}", str) + write!(out, "{}", str) } } diff --git a/src/libstd/owned.rs b/src/libstd/owned.rs index 3af12c5154c..bd6684b3905 100644 --- a/src/libstd/owned.rs +++ b/src/libstd/owned.rs @@ -14,6 +14,7 @@ use any::{Any, AnyRefExt}; use clone::Clone; use cmp::{Eq, Ord, TotalEq, TotalOrd, Ordering}; use default::Default; +use fmt; use intrinsics; use mem; use raw::TraitObject; @@ -99,3 +100,16 @@ impl AnyOwnExt for Box<Any> { } } } + +impl<T: fmt::Show> fmt::Show for Box<T> { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + (**self).fmt(f) + } +} + +#[cfg(not(stage0))] +impl fmt::Show for Box<Any> { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + f.pad("Box<Any>") + } +} diff --git a/src/libstd/prelude.rs b/src/libstd/prelude.rs index 6cd9e96496f..e39d8d34447 100644 --- a/src/libstd/prelude.rs +++ b/src/libstd/prelude.rs @@ -64,13 +64,12 @@ pub use iter::{Iterator, DoubleEndedIterator, RandomAccessIterator, CloneableIte pub use iter::{OrdIterator, MutableDoubleEndedIterator, ExactSize}; pub use num::{Num, NumCast, CheckedAdd, CheckedSub, CheckedMul}; pub use num::{Signed, Unsigned}; -pub use num::{Primitive, Int, Float, ToPrimitive, FromPrimitive}; +pub use num::{Primitive, Int, Float, FloatMath, ToPrimitive, FromPrimitive}; pub use option::Expect; pub use owned::Box; pub use path::{GenericPath, Path, PosixPath, WindowsPath}; pub use ptr::RawPtr; pub use io::{Buffer, Writer, Reader, Seek}; -pub use result::{ResultUnwrap, ResultUnwrapErr}; pub use str::{Str, StrVector, StrSlice, OwnedStr, IntoMaybeOwned}; pub use str::{StrAllocating}; pub use to_str::{ToStr, IntoStr}; diff --git a/src/libstd/repr.rs b/src/libstd/repr.rs index 6029f504d10..35f32d08728 100644 --- a/src/libstd/repr.rs +++ b/src/libstd/repr.rs @@ -25,7 +25,7 @@ use option::{Some, None, Option}; use ptr::RawPtr; use reflect; use reflect::{MovePtr, align}; -use result::{Ok, Err, ResultUnwrap}; +use result::{Ok, Err}; use str::StrSlice; use to_str::ToStr; use slice::Vector; diff --git a/src/libstd/result.rs b/src/libstd/result.rs deleted file mode 100644 index ecbc164590b..00000000000 --- a/src/libstd/result.rs +++ /dev/null @@ -1,312 +0,0 @@ -// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT -// file at the top-level directory of this distribution and at -// http://rust-lang.org/COPYRIGHT. -// -// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or -// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license -// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your -// option. This file may not be copied, modified, or distributed -// except according to those terms. - -//! Error handling with the `Result` type -//! -//! `Result<T>` is the type used for returning and propagating -//! errors. It is an enum with the variants, `Ok(T)`, representing -//! success and containing a value, and `Err(E)`, representing error -//! and containing an error value. -//! -//! ~~~ -//! enum Result<T, E> { -//! Ok(T), -//! Err(E) -//! } -//! ~~~ -//! -//! Functions return `Result` whenever errors are expected and -//! recoverable. In the `std` crate `Result` is most prominently used -//! for [I/O](../io/index.html). -//! -//! A simple function returning `Result` might be -//! defined and used like so: -//! -//! ~~~ -//! #[deriving(Show)] -//! enum Version { Version1, Version2 } -//! -//! fn parse_version(header: &[u8]) -> Result<Version, &'static str> { -//! if header.len() < 1 { -//! return Err("invalid header length"); -//! } -//! match header[0] { -//! 1 => Ok(Version1), -//! 2 => Ok(Version2), -//! _ => Err("invalid version") -//! } -//! } -//! -//! let version = parse_version(&[1, 2, 3, 4]); -//! match version { -//! Ok(v) => { -//! println!("working with version: {}", v); -//! } -//! Err(e) => { -//! println!("error parsing header: {}", e); -//! } -//! } -//! ~~~ -//! -//! Pattern matching on `Result`s is clear and straightforward for -//! simple cases, but `Result` comes with some convenience methods -//! that make working it more succinct. -//! -//! ~~~ -//! let good_result: Result<int, int> = Ok(10); -//! let bad_result: Result<int, int> = Err(10); -//! -//! // The `is_ok` and `is_err` methods do what they say. -//! assert!(good_result.is_ok() && !good_result.is_err()); -//! assert!(bad_result.is_err() && !bad_result.is_ok()); -//! -//! // `map` consumes the `Result` and produces another. -//! let good_result: Result<int, int> = good_result.map(|i| i + 1); -//! let bad_result: Result<int, int> = bad_result.map(|i| i - 1); -//! -//! // Use `and_then` to continue the computation. -//! let good_result: Result<bool, int> = good_result.and_then(|i| Ok(i == 11)); -//! -//! // Use `or_else` to handle the error. -//! let bad_result: Result<int, int> = bad_result.or_else(|i| Ok(11)); -//! -//! // Consume the result and return the contents with `unwrap`. -//! let final_awesome_result = good_result.ok().unwrap(); -//! ~~~ -//! -//! # Results must be used -//! -//! A common problem with using return values to indicate errors is -//! that it is easy to ignore the return value, thus failing to handle -//! the error. Result is annotated with the #[must_use] attribute, -//! which will cause the compiler to issue a warning when a Result -//! value is ignored. This makes `Result` especially useful with -//! functions that may encounter errors but don't otherwise return a -//! useful value. -//! -//! Consider the `write_line` method defined for I/O types -//! by the [`Writer`](../io/trait.Writer.html) trait: -//! -//! ~~~ -//! use std::io::IoError; -//! -//! trait Writer { -//! fn write_line(&mut self, s: &str) -> Result<(), IoError>; -//! } -//! ~~~ -//! -//! *Note: The actual definition of `Writer` uses `IoResult`, which -//! is just a synonym for `Result<T, IoError>`.* -//! -//! This method doesn`t produce a value, but the write may -//! fail. It's crucial to handle the error case, and *not* write -//! something like this: -//! -//! ~~~ignore -//! use std::io::{File, Open, Write}; -//! -//! let mut file = File::open_mode(&Path::new("valuable_data.txt"), Open, Write); -//! // If `write_line` errors, then we'll never know, because the return -//! // value is ignored. -//! file.write_line("important message"); -//! drop(file); -//! ~~~ -//! -//! If you *do* write that in Rust, the compiler will by give you a -//! warning (by default, controlled by the `unused_must_use` lint). -//! -//! You might instead, if you don't want to handle the error, simply -//! fail, by converting to an `Option` with `ok`, then asserting -//! success with `expect`. This will fail if the write fails, proving -//! a marginally useful message indicating why: -//! -//! ~~~no_run -//! use std::io::{File, Open, Write}; -//! -//! let mut file = File::open_mode(&Path::new("valuable_data.txt"), Open, Write); -//! file.write_line("important message").ok().expect("failed to write message"); -//! drop(file); -//! ~~~ -//! -//! You might also simply assert success: -//! -//! ~~~no_run -//! # use std::io::{File, Open, Write}; -//! -//! # let mut file = File::open_mode(&Path::new("valuable_data.txt"), Open, Write); -//! assert!(file.write_line("important message").is_ok()); -//! # drop(file); -//! ~~~ -//! -//! Or propagate the error up the call stack with `try!`: -//! -//! ~~~ -//! # use std::io::{File, Open, Write, IoError}; -//! fn write_message() -> Result<(), IoError> { -//! let mut file = File::open_mode(&Path::new("valuable_data.txt"), Open, Write); -//! try!(file.write_line("important message")); -//! drop(file); -//! return Ok(()); -//! } -//! ~~~ -//! -//! # The `try!` macro -//! -//! When writing code that calls many functions that return the -//! `Result` type, the error handling can be tedious. The `try!` -//! macro hides some of the boilerplate of propagating errors up the -//! call stack. -//! -//! It replaces this: -//! -//! ~~~ -//! use std::io::{File, Open, Write, IoError}; -//! -//! struct Info { name: ~str, age: int, rating: int } -//! -//! fn write_info(info: &Info) -> Result<(), IoError> { -//! let mut file = File::open_mode(&Path::new("my_best_friends.txt"), Open, Write); -//! // Early return on error -//! match file.write_line(format!("name: {}", info.name)) { -//! Ok(_) => (), -//! Err(e) => return Err(e) -//! } -//! match file.write_line(format!("age: {}", info.age)) { -//! Ok(_) => (), -//! Err(e) => return Err(e) -//! } -//! return file.write_line(format!("rating: {}", info.rating)); -//! } -//! ~~~ -//! -//! With this: -//! -//! ~~~ -//! use std::io::{File, Open, Write, IoError}; -//! -//! struct Info { name: ~str, age: int, rating: int } -//! -//! fn write_info(info: &Info) -> Result<(), IoError> { -//! let mut file = File::open_mode(&Path::new("my_best_friends.txt"), Open, Write); -//! // Early return on error -//! try!(file.write_line(format!("name: {}", info.name))); -//! try!(file.write_line(format!("age: {}", info.age))); -//! try!(file.write_line(format!("rating: {}", info.rating))); -//! return Ok(()); -//! } -//! ~~~ -//! -//! *It's much nicer!* -//! -//! Wrapping an expression in `try!` will result in the unwrapped -//! success (`Ok`) value, unless the result is `Err`, in which case -//! `Err` is returned early from the enclosing function. Its simple definition -//! makes it clear: -//! -//! ~~~ -//! # #![feature(macro_rules)] -//! macro_rules! try( -//! ($e:expr) => (match $e { Ok(e) => e, Err(e) => return Err(e) }) -//! ) -//! # fn main() { } -//! ~~~ -//! -//! `try!` is imported by the prelude, and is available everywhere. -//! -//! # `Result` and `Option` -//! -//! The `Result` and [`Option`](../option/index.html) types are -//! similar and complementary: they are often employed to indicate a -//! lack of a return value; and they are trivially converted between -//! each other, so `Result`s are often handled by first converting to -//! `Option` with the [`ok`](../../core/result/enum.Result.html#method.ok) and -//! [`err`](../../core/result/enum.Result.html#method.ok) methods. -//! -//! Whereas `Option` only indicates the lack of a value, `Result` is -//! specifically for error reporting, and carries with it an error -//! value. Sometimes `Option` is used for indicating errors, but this -//! is only for simple cases and is generally discouraged. Even when -//! there is no useful error value to return, prefer `Result<T, ()>`. -//! -//! Converting to an `Option` with `ok()` to handle an error: -//! -//! ~~~ -//! use std::io::Timer; -//! let mut t = Timer::new().ok().expect("failed to create timer!"); -//! ~~~ -//! -//! # `Result` vs. `fail!` -//! -//! `Result` is for recoverable errors; `fail!` is for unrecoverable -//! errors. Callers should always be able to avoid failure if they -//! take the proper precautions, for example, calling `is_some()` -//! on an `Option` type before calling `unwrap`. -//! -//! The suitability of `fail!` as an error handling mechanism is -//! limited by Rust's lack of any way to "catch" and resume execution -//! from a thrown exception. Therefore using failure for error -//! handling requires encapsulating fallable code in a task. Calling -//! the `fail!` macro, or invoking `fail!` indirectly should be -//! avoided as an error reporting strategy. Failure is only for -//! unrecoverable errors and a failing task is typically the sign of -//! a bug. -//! -//! A module that instead returns `Results` is alerting the caller -//! that failure is possible, and providing precise control over how -//! it is handled. -//! -//! Furthermore, failure may not be recoverable at all, depending on -//! the context. The caller of `fail!` should assume that execution -//! will not resume after failure, that failure is catastrophic. - -use fmt::Show; - -pub use core::result::{Result, Ok, Err, collect, fold, fold_}; - -// FIXME: These traits should not exist. Once std::fmt is moved to libcore, -// these can once again become inherent methods on Result. - -/// Temporary trait for unwrapping a result -pub trait ResultUnwrap<T, E> { - /// Unwraps a result, yielding the content of an `Ok`. - /// - /// Fails if the value is an `Err`. - fn unwrap(self) -> T; -} - -/// Temporary trait for unwrapping the error of a result -pub trait ResultUnwrapErr<T, E> { - /// Unwraps a result, yielding the content of an `Err`. - /// - /// Fails if the value is an `Ok`. - fn unwrap_err(self) -> E; -} - -impl<T, E: Show> ResultUnwrap<T, E> for Result<T, E> { - #[inline] - fn unwrap(self) -> T { - match self { - Ok(t) => t, - Err(e) => - fail!("called `Result::unwrap()` on an `Err` value: {}", e) - } - } -} - -impl<T: Show, E> ResultUnwrapErr<T, E> for Result<T, E> { - #[inline] - fn unwrap_err(self) -> E { - match self { - Ok(t) => - fail!("called `Result::unwrap_err()` on an `Ok` value: {}", t), - Err(e) => e - } - } -} diff --git a/src/libstd/rt/unwind.rs b/src/libstd/rt/unwind.rs index e10e0716f67..1cc513825a7 100644 --- a/src/libstd/rt/unwind.rs +++ b/src/libstd/rt/unwind.rs @@ -295,24 +295,12 @@ pub mod eabi { } } -#[cold] -#[no_mangle] -#[cfg(not(test))] -pub extern fn rust_fail_bounds_check(file: *u8, line: uint, - index: uint, len: uint) -> ! { - use str::raw::c_str_to_static_slice; - - let msg = format!("index out of bounds: the len is {} but the index is {}", - len as uint, index as uint); - begin_unwind(msg, unsafe { c_str_to_static_slice(file as *i8) }, line) -} - // Entry point of failure from the libcore crate #[no_mangle] #[cfg(not(test))] -pub extern fn rust_begin_unwind(msg: &str, file: &'static str, line: uint) -> ! { - use str::StrAllocating; - begin_unwind(msg.to_owned(), file, line) +pub extern fn rust_begin_unwind(msg: &fmt::Arguments, + file: &'static str, line: uint) -> ! { + begin_unwind_fmt(msg, file, line) } /// The entry point for unwinding with a formatted message. @@ -402,9 +390,9 @@ fn begin_unwind_inner(msg: Box<Any:Send>, Some(mut stderr) => { Local::put(task); // FIXME: what to do when the task printing fails? - let _err = format_args!(|args| ::fmt::writeln(stderr, args), - "task '{}' failed at '{}', {}:{}", - n, msg_s, file, line); + let _err = write!(stderr, + "task '{}' failed at '{}', {}:{}\n", + n, msg_s, file, line); if backtrace::log_enabled() { let _err = backtrace::write(stderr); } diff --git a/src/libstd/rt/util.rs b/src/libstd/rt/util.rs index e8b1acb1024..5f9ea14a647 100644 --- a/src/libstd/rt/util.rs +++ b/src/libstd/rt/util.rs @@ -110,8 +110,9 @@ impl io::Writer for Stdio { } pub fn dumb_println(args: &fmt::Arguments) { + use io::Writer; let mut w = Stderr; - let _ = fmt::writeln(&mut w as &mut io::Writer, args); + let _ = writeln!(&mut w, "{}", args); } pub fn abort(msg: &str) -> ! { diff --git a/src/libstd/task.rs b/src/libstd/task.rs index 7fb61c29112..5c875b4a2ad 100644 --- a/src/libstd/task.rs +++ b/src/libstd/task.rs @@ -49,7 +49,6 @@ use str::{Str, SendStr, IntoMaybeOwned}; #[cfg(test)] use any::AnyRefExt; #[cfg(test)] use owned::AnyOwnExt; -#[cfg(test)] use realstd::result::ResultUnwrap; #[cfg(test)] use result; #[cfg(test)] use str::StrAllocating; |
