diff options
| author | Q.P.Liu <qpliu@yahoo.com> | 2014-02-07 21:50:49 -0800 |
|---|---|---|
| committer | Q.P.Liu <qpliu@yahoo.com> | 2014-02-08 17:42:38 -0800 |
| commit | e9c539a488a5b59293b24701b8f121fb7fae1636 (patch) | |
| tree | ce422deb67fdf99868034c4e0a329f39c910ca83 /src/libstd | |
| parent | a2290db7971a1e14e4d15316cecaf5c33cc6b0ba (diff) | |
| download | rust-e9c539a488a5b59293b24701b8f121fb7fae1636.tar.gz rust-e9c539a488a5b59293b24701b8f121fb7fae1636.zip | |
Fix infinite loop in MemReader::read_until.
Diffstat (limited to 'src/libstd')
| -rw-r--r-- | src/libstd/io/mem.rs | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/libstd/io/mem.rs b/src/libstd/io/mem.rs index 395ece17ede..2f0e1e599d9 100644 --- a/src/libstd/io/mem.rs +++ b/src/libstd/io/mem.rs @@ -177,7 +177,11 @@ impl Seek for MemReader { impl Buffer for MemReader { fn fill<'a>(&'a mut self) -> IoResult<&'a [u8]> { - Ok(self.buf.slice_from(self.pos)) + if self.pos < self.buf.len() { + Ok(self.buf.slice_from(self.pos)) + } else { + Err(io::standard_error(io::EndOfFile)) + } } fn consume(&mut self, amt: uint) { self.pos += amt; } } @@ -421,6 +425,10 @@ mod test { assert_eq!(reader.read(buf), Ok(3)); assert_eq!(buf.slice(0, 3), [5, 6, 7]); assert!(reader.read(buf).is_err()); + let mut reader = MemReader::new(~[0, 1, 2, 3, 4, 5, 6, 7]); + assert_eq!(reader.read_until(3).unwrap(), ~[0, 1, 2, 3]); + assert_eq!(reader.read_until(3).unwrap(), ~[4, 5, 6, 7]); + assert!(reader.read(buf).is_err()); } #[test] |
