diff options
| author | Alexis Hunt <lexer@google.com> | 2018-02-16 08:51:40 -0500 |
|---|---|---|
| committer | Alexis Hunt <lexer@google.com> | 2018-02-16 08:52:20 -0500 |
| commit | e9c75a889f972ca88b9c41d0ddb4b0cf487c5ebe (patch) | |
| tree | bb6b373cb039c39cd300f972e7565ca7f302c3ea /src/libstd | |
| parent | 5570cdcc9e7da0cca84e394e872bc16df2c6dc50 (diff) | |
| download | rust-e9c75a889f972ca88b9c41d0ddb4b0cf487c5ebe.tar.gz rust-e9c75a889f972ca88b9c41d0ddb4b0cf487c5ebe.zip | |
Add a warning to File about mutability.
Fixes #47708.
Diffstat (limited to 'src/libstd')
| -rw-r--r-- | src/libstd/fs.rs | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/src/libstd/fs.rs b/src/libstd/fs.rs index 5cea389531f..1798bf4760b 100644 --- a/src/libstd/fs.rs +++ b/src/libstd/fs.rs @@ -81,9 +81,18 @@ use time::SystemTime; /// # } /// ``` /// +/// Note that, although read and write methods require a `&mut File`, because +/// of the interfaces for [`Read`] and [`Write`], it is still possible to +/// modify a file through a `&File`, either through methods that take `&File` +/// or by retrieving a raw OS filehandle and modifying the file that way. +/// Additionally, many operating systems allow concurrent modification of files +/// by different processes. Care should be taken not to assume that holding a +/// `&File` means that the file will not change. +/// /// [`Seek`]: ../io/trait.Seek.html /// [`String`]: ../string/struct.String.html /// [`Read`]: ../io/trait.Read.html +/// [`Write`]: ../io/trait.Write.html /// [`BufReader<R>`]: ../io/struct.BufReader.html #[stable(feature = "rust1", since = "1.0.0")] pub struct File { @@ -459,6 +468,9 @@ impl File { /// # Ok(()) /// # } /// ``` + /// + /// Note that this method alters the content of the underlying file, even + /// though it takes `&self` rather than `&mut self`. #[stable(feature = "rust1", since = "1.0.0")] pub fn set_len(&self, size: u64) -> io::Result<()> { self.inner.truncate(size) @@ -557,6 +569,9 @@ impl File { /// # Ok(()) /// # } /// ``` + /// + /// Note that this method alters the permissions of the underlying file, + /// even though it takes `&self` rather than `&mut self`. #[stable(feature = "set_permissions_atomic", since = "1.16.0")] pub fn set_permissions(&self, perm: Permissions) -> io::Result<()> { self.inner.set_permissions(perm.0) |
