diff options
| author | Palmer Cox <p@lmercox.com> | 2013-12-11 20:40:27 -0500 |
|---|---|---|
| committer | “Palmer <pcox@intelligent.net> | 2013-12-20 20:40:16 -0500 |
| commit | efd619467df28b48b97250b2857b18a032b5dab6 (patch) | |
| tree | 549956f3cf9bbbfc8d2cfa948ddf041b81df77d5 /src/libstd | |
| parent | 9d1de0b699a669d01ea5ecd3dea0424ab94db369 (diff) | |
| download | rust-efd619467df28b48b97250b2857b18a032b5dab6.tar.gz rust-efd619467df28b48b97250b2857b18a032b5dab6.zip | |
Remove remainder field from MutChunkIter
This field is no longer necessary now that #9629 is fixed since we can just access the length of the remaining slice directly.
Diffstat (limited to 'src/libstd')
| -rw-r--r-- | src/libstd/vec.rs | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/src/libstd/vec.rs b/src/libstd/vec.rs index 6eef640d912..17e961723cf 100644 --- a/src/libstd/vec.rs +++ b/src/libstd/vec.rs @@ -2127,8 +2127,7 @@ impl<'a,T> MutableVector<'a, T> for &'a mut [T] { #[inline] fn mut_chunks(self, chunk_size: uint) -> MutChunkIter<'a, T> { assert!(chunk_size > 0); - let len = self.len(); - MutChunkIter { v: self, chunk_size: chunk_size, remaining: len } + MutChunkIter { v: self, chunk_size: chunk_size } } fn mut_shift_ref(&mut self) -> &'a mut T { @@ -2568,31 +2567,29 @@ impl<'a, T> DoubleEndedIterator<&'a mut [T]> for MutSplitIterator<'a, T> { /// the remainder. pub struct MutChunkIter<'a, T> { priv v: &'a mut [T], - priv chunk_size: uint, - priv remaining: uint + priv chunk_size: uint } impl<'a, T> Iterator<&'a mut [T]> for MutChunkIter<'a, T> { #[inline] fn next(&mut self) -> Option<&'a mut [T]> { - if self.remaining == 0 { + if self.v.len() == 0 { None } else { - let sz = cmp::min(self.remaining, self.chunk_size); + let sz = cmp::min(self.v.len(), self.chunk_size); let tmp = util::replace(&mut self.v, &mut []); let (head, tail) = tmp.mut_split_at(sz); self.v = tail; - self.remaining -= sz; Some(head) } } #[inline] fn size_hint(&self) -> (uint, Option<uint>) { - if self.remaining == 0 { + if self.v.len() == 0 { (0, Some(0)) } else { - let (n, rem) = self.remaining.div_rem(&self.chunk_size); + let (n, rem) = self.v.len().div_rem(&self.chunk_size); let n = if rem > 0 { n + 1 } else { n }; (n, Some(n)) } @@ -2602,15 +2599,15 @@ impl<'a, T> Iterator<&'a mut [T]> for MutChunkIter<'a, T> { impl<'a, T> DoubleEndedIterator<&'a mut [T]> for MutChunkIter<'a, T> { #[inline] fn next_back(&mut self) -> Option<&'a mut [T]> { - if self.remaining == 0 { + if self.v.len() == 0 { None } else { - let remainder = self.remaining % self.chunk_size; + let remainder = self.v.len() % self.chunk_size; let sz = if remainder != 0 { remainder } else { self.chunk_size }; let tmp = util::replace(&mut self.v, &mut []); - let (head, tail) = tmp.mut_split_at(self.remaining - sz); + let tmp_len = tmp.len(); + let (head, tail) = tmp.mut_split_at(tmp_len - sz); self.v = head; - self.remaining -= sz; Some(tail) } } |
