auto merge of #12584 : alexcrichton/rust/windows-files, r=brson

These commits fix handling of binary files on windows by using the raw `CreateFile` apis directly, also splitting out the windows/unix implementations to their own files because everything was configured between the two platforms.

With this fix in place, this also switches `rustc` to using libnative instead of libgreen. I have confirmed that this PR passes through try on all bots.

8 files changed, 204 insertions, 158 deletions

diff --git a/src/libstd/io/fs.rs b/src/libstd/io/fs.rs
index ffccb0e8cb1..5f070ef782b 100644
--- a/src/libstd/io/fs.rs
+++ b/src/libstd/io/fs.rs
@@ -663,6 +663,13 @@ mod test {
     use io;
     use ops::Drop;
 
+    macro_rules! check( ($e:expr) => (
+        match $e {
+            Ok(t) => t,
+            Err(e) => fail!("{} failed with: {}", stringify!($e), e),
+        }
+    ) )
+
     struct TempDir(Path);
 
     impl TempDir {
@@ -682,7 +689,7 @@ mod test {
             // Gee, seeing how we're testing the fs module I sure hope that we
             // at least implement this correctly!
             let TempDir(ref p) = *self;
-            io::fs::rmdir_recursive(p).unwrap();
+            check!(io::fs::rmdir_recursive(p));
         }
     }
 
@@ -690,7 +697,7 @@ mod test {
         use os;
         use rand;
         let ret = os::tmpdir().join(format!("rust-{}", rand::random::<u32>()));
-        io::fs::mkdir(&ret, io::UserRWX).unwrap();
+        check!(io::fs::mkdir(&ret, io::UserRWX));
         TempDir(ret)
     }
 
@@ -700,18 +707,18 @@ mod test {
         let filename = &tmpdir.join("file_rt_io_file_test.txt");
         {
             let mut write_stream = File::open_mode(filename, Open, ReadWrite);
-            write_stream.write(message.as_bytes()).unwrap();
+            check!(write_stream.write(message.as_bytes()));
         }
         {
             let mut read_stream = File::open_mode(filename, Open, Read);
             let mut read_buf = [0, .. 1028];
-            let read_str = match read_stream.read(read_buf).unwrap() {
+            let read_str = match check!(read_stream.read(read_buf)) {
                 -1|0 => fail!("shouldn't happen"),
-                n => str::from_utf8_owned(read_buf.slice_to(n).to_owned()).unwrap()
+                n => str::from_utf8(read_buf.slice_to(n).to_owned()).unwrap().to_owned()
             };
             assert_eq!(read_str, message.to_owned());
         }
-        unlink(filename).unwrap();
+        check!(unlink(filename));
     })
 
     iotest!(fn invalid_path_raises() {
@@ -734,20 +741,20 @@ mod test {
         let filename = &tmpdir.join("file_rt_io_file_test_positional.txt");
         {
             let mut rw_stream = File::open_mode(filename, Open, ReadWrite);
-            rw_stream.write(message.as_bytes()).unwrap();
+            check!(rw_stream.write(message.as_bytes()));
         }
         {
             let mut read_stream = File::open_mode(filename, Open, Read);
             {
                 let read_buf = read_mem.mut_slice(0, 4);
-                read_stream.read(read_buf).unwrap();
+                check!(read_stream.read(read_buf));
             }
             {
                 let read_buf = read_mem.mut_slice(4, 8);
-                read_stream.read(read_buf).unwrap();
+                check!(read_stream.read(read_buf));
             }
         }
-        unlink(filename).unwrap();
+        check!(unlink(filename));
         let read_str = str::from_utf8(read_mem).unwrap();
         assert_eq!(read_str, message);
     })
@@ -762,16 +769,16 @@ mod test {
         let filename = &tmpdir.join("file_rt_io_file_test_seeking.txt");
         {
             let mut rw_stream = File::open_mode(filename, Open, ReadWrite);
-            rw_stream.write(message.as_bytes()).unwrap();
+            check!(rw_stream.write(message.as_bytes()));
         }
         {
             let mut read_stream = File::open_mode(filename, Open, Read);
-            read_stream.seek(set_cursor as i64, SeekSet).unwrap();
-            tell_pos_pre_read = read_stream.tell().unwrap();
-            read_stream.read(read_mem).unwrap();
-            tell_pos_post_read = read_stream.tell().unwrap();
+            check!(read_stream.seek(set_cursor as i64, SeekSet));
+            tell_pos_pre_read = check!(read_stream.tell());
+            check!(read_stream.read(read_mem));
+            tell_pos_post_read = check!(read_stream.tell());
         }
-        unlink(filename).unwrap();
+        check!(unlink(filename));
         let read_str = str::from_utf8(read_mem).unwrap();
         assert_eq!(read_str, message.slice(4, 8));
         assert_eq!(tell_pos_pre_read, set_cursor);
@@ -788,15 +795,15 @@ mod test {
         let filename = &tmpdir.join("file_rt_io_file_test_seek_and_write.txt");
         {
             let mut rw_stream = File::open_mode(filename, Open, ReadWrite);
-            rw_stream.write(initial_msg.as_bytes()).unwrap();
-            rw_stream.seek(seek_idx as i64, SeekSet).unwrap();
-            rw_stream.write(overwrite_msg.as_bytes()).unwrap();
+            check!(rw_stream.write(initial_msg.as_bytes()));
+            check!(rw_stream.seek(seek_idx as i64, SeekSet));
+            check!(rw_stream.write(overwrite_msg.as_bytes()));
         }
         {
             let mut read_stream = File::open_mode(filename, Open, Read);
-            read_stream.read(read_mem).unwrap();
+            check!(read_stream.read(read_mem));
         }
-        unlink(filename).unwrap();
+        check!(unlink(filename));
         let read_str = str::from_utf8(read_mem).unwrap();
         assert!(read_str == final_msg.to_owned());
     })
@@ -812,24 +819,24 @@ mod test {
         let filename = &tmpdir.join("file_rt_io_file_test_seek_shakedown.txt");
         {
             let mut rw_stream = File::open_mode(filename, Open, ReadWrite);
-            rw_stream.write(initial_msg.as_bytes()).unwrap();
+            check!(rw_stream.write(initial_msg.as_bytes()));
         }
         {
             let mut read_stream = File::open_mode(filename, Open, Read);
 
-            read_stream.seek(-4, SeekEnd).unwrap();
-            read_stream.read(read_mem).unwrap();
+            check!(read_stream.seek(-4, SeekEnd));
+            check!(read_stream.read(read_mem));
             assert_eq!(str::from_utf8(read_mem).unwrap(), chunk_three);
 
-            read_stream.seek(-9, SeekCur).unwrap();
-            read_stream.read(read_mem).unwrap();
+            check!(read_stream.seek(-9, SeekCur));
+            check!(read_stream.read(read_mem));
             assert_eq!(str::from_utf8(read_mem).unwrap(), chunk_two);
 
-            read_stream.seek(0, SeekSet).unwrap();
-            read_stream.read(read_mem).unwrap();
+            check!(read_stream.seek(0, SeekSet));
+            check!(read_stream.read(read_mem));
             assert_eq!(str::from_utf8(read_mem).unwrap(), chunk_one);
         }
-        unlink(filename).unwrap();
+        check!(unlink(filename));
     })
 
     iotest!(fn file_test_stat_is_correct_on_is_file() {
@@ -840,34 +847,34 @@ mod test {
             let msg = "hw";
             fs.write(msg.as_bytes()).unwrap();
         }
-        let stat_res = stat(filename).unwrap();
+        let stat_res = check!(stat(filename));
         assert_eq!(stat_res.kind, io::TypeFile);
-        unlink(filename).unwrap();
+        check!(unlink(filename));
     })
 
     iotest!(fn file_test_stat_is_correct_on_is_dir() {
         let tmpdir = tmpdir();
         let filename = &tmpdir.join("file_stat_correct_on_is_dir");
-        mkdir(filename, io::UserRWX).unwrap();
-        let stat_res = filename.stat().unwrap();
+        check!(mkdir(filename, io::UserRWX));
+        let stat_res = check!(filename.stat());
         assert!(stat_res.kind == io::TypeDirectory);
-        rmdir(filename).unwrap();
+        check!(rmdir(filename));
     })
 
     iotest!(fn file_test_fileinfo_false_when_checking_is_file_on_a_directory() {
         let tmpdir = tmpdir();
         let dir = &tmpdir.join("fileinfo_false_on_dir");
-        mkdir(dir, io::UserRWX).unwrap();
+        check!(mkdir(dir, io::UserRWX));
         assert!(dir.is_file() == false);
-        rmdir(dir).unwrap();
+        check!(rmdir(dir));
     })
 
     iotest!(fn file_test_fileinfo_check_exists_before_and_after_file_creation() {
         let tmpdir = tmpdir();
         let file = &tmpdir.join("fileinfo_check_exists_b_and_a.txt");
-        File::create(file).write(bytes!("foo")).unwrap();
+        check!(File::create(file).write(bytes!("foo")));
         assert!(file.exists());
-        unlink(file).unwrap();
+        check!(unlink(file));
         assert!(!file.exists());
     })
 
@@ -875,10 +882,10 @@ mod test {
         let tmpdir = tmpdir();
         let dir = &tmpdir.join("before_and_after_dir");
         assert!(!dir.exists());
-        mkdir(dir, io::UserRWX).unwrap();
+        check!(mkdir(dir, io::UserRWX));
         assert!(dir.exists());
         assert!(dir.is_dir());
-        rmdir(dir).unwrap();
+        check!(rmdir(dir));
         assert!(!dir.exists());
     })
 
@@ -886,21 +893,21 @@ mod test {
         use std::str;
         let tmpdir = tmpdir();
         let dir = &tmpdir.join("di_readdir");
-        mkdir(dir, io::UserRWX).unwrap();
+        check!(mkdir(dir, io::UserRWX));
         let prefix = "foo";
         for n in range(0,3) {
             let f = dir.join(format!("{}.txt", n));
-            let mut w = File::create(&f).unwrap();
+            let mut w = check!(File::create(&f));
             let msg_str = (prefix + n.to_str().to_owned()).to_owned();
             let msg = msg_str.as_bytes();
-            w.write(msg).unwrap();
+            check!(w.write(msg));
         }
-        let files = readdir(dir).unwrap();
+        let files = check!(readdir(dir));
         let mut mem = [0u8, .. 4];
         for f in files.iter() {
             {
                 let n = f.filestem_str();
-                File::open(f).read(mem).unwrap();
+                check!(File::open(f).read(mem));
                 let read_str = str::from_utf8(mem).unwrap();
                 let expected = match n {
                     None|Some("") => fail!("really shouldn't happen.."),
@@ -908,13 +915,13 @@ mod test {
                 };
                 assert_eq!(expected.as_slice(), read_str);
             }
-            unlink(f).unwrap();
+            check!(unlink(f));
         }
-        rmdir(dir).unwrap();
+        check!(rmdir(dir));
     })
 
     iotest!(fn recursive_mkdir_slash() {
-        mkdir_recursive(&Path::new("/"), io::UserRWX).unwrap();
+        check!(mkdir_recursive(&Path::new("/"), io::UserRWX));
     })
 
     iotest!(fn unicode_path_is_dir() {
@@ -925,12 +932,12 @@ mod test {
 
         let mut dirpath = tmpdir.path().clone();
         dirpath.push(format!("test-가一ー你好"));
-        mkdir(&dirpath, io::UserRWX).unwrap();
+        check!(mkdir(&dirpath, io::UserRWX));
         assert!(dirpath.is_dir());
 
         let mut filepath = dirpath;
         filepath.push("unicode-file-\uac00\u4e00\u30fc\u4f60\u597d.rs");
-        File::create(&filepath).unwrap(); // ignore return; touch only
+        check!(File::create(&filepath)); // ignore return; touch only
         assert!(!filepath.is_dir());
         assert!(filepath.exists());
     })
@@ -942,7 +949,7 @@ mod test {
         let tmpdir = tmpdir();
         let unicode = tmpdir.path();
         let unicode = unicode.join(format!("test-각丁ー再见"));
-        mkdir(&unicode, io::UserRWX).unwrap();
+        check!(mkdir(&unicode, io::UserRWX));
         assert!(unicode.exists());
         assert!(!Path::new("test/unicode-bogus-path-각丁ー再见").exists());
     })
@@ -964,19 +971,19 @@ mod test {
         let input = tmpdir.join("in.txt");
         let out = tmpdir.join("out.txt");
 
-        File::create(&input).write(bytes!("hello")).unwrap();
-        copy(&input, &out).unwrap();
-        let contents = File::open(&out).read_to_end().unwrap();
+        check!(File::create(&input).write(bytes!("hello")));
+        check!(copy(&input, &out));
+        let contents = check!(File::open(&out).read_to_end());
         assert_eq!(contents.as_slice(), bytes!("hello"));
 
-        assert_eq!(input.stat().unwrap().perm, out.stat().unwrap().perm);
+        assert_eq!(check!(input.stat()).perm, check!(out.stat()).perm);
     })
 
     iotest!(fn copy_file_dst_dir() {
         let tmpdir = tmpdir();
         let out = tmpdir.join("out");
 
-        File::create(&out).unwrap();
+        check!(File::create(&out));
         match copy(&out, tmpdir.path()) {
             Ok(..) => fail!(), Err(..) => {}
         }
@@ -987,11 +994,11 @@ mod test {
         let input = tmpdir.join("in");
         let output = tmpdir.join("out");
 
-        File::create(&input).write("foo".as_bytes()).unwrap();
-        File::create(&output).write("bar".as_bytes()).unwrap();
-        copy(&input, &output).unwrap();
+        check!(File::create(&input).write("foo".as_bytes()));
+        check!(File::create(&output).write("bar".as_bytes()));
+        check!(copy(&input, &output));
 
-        assert_eq!(File::open(&output).read_to_end().unwrap(),
+        assert_eq!(check!(File::open(&output).read_to_end()),
                    (bytes!("foo")).to_owned());
     })
 
@@ -1010,13 +1017,13 @@ mod test {
         let input = tmpdir.join("in.txt");
         let out = tmpdir.join("out.txt");
 
-        File::create(&input).unwrap();
-        chmod(&input, io::UserRead).unwrap();
-        copy(&input, &out).unwrap();
-        assert!(out.stat().unwrap().perm & io::UserWrite == 0);
+        check!(File::create(&input));
+        check!(chmod(&input, io::UserRead));
+        check!(copy(&input, &out));
+        assert!(check!(out.stat()).perm & io::UserWrite == 0);
 
-        chmod(&input, io::UserFile).unwrap();
-        chmod(&out, io::UserFile).unwrap();
+        check!(chmod(&input, io::UserFile));
+        check!(chmod(&out, io::UserFile));
     })
 
     #[cfg(not(windows))] // FIXME(#10264) operation not permitted?
@@ -1025,13 +1032,13 @@ mod test {
         let input = tmpdir.join("in.txt");
         let out = tmpdir.join("out.txt");
 
-        File::create(&input).write("foobar".as_bytes()).unwrap();
-        symlink(&input, &out).unwrap();
+        check!(File::create(&input).write("foobar".as_bytes()));
+        check!(symlink(&input, &out));
         if cfg!(not(windows)) {
-            assert_eq!(lstat(&out).unwrap().kind, io::TypeSymlink);
+            assert_eq!(check!(lstat(&out)).kind, io::TypeSymlink);
         }
-        assert_eq!(stat(&out).unwrap().size, stat(&input).unwrap().size);
-        assert_eq!(File::open(&out).read_to_end().unwrap(),
+        assert_eq!(check!(stat(&out)).size, check!(stat(&input)).size);
+        assert_eq!(check!(File::open(&out).read_to_end()),
                    (bytes!("foobar")).to_owned());
     })
 
@@ -1039,8 +1046,8 @@ mod test {
     iotest!(fn symlink_noexist() {
         let tmpdir = tmpdir();
         // symlinks can point to things that don't exist
-        symlink(&tmpdir.join("foo"), &tmpdir.join("bar")).unwrap();
-        assert!(readlink(&tmpdir.join("bar")).unwrap() == tmpdir.join("foo"));
+        check!(symlink(&tmpdir.join("foo"), &tmpdir.join("bar")));
+        assert!(check!(readlink(&tmpdir.join("bar"))) == tmpdir.join("foo"));
     })
 
     iotest!(fn readlink_not_symlink() {
@@ -1056,14 +1063,14 @@ mod test {
         let input = tmpdir.join("in.txt");
         let out = tmpdir.join("out.txt");
 
-        File::create(&input).write("foobar".as_bytes()).unwrap();
-        link(&input, &out).unwrap();
+        check!(File::create(&input).write("foobar".as_bytes()));
+        check!(link(&input, &out));
         if cfg!(not(windows)) {
-            assert_eq!(lstat(&out).unwrap().kind, io::TypeFile);
-            assert_eq!(stat(&out).unwrap().unstable.nlink, 2);
+            assert_eq!(check!(lstat(&out)).kind, io::TypeFile);
+            assert_eq!(check!(stat(&out)).unstable.nlink, 2);
         }
-        assert_eq!(stat(&out).unwrap().size, stat(&input).unwrap().size);
-        assert_eq!(File::open(&out).read_to_end().unwrap(),
+        assert_eq!(check!(stat(&out)).size, check!(stat(&input)).size);
+        assert_eq!(check!(File::open(&out).read_to_end()),
                    (bytes!("foobar")).to_owned());
 
         // can't link to yourself
@@ -1082,62 +1089,62 @@ mod test {
         let tmpdir = tmpdir();
         let file = tmpdir.join("in.txt");
 
-        File::create(&file).unwrap();
-        assert!(stat(&file).unwrap().perm & io::UserWrite == io::UserWrite);
-        chmod(&file, io::UserRead).unwrap();
-        assert!(stat(&file).unwrap().perm & io::UserWrite == 0);
+        check!(File::create(&file));
+        assert!(check!(stat(&file)).perm & io::UserWrite == io::UserWrite);
+        check!(chmod(&file, io::UserRead));
+        assert!(check!(stat(&file)).perm & io::UserWrite == 0);
 
         match chmod(&tmpdir.join("foo"), io::UserRWX) {
             Ok(..) => fail!("wanted a failure"),
             Err(..) => {}
         }
 
-        chmod(&file, io::UserFile).unwrap();
+        check!(chmod(&file, io::UserFile));
     })
 
     iotest!(fn sync_doesnt_kill_anything() {
         let tmpdir = tmpdir();
         let path = tmpdir.join("in.txt");
 
-        let mut file = File::open_mode(&path, io::Open, io::ReadWrite).unwrap();
-        file.fsync().unwrap();
-        file.datasync().unwrap();
-        file.write(bytes!("foo")).unwrap();
-        file.fsync().unwrap();
-        file.datasync().unwrap();
+        let mut file = check!(File::open_mode(&path, io::Open, io::ReadWrite));
+        check!(file.fsync());
+        check!(file.datasync());
+        check!(file.write(bytes!("foo")));
+        check!(file.fsync());
+        check!(file.datasync());
         drop(file);
-    } #[ignore(cfg(windows))])
+    })
 
     iotest!(fn truncate_works() {
         let tmpdir = tmpdir();
         let path = tmpdir.join("in.txt");
 
-        let mut file = File::open_mode(&path, io::Open, io::ReadWrite).unwrap();
-        file.write(bytes!("foo")).unwrap();
-        file.fsync().unwrap();
+        let mut file = check!(File::open_mode(&path, io::Open, io::ReadWrite));
+        check!(file.write(bytes!("foo")));
+        check!(file.fsync());
 
         // Do some simple things with truncation
-        assert_eq!(stat(&path).unwrap().size, 3);
-        file.truncate(10).unwrap();
-        assert_eq!(stat(&path).unwrap().size, 10);
-        file.write(bytes!("bar")).unwrap();
-        file.fsync().unwrap();
-        assert_eq!(stat(&path).unwrap().size, 10);
-        assert_eq!(File::open(&path).read_to_end().unwrap(),
+        assert_eq!(check!(stat(&path)).size, 3);
+        check!(file.truncate(10));
+        assert_eq!(check!(stat(&path)).size, 10);
+        check!(file.write(bytes!("bar")));
+        check!(file.fsync());
+        assert_eq!(check!(stat(&path)).size, 10);
+        assert_eq!(check!(File::open(&path).read_to_end()),
                    (bytes!("foobar", 0, 0, 0, 0)).to_owned());
 
         // Truncate to a smaller length, don't seek, and then write something.
         // Ensure that the intermediate zeroes are all filled in (we're seeked
         // past the end of the file).
-        file.truncate(2).unwrap();
-        assert_eq!(stat(&path).unwrap().size, 2);
-        file.write(bytes!("wut")).unwrap();
-        file.fsync().unwrap();
-        assert_eq!(stat(&path).unwrap().size, 9);
-        assert_eq!(File::open(&path).read_to_end().unwrap(),
+        check!(file.truncate(2));
+        assert_eq!(check!(stat(&path)).size, 2);
+        check!(file.write(bytes!("wut")));
+        check!(file.fsync());
+        assert_eq!(check!(stat(&path)).size, 9);
+        assert_eq!(check!(File::open(&path).read_to_end()),
                    (bytes!("fo", 0, 0, 0, 0, "wut")).to_owned());
         drop(file);
-    } #[ignore(cfg(windows))]) // FIXME(#11638)
+    })
 
     iotest!(fn open_flavors() {
         let tmpdir = tmpdir();
@@ -1145,46 +1152,49 @@ mod test {
         match File::open_mode(&tmpdir.join("a"), io::Open, io::Read) {
             Ok(..) => fail!(), Err(..) => {}
         }
-        File::open_mode(&tmpdir.join("b"), io::Open, io::Write).unwrap();
-        File::open_mode(&tmpdir.join("c"), io::Open, io::ReadWrite).unwrap();
-        File::open_mode(&tmpdir.join("d"), io::Append, io::Write).unwrap();
-        File::open_mode(&tmpdir.join("e"), io::Append, io::ReadWrite).unwrap();
-        File::open_mode(&tmpdir.join("f"), io::Truncate, io::Write).unwrap();
-        File::open_mode(&tmpdir.join("g"), io::Truncate, io::ReadWrite).unwrap();
-
-        File::create(&tmpdir.join("h")).write("foo".as_bytes()).unwrap();
-        File::open_mode(&tmpdir.join("h"), io::Open, io::Read).unwrap();
+        check!(File::open_mode(&tmpdir.join("b"), io::Open, io::Write));
+        check!(File::open_mode(&tmpdir.join("c"), io::Open, io::ReadWrite));
+        check!(File::open_mode(&tmpdir.join("d"), io::Append, io::Write));
+        check!(File::open_mode(&tmpdir.join("e"), io::Append, io::ReadWrite));
+        check!(File::open_mode(&tmpdir.join("f"), io::Truncate, io::Write));
+        check!(File::open_mode(&tmpdir.join("g"), io::Truncate, io::ReadWrite));
+
+        check!(File::create(&tmpdir.join("h")).write("foo".as_bytes()));
+        check!(File::open_mode(&tmpdir.join("h"), io::Open, io::Read));
         {
-            let mut f = File::open_mode(&tmpdir.join("h"), io::Open,
-                                        io::Read).unwrap();
+            let mut f = check!(File::open_mode(&tmpdir.join("h"), io::Open,
+                                               io::Read));
             match f.write("wut".as_bytes()) {
                 Ok(..) => fail!(), Err(..) => {}
             }
         }
-        assert_eq!(stat(&tmpdir.join("h")).unwrap().size, 3);
+        assert!(check!(stat(&tmpdir.join("h"))).size == 3,
+                "write/stat failed");
         {
-            let mut f = File::open_mode(&tmpdir.join("h"), io::Append,
-                                        io::Write).unwrap();
-            f.write("bar".as_bytes()).unwrap();
+            let mut f = check!(File::open_mode(&tmpdir.join("h"), io::Append,
+                                               io::Write));
+            check!(f.write("bar".as_bytes()));
         }
-        assert_eq!(stat(&tmpdir.join("h")).unwrap().size, 6);
+        assert!(check!(stat(&tmpdir.join("h"))).size == 6,
+                "append didn't append");
         {
-            let mut f = File::open_mode(&tmpdir.join("h"), io::Truncate,
-                                        io::Write).unwrap();
-            f.write("bar".as_bytes()).unwrap();
+            let mut f = check!(File::open_mode(&tmpdir.join("h"), io::Truncate,
+                                               io::Write));
+            check!(f.write("bar".as_bytes()));
         }
-        assert_eq!(stat(&tmpdir.join("h")).unwrap().size, 3);
+        assert!(check!(stat(&tmpdir.join("h"))).size == 3,
+                "truncate didn't truncate");
     })
 
     #[test]
     fn utime() {
         let tmpdir = tmpdir();
         let path = tmpdir.join("a");
-        File::create(&path).unwrap();
+        check!(File::create(&path));
 
-        change_file_times(&path, 1000, 2000).unwrap();
-        assert_eq!(path.stat().unwrap().accessed, 1000);
-        assert_eq!(path.stat().unwrap().modified, 2000);
+        check!(change_file_times(&path, 1000, 2000));
+        assert_eq!(check!(path.stat()).accessed, 1000);
+        assert_eq!(check!(path.stat()).modified, 2000);
     }
 
     #[test]
@@ -1196,4 +1206,17 @@ mod test {
             Err(..) => {}
         }
     }
+
+    iotest!(fn binary_file() {
+        use rand::{rng, Rng};
+
+        let mut bytes = [0, ..1024];
+        rng().fill_bytes(bytes);
+
+        let tmpdir = tmpdir();
+
+        check!(File::create(&tmpdir.join("test")).write(bytes));
+        let actual = check!(File::open(&tmpdir.join("test")).read_to_end());
+        assert!(actual.as_slice() == bytes);
+    })
 }
diff --git a/src/libstd/io/net/unix.rs b/src/libstd/io/net/unix.rs
index c3e3d72c672..4545fea061b 100644
--- a/src/libstd/io/net/unix.rs
+++ b/src/libstd/io/net/unix.rs
@@ -137,16 +137,20 @@ mod tests {
     pub fn smalltest(server: proc(UnixStream), client: proc(UnixStream)) {
         let path1 = next_test_unix();
         let path2 = path1.clone();
-        let (port, chan) = Chan::new();
+
+        let mut acceptor = UnixListener::bind(&path1).listen();
 
         spawn(proc() {
-            port.recv();
-            client(UnixStream::connect(&path2).unwrap());
+            match UnixStream::connect(&path2) {
+                Ok(c) => client(c),
+                Err(e) => fail!("failed connect: {}", e),
+            }
         });
 
-        let mut acceptor = UnixListener::bind(&path1).listen();
-        chan.send(());
-        server(acceptor.accept().unwrap());
+        match acceptor.accept() {
+            Ok(c) => server(c),
+            Err(e) => fail!("failed accept: {}", e),
+        }
     }
 
     iotest!(fn bind_error() {
diff --git a/src/libstd/io/signal.rs b/src/libstd/io/signal.rs
index 32670fa7c2c..43419c751fc 100644
--- a/src/libstd/io/signal.rs
+++ b/src/libstd/io/signal.rs
@@ -146,22 +146,20 @@ impl Listener {
     }
 }
 
-#[cfg(test)]
-mod test {
+#[cfg(test, unix)]
+mod test_unix {
     use libc;
     use comm::Empty;
     use io::timer;
     use super::{Listener, Interrupt};
 
-    // kill is only available on Unixes
-    #[cfg(unix)]
     fn sigint() {
         unsafe {
             libc::funcs::posix88::signal::kill(libc::getpid(), libc::SIGINT);
         }
     }
 
-    #[test] #[cfg(unix, not(target_os="android"))] // FIXME(#10378)
+    #[test] #[cfg(not(target_os="android"))] // FIXME(#10378)
     fn test_io_signal_smoketest() {
         let mut signal = Listener::new();
         signal.register(Interrupt).unwrap();
@@ -173,7 +171,7 @@ mod test {
         }
     }
 
-    #[test] #[cfg(unix, not(target_os="android"))] // FIXME(#10378)
+    #[test] #[cfg(not(target_os="android"))] // FIXME(#10378)
     fn test_io_signal_two_signal_one_signum() {
         let mut s1 = Listener::new();
         let mut s2 = Listener::new();
@@ -191,7 +189,7 @@ mod test {
         }
     }
 
-    #[test] #[cfg(unix, not(target_os="android"))] // FIXME(#10378)
+    #[test] #[cfg(not(target_os="android"))] // FIXME(#10378)
     fn test_io_signal_unregister() {
         let mut s1 = Listener::new();
         let mut s2 = Listener::new();
@@ -202,15 +200,16 @@ mod test {
         timer::sleep(10);
         assert_eq!(s2.port.try_recv(), Empty);
     }
+}
+
+#[cfg(test, windows)]
+mod test_windows {
+    use super::{User1, Listener};
+    use result::{Ok, Err};
 
-    #[cfg(windows)]
     #[test]
     fn test_io_signal_invalid_signum() {
-        use io;
-        use super::User1;
-        use result::{Ok, Err};
         let mut s = Listener::new();
-        let mut called = false;
         match s.register(User1) {
             Ok(..) => {
                 fail!("Unexpected successful registry of signum {:?}", User1);
diff --git a/src/libstd/libc.rs b/src/libstd/libc.rs
index 73bf4a1e69a..07be753925f 100644
--- a/src/libstd/libc.rs
+++ b/src/libstd/libc.rs
@@ -1623,6 +1623,7 @@ pub mod consts {
             pub static O_NOINHERIT: c_int = 128;
 
             pub static ERROR_SUCCESS : c_int = 0;
+            pub static ERROR_INVALID_FUNCTION: c_int = 1;
             pub static ERROR_FILE_NOT_FOUND: c_int = 2;
             pub static ERROR_ACCESS_DENIED: c_int = 5;
             pub static ERROR_INVALID_HANDLE : c_int = 6;
@@ -1745,6 +1746,10 @@ pub mod consts {
             pub static OPEN_EXISTING: DWORD = 3;
             pub static TRUNCATE_EXISTING: DWORD = 5;
 
+            pub static FILE_APPEND_DATA: DWORD = 0x00000004;
+            pub static FILE_READ_DATA: DWORD = 0x00000001;
+            pub static FILE_WRITE_DATA: DWORD = 0x00000002;
+
             pub static FILE_ATTRIBUTE_ARCHIVE: DWORD = 0x20;
             pub static FILE_ATTRIBUTE_COMPRESSED: DWORD = 0x800;
             pub static FILE_ATTRIBUTE_DEVICE: DWORD = 0x40;
@@ -1791,6 +1796,18 @@ pub mod consts {
             pub static FILE_WRITE_ATTRIBUTES: DWORD = 0x00000100;
             pub static FILE_READ_ATTRIBUTES: DWORD = 0x00000080;
 
+            pub static STANDARD_RIGHTS_READ: DWORD = 0x20000;
+            pub static STANDARD_RIGHTS_WRITE: DWORD = 0x20000;
+            pub static FILE_WRITE_EA: DWORD = 0x00000010;
+            pub static FILE_READ_EA: DWORD = 0x00000008;
+            pub static FILE_GENERIC_READ: DWORD =
+                STANDARD_RIGHTS_READ | FILE_READ_DATA |
+                FILE_READ_ATTRIBUTES | FILE_READ_EA | SYNCHRONIZE;
+            pub static FILE_GENERIC_WRITE: DWORD =
+                STANDARD_RIGHTS_WRITE | FILE_WRITE_DATA |
+                FILE_WRITE_ATTRIBUTES | FILE_WRITE_EA | FILE_APPEND_DATA |
+                SYNCHRONIZE;
+
             pub static FILE_BEGIN: DWORD = 0;
             pub static FILE_CURRENT: DWORD = 1;
             pub static FILE_END: DWORD = 2;
@@ -4231,6 +4248,7 @@ pub mod funcs {
 
         pub mod msvcrt {
             use libc::types::os::arch::c95::{c_int, c_long};
+            use libc::types::os::arch::c99::intptr_t;
 
             #[nolink]
             extern {
@@ -4239,6 +4257,10 @@ pub mod funcs {
 
                 #[link_name = "_get_osfhandle"]
                 pub fn get_osfhandle(fd: c_int) -> c_long;
+
+                #[link_name = "_open_osfhandle"]
+                pub fn open_osfhandle(osfhandle: intptr_t,
+                                      flags: c_int) -> c_int;
             }
         }
     }
diff --git a/src/libstd/path/posix.rs b/src/libstd/path/posix.rs
index d1af612e0ec..a8f7782fa46 100644
--- a/src/libstd/path/posix.rs
+++ b/src/libstd/path/posix.rs
@@ -698,8 +698,8 @@ mod tests {
         macro_rules! t(
             (s: $path:expr, $join:expr) => (
                 {
-                    let path = ($path);
-                    let join = ($join);
+                    let path = $path;
+                    let join = $join;
                     let mut p1 = Path::new(path);
                     let p2 = p1.clone();
                     p1.push(join);
diff --git a/src/libstd/path/windows.rs b/src/libstd/path/windows.rs
index 8902ab2edd7..10834aec64c 100644
--- a/src/libstd/path/windows.rs
+++ b/src/libstd/path/windows.rs
@@ -1433,8 +1433,8 @@ mod tests {
         macro_rules! t(
             (s: $path:expr, $join:expr) => (
                 {
-                    let path = ($path);
-                    let join = ($join);
+                    let path = $path;
+                    let join = $join;
                     let mut p1 = Path::new(path);
                     let p2 = p1.clone();
                     p1.push(join);
diff --git a/src/libstd/unstable/dynamic_lib.rs b/src/libstd/unstable/dynamic_lib.rs
index 84fa528ebf1..57dbc045a65 100644
--- a/src/libstd/unstable/dynamic_lib.rs
+++ b/src/libstd/unstable/dynamic_lib.rs
@@ -82,9 +82,7 @@ impl DynamicLibrary {
 #[cfg(test)]
 mod test {
     use super::*;
-    use option::*;
-    use result::*;
-    use path::*;
+    use prelude::*;
     use libc;
 
     #[test]
diff --git a/src/libstd/vec.rs b/src/libstd/vec.rs
index cf49ea53562..ce719c6d0b8 100644
--- a/src/libstd/vec.rs
+++ b/src/libstd/vec.rs
@@ -3529,7 +3529,7 @@ mod tests {
         let mut v: [uint, .. 0] = [];
         v.sort();
 
-        let mut v = [0xDEADBEEF];
+        let mut v = [0xDEADBEEFu];
         v.sort();
         assert_eq!(v, [0xDEADBEEF]);
     }