about summary refs log tree commit diff
path: root/src/libsyntax/parse/lexer
diff options
context:
space:
mode:
authorBrian Anderson <banderson@mozilla.com>2014-06-19 18:22:33 -0700
committerBrian Anderson <banderson@mozilla.com>2014-07-01 19:12:29 -0700
commitd21336ee0a3982bdc35f17cdc32b41f6de5603d4 (patch)
tree3f048e797533182728deab7c40618ce2635b9bdc /src/libsyntax/parse/lexer
parent44ec28cfac9fa3f738e0e77ccca1d804125fd1dd (diff)
downloadrust-d21336ee0a3982bdc35f17cdc32b41f6de5603d4.tar.gz
rust-d21336ee0a3982bdc35f17cdc32b41f6de5603d4.zip
rustc: Remove `&str` indexing from the language.
Being able to index into the bytes of a string encourages
poor UTF-8 hygiene. To get a view of `&[u8]` from either
a `String` or `&str` slice, use the `as_bytes()` method.

Closes #12710.

[breaking-change]
Diffstat (limited to 'src/libsyntax/parse/lexer')
-rw-r--r--src/libsyntax/parse/lexer/mod.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libsyntax/parse/lexer/mod.rs b/src/libsyntax/parse/lexer/mod.rs
index ac570c88837..0f188fdf18a 100644
--- a/src/libsyntax/parse/lexer/mod.rs
+++ b/src/libsyntax/parse/lexer/mod.rs
@@ -1203,8 +1203,8 @@ impl<'a> StringReader<'a> {
 
     fn read_one_line_comment(&mut self) -> String {
         let val = self.read_to_eol();
-        assert!((val.as_slice()[0] == '/' as u8 && val.as_slice()[1] == '/' as u8)
-             || (val.as_slice()[0] == '#' as u8 && val.as_slice()[1] == '!' as u8));
+        assert!((val.as_bytes()[0] == '/' as u8 && val.as_bytes()[1] == '/' as u8)
+             || (val.as_bytes()[0] == '#' as u8 && val.as_bytes()[1] == '!' as u8));
         return val;
     }