diff options
| author | bors <bors@rust-lang.org> | 2017-07-31 20:47:42 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2017-07-31 20:47:42 +0000 |
| commit | 37c7d0ebb3ec5b62bd37df9ee8826194e3c6300a (patch) | |
| tree | e4f9fd14238ef8bc56860caf3a01825306a546c7 /src/libsyntax/parse/mod.rs | |
| parent | 2a6828e7f1ed3163a2797f0a111570ef130f7b6b (diff) | |
| parent | 8f67f1efaf792a0c3ef629e1e62e53eba7365a1c (diff) | |
| download | rust-37c7d0ebb3ec5b62bd37df9ee8826194e3c6300a.tar.gz rust-37c7d0ebb3ec5b62bd37df9ee8826194e3c6300a.zip | |
Auto merge of #43399 - tschottdorf:bndmode-pat-adjustments, r=nikomatsakis
default binding modes: add pat_binding_modes This PR kicks off the implementation of the [default binding modes RFC][1] by introducing the `pat_binding_modes` typeck table mentioned in the [mentoring instructions][2]. It is a WIP because I wasn't able to avoid all uses of the binding modes as not all call sites are close enough to the typeck tables. I added marker comments to any line matching `BindByRef|BindByValue` so that reviewers are aware of all of them. I will look into changing the HIR (as suggested in [2]) to not carry a `BindingMode` unless one was explicitly specified, but this PR is good for a first round of comments. The actual changes are quite small and CI will fail due to overlong lines caused by the marker comments. See #42640. cc @nikomatsakis [1]: https://github.com/rust-lang/rfcs/pull/2005 [2]: https://github.com/rust-lang/rust/issues/42640#issuecomment-313535089
Diffstat (limited to 'src/libsyntax/parse/mod.rs')
| -rw-r--r-- | src/libsyntax/parse/mod.rs | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/src/libsyntax/parse/mod.rs b/src/libsyntax/parse/mod.rs index 7b105a8fa14..893bada2670 100644 --- a/src/libsyntax/parse/mod.rs +++ b/src/libsyntax/parse/mod.rs @@ -867,13 +867,14 @@ mod tests { pat: P(ast::Pat { id: ast::DUMMY_NODE_ID, node: PatKind::Ident( - ast::BindingMode::ByValue(ast::Mutability::Immutable), - Spanned{ - span: sp(6,7), - node: Ident::from_str("b")}, - None - ), - span: sp(6,7) + ast::BindingMode::ByValue( + ast::Mutability::Immutable), + Spanned{ + span: sp(6,7), + node: Ident::from_str("b")}, + None + ), + span: sp(6,7) }), id: ast::DUMMY_NODE_ID }], |