diff options
| author | bors <bors@rust-lang.org> | 2014-08-05 17:21:23 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2014-08-05 17:21:23 +0000 |
| commit | 6da38890f1f734799dc06460edf26c560db59a8e (patch) | |
| tree | 5dea8a018e59172d058fea6963c40453c2bcb5b2 /src/libsyntax/parse/parser.rs | |
| parent | ce83301f8c64f77c876ecfed65962b7dc407f093 (diff) | |
| parent | 0dc215741b34236c310e409c437600ba0165c97c (diff) | |
| download | rust-6da38890f1f734799dc06460edf26c560db59a8e.tar.gz rust-6da38890f1f734799dc06460edf26c560db59a8e.zip | |
auto merge of #15709 : hirschenberger/rust/issue-14269, r=cmr
Fixes missing overflow lint for i64 #14269 The `type_overflow` lint, doesn't catch the overflow for `i64` because the overflow happens earlier in the parse phase when the `u64` as biggest possible int gets casted to `i64` , without checking the for overflows. We can't lint in the parse phase, so we emit a compiler error, as we do for overflowing `u64` Perhaps a consistent behaviour would be to emit a parse error for *all* overflowing integer types. See #14269
Diffstat (limited to 'src/libsyntax/parse/parser.rs')
| -rw-r--r-- | src/libsyntax/parse/parser.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index de3be4f8f38..18b1d60d4e9 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -34,7 +34,7 @@ use ast::{Ident, NormalFn, Inherited, Item, Item_, ItemStatic}; use ast::{ItemEnum, ItemFn, ItemForeignMod, ItemImpl}; use ast::{ItemMac, ItemMod, ItemStruct, ItemTrait, ItemTy, Lit, Lit_}; use ast::{LitBool, LitChar, LitByte, LitBinary}; -use ast::{LitNil, LitStr, LitUint, Local, LocalLet}; +use ast::{LitNil, LitStr, LitInt, Local, LocalLet}; use ast::{MutImmutable, MutMutable, Mac_, MacInvocTT, Matcher, MatchNonterminal}; use ast::{MatchSeq, MatchTok, Method, MutTy, BiMul, Mutability}; use ast::{NamedField, UnNeg, NoReturn, UnNot, P, Pat, PatEnum}; @@ -1889,7 +1889,7 @@ impl<'a> Parser<'a> { pub fn mk_lit_u32(&mut self, i: u32) -> Gc<Expr> { let span = &self.span; let lv_lit = box(GC) codemap::Spanned { - node: LitUint(i as u64, TyU32), + node: LitInt(i as u64, ast::UnsignedIntLit(TyU32)), span: *span }; |
