diff options
| author | David Wood <david@davidtw.co> | 2019-01-23 16:42:23 +0100 |
|---|---|---|
| committer | David Wood <david@davidtw.co> | 2019-01-23 23:40:58 +0100 |
| commit | f14d007ee4f4b69cdb3880db49608b432bea8352 (patch) | |
| tree | 27ef324230f40d7507ee14cd1c6268d4f3e12713 /src/libsyntax/parse/parser.rs | |
| parent | 6bba352cad2117f56353d400f71e96eafa2e6bd7 (diff) | |
| download | rust-f14d007ee4f4b69cdb3880db49608b432bea8352.tar.gz rust-f14d007ee4f4b69cdb3880db49608b432bea8352.zip | |
Add suggestion for incorrect field syntax.
This commit adds a suggestion when a `=` character is used when specifying the value of a field in a struct constructor incorrectly instead of a `:` character.
Diffstat (limited to 'src/libsyntax/parse/parser.rs')
| -rw-r--r-- | src/libsyntax/parse/parser.rs | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index 09ea0995253..b9c602550e3 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -2263,8 +2263,24 @@ impl<'a> Parser<'a> { let lo = self.span; // Check if a colon exists one ahead. This means we're parsing a fieldname. - let (fieldname, expr, is_shorthand) = if self.look_ahead(1, |t| t == &token::Colon) { + let (fieldname, expr, is_shorthand) = if self.look_ahead(1, |t| { + t == &token::Colon || t == &token::Eq + }) { let fieldname = self.parse_field_name()?; + + // Check for an equals token. This means the source incorrectly attempts to + // initialize a field with an eq rather than a colon. + if self.token == token::Eq { + self.diagnostic() + .struct_span_err(self.span, "expected `:`, found `=`") + .span_suggestion_with_applicability( + fieldname.span.shrink_to_hi().to(self.span), + "replace equals symbol with a colon", + ":".to_string(), + Applicability::MachineApplicable, + ) + .emit(); + } self.bump(); // `:` (fieldname, self.parse_expr()?, false) } else { |
