diff options
| author | Mazdak Farrokhzad <twingoow@gmail.com> | 2019-08-03 00:09:07 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-08-03 00:09:07 +0200 |
| commit | 726f39a2585ede14c4e75ac440293fb556d49af5 (patch) | |
| tree | c4519bcb33d61336ba151cbddc47b83d221197c6 /src/libsyntax/parse/parser | |
| parent | edc846f29eac8a45555f19a9fd951ed414398776 (diff) | |
| parent | 30f61dec30c01c260587760770da83b29d9cce6a (diff) | |
| download | rust-726f39a2585ede14c4e75ac440293fb556d49af5.tar.gz rust-726f39a2585ede14c4e75ac440293fb556d49af5.zip | |
Rollup merge of #63196 - RalfJung:build_helper, r=alexcrichton
build_helper: try less confusing method names build_helper's `*_silent` methods were likely called that way because they do not print the command being run to stdout. [In the original file this all makes sense](https://github.com/rust-lang/rust/commit/046e6874c47ec55e23b7a566bca51d2920562485#diff-5c3d6537a43ecae03014e118a7fe3321). But later it also gained `*_suppressed` methods and the difference between `silent` and `suppressed` is far from clear. So rename `run` (which prints the command being run) to `run_verbose`. Then we can call the methods that just run a command and show its output but nothing extra `run` and `try_run`. `run_verbose` (formerly `run`) is unused from what I can tell. Should I remove it? r? @alexcrichton Cc @Mark-Simulacrum Also see https://github.com/rust-lang/rust/pull/63089#discussion_r308018890.
Diffstat (limited to 'src/libsyntax/parse/parser')
0 files changed, 0 insertions, 0 deletions