diff options
| author | bors <bors@rust-lang.org> | 2015-10-29 06:56:52 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2015-10-29 06:56:52 +0000 |
| commit | 2af9aabf3adb49f208bfae0351a143df599fb553 (patch) | |
| tree | b9cc05f2b783441beaa5932ed0a413238556e3f9 /src/libsyntax/parse | |
| parent | 3896a005360fe818bef89c26ea1204597be6ae03 (diff) | |
| parent | 99ecf4e2c94a72a68294111ecdf6a82c150c378a (diff) | |
| download | rust-2af9aabf3adb49f208bfae0351a143df599fb553.tar.gz rust-2af9aabf3adb49f208bfae0351a143df599fb553.zip | |
Auto merge of #29441 - Ryman:match_refactor_msg, r=alexcrichton
This helps for the case where a match, such as below:
```rust
let foo = match foo {
Some(x) => x,
None => 0
};
```
gets refactored to no longer need the match, but the match keyword has been left accidentally:
```rust
let foo = match foo.unwrap_or(0);
```
This can be hard to spot as the expression grows more complex.
r? @alexcrichton
Diffstat (limited to 'src/libsyntax/parse')
| -rw-r--r-- | src/libsyntax/parse/parser.rs | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index 6cee7b86a61..d1fc8ac2002 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -2941,9 +2941,15 @@ impl<'a> Parser<'a> { } fn parse_match_expr(&mut self) -> PResult<P<Expr>> { + let match_span = self.last_span; let lo = self.last_span.lo; let discriminant = try!(self.parse_expr_res(Restrictions::RESTRICTION_NO_STRUCT_LITERAL)); - try!(self.commit_expr_expecting(&*discriminant, token::OpenDelim(token::Brace))); + if let Err(e) = self.commit_expr_expecting(&*discriminant, token::OpenDelim(token::Brace)) { + if self.token == token::Token::Semi { + self.span_note(match_span, "did you mean to remove this `match` keyword?"); + } + return Err(e) + } let mut arms: Vec<Arm> = Vec::new(); while self.token != token::CloseDelim(token::Brace) { arms.push(try!(self.parse_arm_nopanic())); |
