diff options
| author | Graydon Hoare <graydon@mozilla.com> | 2012-06-21 16:44:10 -0700 |
|---|---|---|
| committer | Graydon Hoare <graydon@mozilla.com> | 2012-06-21 16:44:10 -0700 |
| commit | 312faf31dfcce7a2d15495c5042d80a3e3b476c9 (patch) | |
| tree | 4ad8383191907b5cb148291a2d1dbc078f590eb6 /src/libsyntax/parse | |
| parent | 57101780811490fa759ed1dca310c405d28c0a72 (diff) | |
| download | rust-312faf31dfcce7a2d15495c5042d80a3e3b476c9.tar.gz rust-312faf31dfcce7a2d15495c5042d80a3e3b476c9.zip | |
Tag all remaining FIXMEs with bugs. Install rule in tidy script to enforce this.
Diffstat (limited to 'src/libsyntax/parse')
| -rw-r--r-- | src/libsyntax/parse/common.rs | 4 | ||||
| -rw-r--r-- | src/libsyntax/parse/eval.rs | 4 | ||||
| -rw-r--r-- | src/libsyntax/parse/lexer.rs | 6 | ||||
| -rw-r--r-- | src/libsyntax/parse/parser.rs | 20 |
4 files changed, 17 insertions, 17 deletions
diff --git a/src/libsyntax/parse/common.rs b/src/libsyntax/parse/common.rs index b8362eb8734..52cb9366df8 100644 --- a/src/libsyntax/parse/common.rs +++ b/src/libsyntax/parse/common.rs @@ -93,8 +93,8 @@ impl parser_common for parser { fn eat_keyword(word: str) -> bool { self.require_keyword(word); - // FIXME: this gratuitous use of @ is to - // workaround LLVM bug #13042 + // FIXME (#13042): this gratuitous use of @ is to + // workaround LLVM bug. alt @self.token { @token::IDENT(sid, false) { if str::eq(word, *self.get_str(sid)) { diff --git a/src/libsyntax/parse/eval.rs b/src/libsyntax/parse/eval.rs index 5ef8417ec6f..ae11c883443 100644 --- a/src/libsyntax/parse/eval.rs +++ b/src/libsyntax/parse/eval.rs @@ -103,7 +103,7 @@ fn eval_crate_directive(cx: ctx, cdir: @ast::crate_directive, prefix: str, let m0 = p0.parse_mod_items(token::EOF, first_item_outer_attrs); let i = p0.mk_item(cdir.span.lo, cdir.span.hi, - /* FIXME: bad */ copy id, + /* FIXME (#2543) */ copy id, ast::item_mod(m0), ast::public, mod_attrs); // Thread defids, chpos and byte_pos through the parsers cx.sess.chpos = r0.chpos; @@ -119,7 +119,7 @@ fn eval_crate_directive(cx: ctx, cdir: @ast::crate_directive, prefix: str, let (m0, a0) = eval_crate_directives_to_mod( cx, cdirs, full_path, none); let i = - @{ident: /* FIXME: bad */ copy id, + @{ident: /* FIXME (#2543) */ copy id, attrs: attrs + a0, id: cx.sess.next_id, node: ast::item_mod(m0), diff --git a/src/libsyntax/parse/lexer.rs b/src/libsyntax/parse/lexer.rs index bbf5330c18a..02b34e8dc86 100644 --- a/src/libsyntax/parse/lexer.rs +++ b/src/libsyntax/parse/lexer.rs @@ -414,9 +414,9 @@ fn scan_number(c: char, rdr: string_reader) -> token::token { bump(rdr); ret token::LIT_FLOAT(intern(*rdr.interner, @num_str), ast::ty_f64); - /* FIXME: if this is out of range for either a 32-bit or - 64-bit float, it won't be noticed till the back-end (Issue #2252) - */ + /* FIXME (#2252): if this is out of range for either a + 32-bit or 64-bit float, it won't be noticed till the + back-end. */ } else { is_float = true; } diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index 146c3ab3de9..46e838fd4be 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -17,10 +17,10 @@ import dvec::{dvec, extensions}; export file_type; export parser; -// FIXME: #ast expects to find this here but it's actually defined in `parse` -// Fixing this will be easier when we have export decls on individual items -- -// then parse can export this publicly, and everything else crate-visibly. -// (See #1893) +// FIXME (#1893): #ast expects to find this here but it's actually +// defined in `parse` Fixing this will be easier when we have export +// decls on individual items -- then parse can export this publicly, and +// everything else crate-visibly. import parse_from_source_str; export parse_from_source_str; @@ -172,10 +172,10 @@ class parser { {mode: mode, ty: p.parse_ty(false), ident: name, id: p.get_id()} }; - // FIXME: constrs is empty because right now, higher-order functions - // can't have constrained types. - // Not sure whether that would be desirable anyway. See #34 for the - // story on constrained types. + // FIXME (#34): constrs is empty because right now, higher-order + // functions can't have constrained types. Not sure whether + // that would be desirable anyway. See bug for the story on + // constrained types. let constrs: [@constr] = []; let (ret_style, ret_ty) = self.parse_ret_ty(); ret {inputs: inputs, output: ret_ty, @@ -2039,7 +2039,7 @@ class parser { } fn parse_ctor(result_ty: ast::ty_) -> class_contents { - // Can ctors/dtors have attrs? FIXME + // FIXME (#2660): Can ctors/dtors have attrs? let lo = self.last_span.lo; let (decl_, _) = self.parse_fn_decl(impure_fn, {|p| p.parse_arg()}); let decl = {output: @{id: self.get_id(), @@ -2050,7 +2050,7 @@ class parser { } fn parse_dtor() -> class_contents { - // Can ctors/dtors have attrs? FIXME + // FIXME (#2660): Can ctors/dtors have attrs? let lo = self.last_span.lo; let body = self.parse_block(); dtor_decl(body, mk_sp(lo, self.last_span.hi)) |
