diff options
| author | bors <bors@rust-lang.org> | 2016-03-04 06:55:11 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2016-03-04 06:55:11 +0000 |
| commit | 5b5e52186917502258a9feadc8bf77a89183386b (patch) | |
| tree | bd2159a81a0d3e7cbb81c6466b9df26292424a32 /src/libsyntax/parse | |
| parent | 8e261d12e3fcd6700b368d449ada4d10ebbf17f8 (diff) | |
| parent | e2aa90e780eb4d6a27626f7d93ae3d6b567734a7 (diff) | |
| download | rust-5b5e52186917502258a9feadc8bf77a89183386b.tar.gz rust-5b5e52186917502258a9feadc8bf77a89183386b.zip | |
Auto merge of #32006 - jseyfried:fix_expanded_mod_path, r=nikomatsakis
This PR changes the search paths for macro-expanded non-inline modules so that they match ordinary non-inline modules (fixes #31624). This is a [breaking-change].
Right now, the search paths for a macro-expanded non-inline module are computed as if the module were declared in the top level of the file in which the macro was defined.
For example, consider `./foo/mod.rs`:
```rust
mod inconsequential { // moving the macro outside this module wouldn't change anything
macro_rules! mod_decl {
($i:ident) => { mod $i; }
}
}
```
and `./lib.rs`:
```rust
mod foo;
mod bar {
mod_decl!(baz);
//^ Now, rustc expects `./foo/baz.rs` (or `./foo/baz/mod.rs`)
//| After this PR, rustc will expect `./bar/baz.rs` (or `./bar/baz/mod.rs`)
}
```
r? @alexcrichton
Diffstat (limited to 'src/libsyntax/parse')
| -rw-r--r-- | src/libsyntax/parse/parser.rs | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index b5d29a0d6db..e166a367219 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -273,6 +273,7 @@ pub struct Parser<'a> { /// extra detail when the same error is seen twice pub obsolete_set: HashSet<ObsoleteSyntax>, /// Used to determine the path to externally loaded source files + pub filename: Option<String>, pub mod_path_stack: Vec<InternedString>, /// Stack of spans of open delimiters. Used for error message. pub open_braces: Vec<Span>, @@ -354,6 +355,9 @@ impl<'a> Parser<'a> { { let tok0 = rdr.real_token(); let span = tok0.sp; + let filename = if span != codemap::DUMMY_SP { + Some(sess.codemap().span_to_filename(span)) + } else { None }; let placeholder = TokenAndSpan { tok: token::Underscore, sp: span, @@ -382,6 +386,7 @@ impl<'a> Parser<'a> { quote_depth: 0, obsolete_set: HashSet::new(), mod_path_stack: Vec::new(), + filename: filename, open_braces: Vec::new(), owns_directory: true, root_module_name: None, @@ -5325,7 +5330,7 @@ impl<'a> Parser<'a> { id: ast::Ident, outer_attrs: &[ast::Attribute], id_sp: Span) -> PResult<'a, ModulePathSuccess> { - let mut prefix = PathBuf::from(&self.sess.codemap().span_to_filename(self.span)); + let mut prefix = PathBuf::from(self.filename.as_ref().unwrap()); prefix.pop(); let mut dir_path = prefix; for part in &self.mod_path_stack { |
