diff options
| author | kennytm <kennytm@gmail.com> | 2018-05-23 00:26:13 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-05-23 00:26:13 +0800 |
| commit | 696b84c88394d16a4fb43bd667945f07bea2e666 (patch) | |
| tree | 9585fe6cd06be0de4c65e6c762ba6d096cb7a64f /src/libsyntax/parse | |
| parent | e51b35e26fcc57f5bbe591556a2cebc780caf58e (diff) | |
| parent | e6bf3e2ddbfc7907cdf5f3eef0eee4b610200e4b (diff) | |
| download | rust-696b84c88394d16a4fb43bd667945f07bea2e666.tar.gz rust-696b84c88394d16a4fb43bd667945f07bea2e666.zip | |
Rollup merge of #50914 - simartin:issue_50636, r=oli-obk
Issue #50636: Improve error diagnostic with missing commas after struct fields. Fixes #50636
Diffstat (limited to 'src/libsyntax/parse')
| -rw-r--r-- | src/libsyntax/parse/parser.rs | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index 729ad491fd5..62d007b4240 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -5807,9 +5807,18 @@ impl<'a> Parser<'a> { return Err(err); } } - _ => return Err(self.span_fatal_help(self.span, - &format!("expected `,`, or `}}`, found `{}`", self.this_token_to_string()), - "struct fields should be separated by commas")), + _ => { + let sp = self.sess.codemap().next_point(self.prev_span); + let mut err = self.struct_span_err(sp, &format!("expected `,`, or `}}`, found `{}`", + self.this_token_to_string())); + if self.token.is_ident() { + // This is likely another field; emit the diagnostic and keep going + err.span_suggestion(sp, "try adding a comma", ",".into()); + err.emit(); + } else { + return Err(err) + } + } } Ok(a_var) } |
