about summary refs log tree commit diff
path: root/src/libsyntax/parse
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2014-09-21 01:00:29 +0000
committerbors <bors@rust-lang.org>2014-09-21 01:00:29 +0000
commitd7e1bb5ff4622694d48905e944c1cf9bea7a5da7 (patch)
tree6b10e1f32458e58f31c294b6b5bd640505c1a219 /src/libsyntax/parse
parent9c39b6c564745d4e316c16b6b8bf04675520253b (diff)
parent3514737b4cf1d91dc8c7b61c95f2f20d3b386d1c (diff)
downloadrust-d7e1bb5ff4622694d48905e944c1cf9bea7a5da7.tar.gz
rust-d7e1bb5ff4622694d48905e944c1cf9bea7a5da7.zip
auto merge of #17415 : jakub-/rust/issue-17383, r=huonw
Fixes #17383.
Diffstat (limited to 'src/libsyntax/parse')
-rw-r--r--src/libsyntax/parse/parser.rs12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs
index a5aa249738d..1ff6c3f9418 100644
--- a/src/libsyntax/parse/parser.rs
+++ b/src/libsyntax/parse/parser.rs
@@ -5069,7 +5069,7 @@ impl<'a> Parser<'a> {
     fn parse_enum_def(&mut self, _generics: &ast::Generics) -> EnumDef {
         let mut variants = Vec::new();
         let mut all_nullary = true;
-        let mut have_disr = false;
+        let mut any_disr = None;
         while self.token != token::RBRACE {
             let variant_attrs = self.parse_outer_attributes();
             let vlo = self.span.lo;
@@ -5101,8 +5101,8 @@ impl<'a> Parser<'a> {
                 }
                 kind = TupleVariantKind(args);
             } else if self.eat(&token::EQ) {
-                have_disr = true;
                 disr_expr = Some(self.parse_expr());
+                any_disr = disr_expr.as_ref().map(|expr| expr.span);
                 kind = TupleVariantKind(args);
             } else {
                 kind = TupleVariantKind(Vec::new());
@@ -5121,9 +5121,11 @@ impl<'a> Parser<'a> {
             if !self.eat(&token::COMMA) { break; }
         }
         self.expect(&token::RBRACE);
-        if have_disr && !all_nullary {
-            self.fatal("discriminator values can only be used with a c-like \
-                        enum");
+        match any_disr {
+            Some(disr_span) if !all_nullary =>
+                self.span_err(disr_span,
+                    "discriminator values can only be used with a c-like enum"),
+            _ => ()
         }
 
         ast::EnumDef { variants: variants }