make vec fns/methods take imm slices.

this also repairs the unsoundness in typing of unpack_slice,
which was silently converting a const ptr to an imm one.

1 files changed, 2 insertions, 7 deletions

diff --git a/src/libsyntax/attr.rs b/src/libsyntax/attr.rs
index 77423a993d4..f9393890f3c 100644
--- a/src/libsyntax/attr.rs
+++ b/src/libsyntax/attr.rs
@@ -272,14 +272,9 @@ fn sort_meta_items(items: [@ast::meta_item]) -> [@ast::meta_item] {
     }
 
     // This is sort of stupid here, converting to a vec of mutables and back
-    let mut v: [mut @ast::meta_item] = [mut];
-    for items.each {|mi| v += [mut mi]; }
-
+    let v: [mut @ast::meta_item] = vec::to_mut(items);
     std::sort::quick_sort(lteq, v);
-
-    let mut v2: [@ast::meta_item] = [];
-    for v.each {|mi| v2 += [mi]; }
-    ret v2;
+    ret vec::from_mut(v);
 }
 
 fn remove_meta_items_by_name(items: [@ast::meta_item], name: str) ->