diff options
| author | Huon Wilson <dbau.pp+github@gmail.com> | 2013-06-13 23:16:30 +1000 |
|---|---|---|
| committer | Huon Wilson <dbau.pp+github@gmail.com> | 2013-06-14 11:12:06 +1000 |
| commit | f93a974558bf09bee475427158150ba6e008cdd8 (patch) | |
| tree | b33c58f8819e4a85af750404e40b453aac5f2b3e /src/libsyntax | |
| parent | b417bc8511a0a38e73312cee8086ed04eeb21b75 (diff) | |
| download | rust-f93a974558bf09bee475427158150ba6e008cdd8.tar.gz rust-f93a974558bf09bee475427158150ba6e008cdd8.zip | |
syntax: correct the Rand::rand call to select enum variants in #[deriving(Rand)].
Previously, this was not a global call, and so when `#[deriving(Rand)]` was in any module other than the top-level one, it failed (unless there was a `use std;` in scope). Also, fix a minor inconsistency between uints and u32s for this piece of code.
Diffstat (limited to 'src/libsyntax')
| -rw-r--r-- | src/libsyntax/ext/deriving/rand.rs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/libsyntax/ext/deriving/rand.rs b/src/libsyntax/ext/deriving/rand.rs index ab5ac6d7847..79aa3469f74 100644 --- a/src/libsyntax/ext/deriving/rand.rs +++ b/src/libsyntax/ext/deriving/rand.rs @@ -78,19 +78,20 @@ fn rand_substructure(cx: @ExtCtxt, span: span, substr: &Substructure) -> @expr { let variant_count = cx.expr_uint(span, variants.len()); - // need to specify the uint-ness of the random number - let u32_ty = cx.ty_ident(span, cx.ident_of("uint")); + // need to specify the u32-ness of the random number + let u32_ty = cx.ty_ident(span, cx.ident_of("u32")); let r_ty = cx.ty_ident(span, cx.ident_of("R")); - let rand_name = cx.path_all(span, false, copy rand_ident, None, ~[ u32_ty, r_ty ]); + let rand_name = cx.path_all(span, true, copy rand_ident, None, ~[ u32_ty, r_ty ]); let rand_name = cx.expr_path(rand_name); + // ::std::rand::Rand::rand::<u32>(rng) let rv_call = cx.expr_call(span, rand_name, ~[ rng[0].duplicate(cx) ]); // rand() % variants.len() let rand_variant = cx.expr_binary(span, ast::rem, - rv_call, variant_count); + rv_call, variant_count); let mut arms = do variants.mapi |i, id_sum| { let i_expr = cx.expr_uint(span, i); |
