diff options
| author | Vadim Chugunov <vadimcn@gmail.com> | 2014-10-06 23:15:12 -0700 |
|---|---|---|
| committer | Vadim Chugunov <vadimcn@gmail.com> | 2014-10-07 02:13:05 -0700 |
| commit | fc60797f7f3079288bdd1717dedbb885eaf1dbfa (patch) | |
| tree | 21306daa9579c113d1609afa78c521e7cc1479e9 /src/libsyntax | |
| parent | e62ef37cfae680e60584731635a89e955121a5bb (diff) | |
| download | rust-fc60797f7f3079288bdd1717dedbb885eaf1dbfa.tar.gz rust-fc60797f7f3079288bdd1717dedbb885eaf1dbfa.zip | |
Fix the most egregious instances of "local ambiguity: multiple parsing options..." error in macros, which often occurs when trying to match parts of Rust syntax.
For example, this matcher: `fn $name:ident( $($param:ident : $pty:ty),* )` would fail when parsing `fn foo()`, because macro parser wouldn't realize that an ident cannot start with `)`. This resolves #5902, and at least partially mitigates #9364 and #3232.
Diffstat (limited to 'src/libsyntax')
| -rw-r--r-- | src/libsyntax/ext/tt/macro_parser.rs | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/src/libsyntax/ext/tt/macro_parser.rs b/src/libsyntax/ext/tt/macro_parser.rs index 090b39eee47..88376108fec 100644 --- a/src/libsyntax/ext/tt/macro_parser.rs +++ b/src/libsyntax/ext/tt/macro_parser.rs @@ -350,7 +350,16 @@ pub fn parse(sess: &ParseSess, sp_lo: sp.lo }); } - MatchNonterminal(_,_,_) => { bb_eis.push(ei) } + MatchNonterminal(_,_,_) => { + // Built-in nonterminals never start with these tokens, + // so we can eliminate them from consideration. + match tok { + token::RPAREN | + token::RBRACE | + token::RBRACKET => {}, + _ => bb_eis.push(ei) + } + } MatchTok(ref t) => { let mut ei_t = ei.clone(); if token_name_eq(t,&tok) { |
