about summary refs log tree commit diff
path: root/src/libsyntax_ext
diff options
context:
space:
mode:
authorEsteban Küber <esteban@kuber.com.ar>2018-12-26 20:18:41 -0800
committerEsteban Küber <esteban@kuber.com.ar>2018-12-26 20:36:02 -0800
commit5e952e34795360c3f0c6661d993585146a4bdd2b (patch)
treed7155e38c2b8e8ebaf5e42e295472ea724a75e61 /src/libsyntax_ext
parent5e75001c596991d63729b41769164197db6fc5c8 (diff)
downloadrust-5e952e34795360c3f0c6661d993585146a4bdd2b.tar.gz
rust-5e952e34795360c3f0c6661d993585146a4bdd2b.zip
Add span label to unused string formatting argument
Fix #55350.
Diffstat (limited to 'src/libsyntax_ext')
-rw-r--r--src/libsyntax_ext/format.rs7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/libsyntax_ext/format.rs b/src/libsyntax_ext/format.rs
index 17e692d1d32..1d0cd9bd472 100644
--- a/src/libsyntax_ext/format.rs
+++ b/src/libsyntax_ext/format.rs
@@ -957,13 +957,18 @@ pub fn expand_preparsed_format_args(ecx: &mut ExtCtxt,
         let mut diag = {
             if errs_len == 1 {
                 let (sp, msg) = errs.into_iter().next().unwrap();
-                cx.ecx.struct_span_err(sp, msg)
+                let mut diag = cx.ecx.struct_span_err(sp, msg);
+                diag.span_label(sp, msg);
+                diag
             } else {
                 let mut diag = cx.ecx.struct_span_err(
                     errs.iter().map(|&(sp, _)| sp).collect::<Vec<Span>>(),
                     "multiple unused formatting arguments",
                 );
                 diag.span_label(cx.fmtsp, "multiple missing formatting specifiers");
+                for (sp, msg) in errs {
+                    diag.span_label(sp, msg);
+                }
                 diag
             }
         };