diff options
| author | Daniel Micay <danielmicay@gmail.com> | 2014-03-04 19:54:35 -0500 |
|---|---|---|
| committer | Daniel Micay <danielmicay@gmail.com> | 2014-03-05 11:20:50 -0500 |
| commit | 2760974ec05966c811f1ee6f85bf59b13f28b009 (patch) | |
| tree | 68d84ba69516afbecb642ad7cb9074292df3dbbd /src/libtest | |
| parent | 6e7f170fedd3c526a643c0b2d13863acd982be02 (diff) | |
| download | rust-2760974ec05966c811f1ee6f85bf59b13f28b009.tar.gz rust-2760974ec05966c811f1ee6f85bf59b13f28b009.zip | |
add correct floating point `min` and `max` methods.
The `std::cmp` functions are not correct for floating point types. `min(NaN, 2.0)` and `min(2.0, NaN)` return different values, because these functions assume a total order. Floating point types need special `min`, `max` and `clamp` functions.
Diffstat (limited to 'src/libtest')
| -rw-r--r-- | src/libtest/lib.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libtest/lib.rs b/src/libtest/lib.rs index 0e062003053..9ebd7d72c91 100644 --- a/src/libtest/lib.rs +++ b/src/libtest/lib.rs @@ -1063,7 +1063,7 @@ impl MetricMap { Some(v) => { let delta = v.value - vold.value; let noise = match noise_pct { - None => f64::max(vold.noise.abs(), v.noise.abs()), + None => vold.noise.abs().max(v.noise.abs()), Some(pct) => vold.value * pct / 100.0 }; if delta.abs() <= noise { |