about summary refs log tree commit diff
path: root/src/rt/rust_kernel.cpp
diff options
context:
space:
mode:
authorFelix S. Klock II <pnkfelix@pnkfx.org>2013-07-08 18:35:47 +0200
committerFelix S. Klock II <pnkfelix@pnkfx.org>2013-07-09 13:08:50 +0200
commit25f51eeda079382773c0f3b91f43603432c44132 (patch)
tree7719c76e1e01680a858bbbcb99264e9c2cae8584 /src/rt/rust_kernel.cpp
parent033ac5497e00d2380b6cb816498a945fbc10c1e6 (diff)
downloadrust-25f51eeda079382773c0f3b91f43603432c44132.tar.gz
rust-25f51eeda079382773c0f3b91f43603432c44132.zip
Fix #3225: Incorporate feedback from Graydon.
Namely, switched in many places to using GNU make provided functions
for directory listing and text processing, rather than spawning a
shell process to do that work.

In the process of the revision, learned about Target-specific
variables, which were very applicable to INSTALL_LIB (which, on a
per-recipe basis, was always receiving the same actual arguments for
its first two formal parameters in every invocation).

  http://www.gnu.org/software/make/manual/html_node/Target_002dspecific.html

(We might be able to make use of those in future refactorings.)

----

Also adds a cleanup pass to get-snapshot.py as well, since the same
problem arises when we unpack libraries from the snapshot archive into
a build directory with a prior snapshot's artifacts.  (I put this step
into the python script rather than the makefile because I wanted to
delay the cleanup pass until after we have at least successfully
downloaded the tarball.  That way, if the download fails, you should
not destroy the previous unarchived snapshot libraries and build
products.)

----

Also reverted whitespace changes to minimize diff.
I plan to put them back in in a dedicated commit elsewhere.
Diffstat (limited to 'src/rt/rust_kernel.cpp')
0 files changed, 0 insertions, 0 deletions