diff options
| author | Graydon Hoare <graydon@mozilla.com> | 2012-06-21 16:44:10 -0700 |
|---|---|---|
| committer | Graydon Hoare <graydon@mozilla.com> | 2012-06-21 16:44:10 -0700 |
| commit | 312faf31dfcce7a2d15495c5042d80a3e3b476c9 (patch) | |
| tree | 4ad8383191907b5cb148291a2d1dbc078f590eb6 /src/rt/rust_kernel.cpp | |
| parent | 57101780811490fa759ed1dca310c405d28c0a72 (diff) | |
| download | rust-312faf31dfcce7a2d15495c5042d80a3e3b476c9.tar.gz rust-312faf31dfcce7a2d15495c5042d80a3e3b476c9.zip | |
Tag all remaining FIXMEs with bugs. Install rule in tidy script to enforce this.
Diffstat (limited to 'src/rt/rust_kernel.cpp')
| -rw-r--r-- | src/rt/rust_kernel.cpp | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/src/rt/rust_kernel.cpp b/src/rt/rust_kernel.cpp index de08436cf3f..b13b1490c0f 100644 --- a/src/rt/rust_kernel.cpp +++ b/src/rt/rust_kernel.cpp @@ -184,23 +184,22 @@ rust_kernel::run() { return rval; } -// FIXME: Fix all these FIXMEs (#2690) void rust_kernel::fail() { - // FIXME: On windows we're getting "Application has requested the - // Runtime to terminate it in an unusual way" when trying to shutdown - // cleanly. + // FIXME (#2671): On windows we're getting "Application has + // requested the Runtime to terminate it in an unusual way" when + // trying to shutdown cleanly. set_exit_status(PROC_FAIL_CODE); #if defined(__WIN32__) exit(rval); #endif // Copy the list of schedulers so that we don't hold the lock while // running kill_all_tasks. - // FIXME: There's a lot that happens under kill_all_tasks, and I don't - // know that holding sched_lock here is ok, but we need to hold the - // sched lock to prevent the scheduler from being destroyed while - // we are using it. Probably we need to make rust_scheduler atomicly - // reference counted. + // FIXME (#2671): There's a lot that happens under kill_all_tasks, + // and I don't know that holding sched_lock here is ok, but we need + // to hold the sched lock to prevent the scheduler from being + // destroyed while we are using it. Probably we need to make + // rust_scheduler atomicly reference counted. std::vector<rust_scheduler*> scheds; { scoped_lock with(sched_lock); @@ -210,9 +209,9 @@ rust_kernel::fail() { } } - // FIXME: This is not a foolproof way to kill all tasks while ensuring - // that no new tasks or schedulers are created in the meantime that - // keep the scheduler alive. + // FIXME (#2671): This is not a foolproof way to kill all tasks + // while ensuring that no new tasks or schedulers are created in the + // meantime that keep the scheduler alive. for (std::vector<rust_scheduler*>::iterator iter = scheds.begin(); iter != scheds.end(); iter++) { (*iter)->kill_all_tasks(); |
