about summary refs log tree commit diff
path: root/src/rustllvm/CoverageMappingWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2020-04-08 17:14:09 +0000
committerbors <bors@rust-lang.org>2020-04-08 17:14:09 +0000
commitc25f26d4ca8d194fd1edfda643f2c96170a85a77 (patch)
tree785e0ec2885d32c335294917409bd80d044b73ef /src/rustllvm/CoverageMappingWrapper.cpp
parent940bbd6aa45c615e598ab92b8486c5698554499d (diff)
parent5f92faec6d0cbaac6c6afa93efc7298de6765afc (diff)
downloadrust-c25f26d4ca8d194fd1edfda643f2c96170a85a77.tar.gz
rust-c25f26d4ca8d194fd1edfda643f2c96170a85a77.zip
Auto merge of #5411 - dtolnay:hasher, r=flip1995
Downgrade implicit_hasher to pedantic

From the [documentation](https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher), this lint is intended to suggest:

```diff
- pub fn foo(map: &mut HashMap<i32, i32>) { }

+ pub fn foo<S: BuildHasher>(map: &mut HashMap<i32, i32, S>) { }
```

I think this is pedantic. I get that this lint can benefit core libraries like serde, but that's exactly the use case for pedantic lints; a library like serde will [enable clippy_pedantic](https://github.com/serde-rs/json/blob/fd6741f4b0b3fc90a58a6f578e33a9adc6403f3f/src/lib.rs#L304) and take the time to go through everything possible. Similar for libraries doing a libz blitz style checkup before committing to a 1.0 release; it would make sense to run through all the available pedantic lints then.

But otherwise, for most codebases and certainly for industrial codebases, the above suggested change just makes the codebase more obtuse for questionable benefit.

changelog: Remove implicit_hasher from default set of enabled lints
Diffstat (limited to 'src/rustllvm/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions