about summary refs log tree commit diff
path: root/src/rustllvm/ExecutionEngineWrapper.cpp
diff options
context:
space:
mode:
authorAlex Crichton <alex@alexcrichton.com>2014-03-25 08:44:40 -0700
committerAlex Crichton <alex@alexcrichton.com>2014-03-28 11:07:58 -0700
commit0e190b9a4ad92645e8f63c72c66cc89a596f1971 (patch)
treec77eb7ce115419a982d6f32f692b26f080b68ee9 /src/rustllvm/ExecutionEngineWrapper.cpp
parentb8601a3d8b91ad3b653d143307611f2f5c75617e (diff)
downloadrust-0e190b9a4ad92645e8f63c72c66cc89a596f1971.tar.gz
rust-0e190b9a4ad92645e8f63c72c66cc89a596f1971.zip
native: Use WNOHANG before signaling
It turns out that on linux, and possibly other platforms, child processes will
continue to accept signals until they have been *reaped*. This means that once
the child has exited, it will succeed to receive signals until waitpid() has
been invoked on it.

This is unfortunate behavior, and differs from what is seen on OSX and windows.
This commit changes the behavior of Process::signal() to be the same across
platforms, and updates the documentation of Process::kill() to note that when
signaling a foreign process it may accept signals until reaped.

Implementation-wise, this invokes waitpid() with WNOHANG before each signal to
the child to ensure that if the child has exited that we will reap it. Other
possibilities include installing a SIGCHLD signal handler, but at this time I
believe that that's too complicated.

Closes #13124
Diffstat (limited to 'src/rustllvm/ExecutionEngineWrapper.cpp')
0 files changed, 0 insertions, 0 deletions