about summary refs log tree commit diff
path: root/src/rustllvm/ExecutionEngineWrapper.cpp
diff options
context:
space:
mode:
authorAlex Crichton <alex@alexcrichton.com>2015-05-15 09:18:14 -0700
committerAlex Crichton <alex@alexcrichton.com>2015-05-18 17:51:23 -0700
commit5f39ceb729e3bb209e9cf52701fe4424e7431ca0 (patch)
tree51f3057d375c62804cb50f064cc2c67d8c37b78a /src/rustllvm/ExecutionEngineWrapper.cpp
parentaf522079a2e13046cbf5f426874d7f6b672c501e (diff)
downloadrust-5f39ceb729e3bb209e9cf52701fe4424e7431ca0.tar.gz
rust-5f39ceb729e3bb209e9cf52701fe4424e7431ca0.zip
std: Make abs() panic on overflow in debug mode
Debug overflow checks for arithmetic negation landed in #24500, at which time
the `abs` method on signed integers was changed to using `wrapping_neg` to
ensure that the function never panicked. This implied that `abs` of `INT_MIN`
would return `INT_MIN`, another negative value. When this change was back-ported
to beta, however, in #24708, the `wrapping_neg` function had not yet been
backported, so the implementation was changed in #24785 to `!self + 1`. This
change had the unintended side effect of enabling debug overflow checks for the
`abs` function. Consequently, the current state of affairs is that the beta
branch checks for overflow in debug mode for `abs` and the nightly branch does
not.

This commit alters the behavior of nightly to have `abs` always check for
overflow in debug mode. This change is more consistent with the way the standard
library treats overflow as well, and it is also not a breaking change as it's
what the beta branch currently does (albeit if by accident).

cc #25378
Diffstat (limited to 'src/rustllvm/ExecutionEngineWrapper.cpp')
0 files changed, 0 insertions, 0 deletions