diff options
| author | Alex Crichton <alex@alexcrichton.com> | 2014-12-21 00:04:01 -0800 |
|---|---|---|
| committer | Alex Crichton <alex@alexcrichton.com> | 2014-12-21 09:26:43 -0800 |
| commit | 9f4f6cf655c0619541f7251541a2a7221aa78938 (patch) | |
| tree | 586701ad50aeb360f05956accd057cfa3cb98bf8 /src/rustllvm/ExecutionEngineWrapper.cpp | |
| parent | e8722691abbe521fd6ba7b558dec7273ca7cec6d (diff) | |
| parent | 1a996f93c3e205fa62004686a17f26bd4484cc87 (diff) | |
| download | rust-9f4f6cf655c0619541f7251541a2a7221aa78938.tar.gz rust-9f4f6cf655c0619541f7251541a2a7221aa78938.zip | |
rollup merge of #19965: japaric/remove-wrong-add
TL;DR I wrongly implemented these two ops, namely `"prefix" + "suffix".to_string()` gives back `"suffixprefix"`. Let's remove them. The correct implementation of these operations (`lhs.clone().push_str(rhs.as_slice())`) is really wasteful, because the lhs has to be cloned and the rhs gets moved/consumed just to be dropped (no buffer reuse). For this reason, I'd prefer to drop the implementation instead of fixing it. This leaves us with the fact that you'll be able to do `String + &str` but not `&str + String`, which may be unexpected. r? @aturon Closes #19952
Diffstat (limited to 'src/rustllvm/ExecutionEngineWrapper.cpp')
0 files changed, 0 insertions, 0 deletions