diff options
| author | Patrick Walton <pcwalton@mimiga.net> | 2014-07-01 21:59:16 -0700 |
|---|---|---|
| committer | Patrick Walton <pcwalton@mimiga.net> | 2014-07-01 21:59:16 -0700 |
| commit | e56dbad9f7c3691bcb12edfaeda5cb3b660496de (patch) | |
| tree | 116a2eb5d8ce0e99afa426534fae651741092260 /src/rustllvm/ExecutionEngineWrapper.cpp | |
| parent | 380657557cb3793d39dfc0d2321fc946cb3496f5 (diff) | |
| download | rust-e56dbad9f7c3691bcb12edfaeda5cb3b660496de.tar.gz rust-e56dbad9f7c3691bcb12edfaeda5cb3b660496de.zip | |
librustc: Properly compare implementation method type parameter bounds
with the corresponding trait parameter bounds.
This is a version of the patch in PR #12611 by Florian Hahn, modified to
address Niko's feedback.
It does not address the issue of duplicate type parameter bounds, nor
does it address the issue of implementation-defined methods that contain
*fewer* bounds than the trait, because Niko's review indicates that this
should not be necessary (and indeed I believe it is not). A test has
been added to ensure that this works.
This will break code like:
trait Foo {
fn bar<T:Baz>();
}
impl Foo for Boo {
fn bar<T:Baz + Quux>() { ... }
// ^~~~ ERROR
}
This will be rejected because the implementation requires *more* bounds
than the trait. It can be fixed by either adding the missing bound to
the trait:
trait Foo {
fn bar<T:Baz + Quux>();
// ^~~~
}
impl Foo for Boo {
fn bar<T:Baz + Quux>() { ... } // OK
}
Or by removing the bound from the impl:
trait Foo {
fn bar<T:Baz>();
}
impl Foo for Boo {
fn bar<T:Baz>() { ... } // OK
// ^ remove Quux
}
This patch imports the relevant tests from #2687, as well as the test
case in #5886, which is fixed as well by this patch.
Closes #2687.
Closes #5886.
[breaking-change]
Diffstat (limited to 'src/rustllvm/ExecutionEngineWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
