about summary refs log tree commit diff
path: root/src/rustllvm/PassWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2018-08-28 03:22:21 +0000
committerbors <bors@rust-lang.org>2018-08-28 03:22:21 +0000
commitca63a4e4383f502cf541e0b0bc1c13541918103d (patch)
treea0feaffcbffbf842cdb1aee8b82b8b970659dd95 /src/rustllvm/PassWrapper.cpp
parentf33921ba58754d1bfbaf483ddc6dc9dffdcd4de7 (diff)
parent0945b74d73940e404a355eda0c8d6c202fae8a12 (diff)
downloadrust-ca63a4e4383f502cf541e0b0bc1c13541918103d.tar.gz
rust-ca63a4e4383f502cf541e0b0bc1c13541918103d.zip
Auto merge of #53404 - oconnor663:current_dir_behavior, r=alexcrichton
document the platform-specific behavior of Command::current_dir

See also https://github.com/rust-lang/rust/issues/37868.

Here's my initial wording:

> Note that if the program path is relative (e.g. `"./script.sh"`), the interaction between that path and `current_dir` varies across platforms. Windows currently ignores `current_dir` when locating the program, but Unix-like systems interpret the program path relative to `current_dir`. These implementation details aren't considered stable, and it's recommended to call `canonicalize` to get an absolute program path instead of using relative paths and `current_dir` together.

I'd like to get feedback on:

- _Should_ we consider those details stable? It might be disruptive to change them, regardless of what I can get away with claiming in docs :)
- Is `canonicalize` an appropriate recommendation? As discussed in #37868 above, there are reasons it's not called automatically in the `Command` implementation.
Diffstat (limited to 'src/rustllvm/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions