about summary refs log tree commit diff
path: root/src/rustllvm/PassWrapper.cpp
diff options
context:
space:
mode:
authorAlex Crichton <alex@alexcrichton.com>2017-03-15 08:09:59 -0700
committerPeter Atashian <retep998@gmail.com>2017-03-21 16:47:10 -0400
commitef90d32f07e187d3e1824d980ad01caac5313101 (patch)
tree805a1522ec0590526e578b0f01960525a6feb3e5 /src/rustllvm/PassWrapper.cpp
parent58c701f5c7dc26d9b55c631006ece52abe1ddce2 (diff)
downloadrust-ef90d32f07e187d3e1824d980ad01caac5313101.tar.gz
rust-ef90d32f07e187d3e1824d980ad01caac5313101.zip
rustc: Always emit the `uwtable` attribute on Windows
This commit alters the translation layer to unconditionally emit the `uwtable`
LLVM attribute on Windows regardless of the `no_landing_pads` setting.
Previously I believe we omitted this attribute as an optimization when the
`-Cpanic=abort` flag was passed, but this unfortunately caused problems for
Gecko.

It [was discovered] that there was trouble unwinding through Rust functions due
to foreign exceptions such as illegal instructions or otherwise in-practice
methods used to abort a process. In testing it looked like the major difference
between a working binary and a non-working binary is indeed this `uwtable`
attribute, but this PR has unfortunately not been thoroughly tested in terms of
compiling Gecko with `-C panic=abort` *and* this PR to see whether it works, so
this is still somewhat working on just suspicion.

[was discovered]: https://bugzilla.mozilla.org/show_bug.cgi?id=1302078
Diffstat (limited to 'src/rustllvm/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions