about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2016-09-08 19:15:50 -0700
committerGitHub <noreply@github.com>2016-09-08 19:15:50 -0700
commit1df64450ecf9d2c458b5789ef823203fcdbd60a9 (patch)
treec7e948a1fe232729fa58901f5c0fca28d5b6659e /src/rustllvm/RustWrapper.cpp
parent378195665cc365720c784752877d5b1242c38ed8 (diff)
parentce3cecf116a2d691c53f37c1d257a416ecfd381b (diff)
downloadrust-1df64450ecf9d2c458b5789ef823203fcdbd60a9.tar.gz
rust-1df64450ecf9d2c458b5789ef823203fcdbd60a9.zip
Auto merge of #36321 - uweigand:enum-abi, r=eddyb
Follow target ABI sign-/zero-extension rules for enum types

While attempting to port Rust to s390x, I ran into an ABI violation
(that caused rust_eh_personality to be miscompiled, breaking unwinding).
The problem is that this function returns an enum type, which is
supposed to be sign-extended according to the s390x ABI.  However,
common code would ignore target sign-/zero-extension rules for any
types that do not satisfy is_integral(), which includes enums.

For the general case of Rust enum types, which map to structure types
with a discriminant, that seems correct.  However, in the special case
of simple enums that map directly to C enum types (i.e. LLVM integers),
this is incorrect; we must follow the target extension rules for those.

Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions