about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2020-05-20 14:02:06 +0000
committerbors <bors@rust-lang.org>2020-05-20 14:02:06 +0000
commit20f09e1daa2c379beadbe1df133023f1aae727a6 (patch)
tree022a619e1ad3ddc2099b631fcf90e36a2f6b83fc /src/rustllvm/RustWrapper.cpp
parentcafa94662ce3ffc1c8c1edca86e328fcc26ad3db (diff)
parent2db7f1abf84699605a5863887484cbf587db3eb1 (diff)
downloadrust-20f09e1daa2c379beadbe1df133023f1aae727a6.tar.gz
rust-20f09e1daa2c379beadbe1df133023f1aae727a6.zip
Auto merge of #5622 - elichai:2020-05-match_wild_err_arm, r=flip1995
Downgrade `match_wild_err_arm` to pedantic and update help messages

Hi,
This fixes #3688 and downgrades `match_wild_err_arm` to pedantic.
There are a lot of different reasons in that issue, for me the biggest are:
1. Rust's errors aren't like Java's exceptions because they're type safe and in most cases the type of error can't change by itself.
2. Sometimes matching can be more ergonomic, and before the `track_caller` feature got introduced it was actually easier to track the panic location with explicit `panic!` than with `expect`.

Currently clippy is failing to build because of a breaking change in https://github.com/rust-lang/rust/pull/69171 I tried fixing it but it is too complex for my little knowledge of clippy and rustc so I'll leave that to people who know what they're doing :)

Another thing, if rustc is breaking clippy a lot then maybe it's better to use something like `miri` does, where it's hard codes the latest tested rustc commit and they keep bumping it, that way when you develop locally it should work even if there was a breaking change (https://github.com/rust-lang/miri/blob/master/rustup-toolchain#L23-L29)

changelog: Downgrade `match_wild_err_arm` to pedantic
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions