about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorJack O'Connor <oconnor663@gmail.com>2017-02-03 17:39:41 -0500
committerJack O'Connor <oconnor663@gmail.com>2017-02-06 23:04:47 -0500
commit2a345bbcc1e6332241883f784896ea93d2a7ccb3 (patch)
tree42aa5e90e250c126c2d34cb24e487a461aa20ec6 /src/rustllvm/RustWrapper.cpp
parentc49d10207a7e105525fb3bd71c18fde6fc2f5aed (diff)
downloadrust-2a345bbcc1e6332241883f784896ea93d2a7ccb3.tar.gz
rust-2a345bbcc1e6332241883f784896ea93d2a7ccb3.zip
make Child::try_wait return io::Result<Option<ExitStatus>>
This is much nicer for callers who want to short-circuit real I/O errors
with `?`, because they can write this

    if let Some(status) = foo.try_wait()? {
        ...
    } else {
        ...
    }

instead of this

    match foo.try_wait() {
        Ok(status) => {
            ...
        }
        Err(err) if err.kind() == io::ErrorKind::WouldBlock => {
            ...
        }
        Err(err) => return Err(err),
    }

The original design of `try_wait` was patterned after the `Read` and
`Write` traits, which support both blocking and non-blocking
implementations in a single API. But since `try_wait` is never blocking,
it makes sense to optimize for the non-blocking case.

Tracking issue: https://github.com/rust-lang/rust/issues/38903
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions