about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2014-08-17 02:36:10 +0000
committerbors <bors@rust-lang.org>2014-08-17 02:36:10 +0000
commit4a5654f960ca1f979e2ddf1efa57fa750dbd1dff (patch)
tree02452858125464ce20b886a2b61d77b0c3b3d65a /src/rustllvm/RustWrapper.cpp
parent85fd37f876dad1d4db02208f8a56f02228d975b0 (diff)
parent7f928d150e53b5873b4238f9e60d1aa4be9b602f (diff)
downloadrust-4a5654f960ca1f979e2ddf1efa57fa750dbd1dff.tar.gz
rust-4a5654f960ca1f979e2ddf1efa57fa750dbd1dff.zip
auto merge of #16482 : pcwalton/rust/resolve-shadowing, r=brson
declared with the same name in the same scope.

This breaks several common patterns. First are unused imports:

    use foo::bar;
    use baz::bar;

Change this code to the following:

    use baz::bar;

Second, this patch breaks globs that import names that are shadowed by
subsequent imports. For example:

    use foo::*; // including `bar`
    use baz::bar;

Change this code to remove the glob:

    use foo::{boo, quux};
    use baz::bar;

Or qualify all uses of `bar`:

    use foo::{boo, quux};
    use baz;

    ... baz::bar ...

Finally, this patch breaks code that, at top level, explicitly imports
`std` and doesn't disable the prelude.

    extern crate std;

Because the prelude imports `std` implicitly, there is no need to
explicitly import it; just remove such directives.

The old behavior can be opted into via the `import_shadowing` feature
gate. Use of this feature gate is discouraged.

This implements RFC #116.

Closes #16464.

[breaking-change]

r? @brson
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions