about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorBen Kelly <ben@wanderview.com>2013-03-11 23:12:31 -0400
committerBen Kelly <ben@wanderview.com>2013-03-11 23:12:31 -0400
commit4f4f69d731ae8cf42eb898fee1de418e76879552 (patch)
treec5655d28f14f6deb57b3aa8b7476a671747591d1 /src/rustllvm/RustWrapper.cpp
parent267f6c212f471c100060edaaf85a26e9a7ba820f (diff)
downloadrust-4f4f69d731ae8cf42eb898fee1de418e76879552.tar.gz
rust-4f4f69d731ae8cf42eb898fee1de418e76879552.zip
Fix std::getopts::opts_present() to check value.
Currently the opts_present() function only checks to see if the option is
configured in the match, but doesn't actually check to see if the option
value has been set.  This means that opt_present('h') may return false while
opts_present([~'h']) returns true.

Add a test case to catch this condition and fix opts_present() to check
the value before returning true.

Note, there is another API difference between these two functions that this
does not address.  Currently if you pass a non-configured option to
opt_present() the program will fail!(), but opts_present() simply returns
false.  If it is acceptable to standardize on the fail!() then opts_present()
should probably be implemented in terms of the opt_present() function.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions