about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorFelix S. Klock II <pnkfelix@pnkfx.org>2014-10-09 16:26:46 +0200
committerFelix S. Klock II <pnkfelix@pnkfx.org>2014-10-27 12:17:45 +0100
commit6f1e6273880eb40ae12ffd11191fd8758ee437b9 (patch)
tree2d622af9cf7269a7560a53cf6529a2733415e7c3 /src/rustllvm/RustWrapper.cpp
parenta93e9c20f2a79eacad21592d0eb58e1a89648629 (diff)
downloadrust-6f1e6273880eb40ae12ffd11191fd8758ee437b9.tar.gz
rust-6f1e6273880eb40ae12ffd11191fd8758ee437b9.zip
config.mk: Added variants of `valopt`/`opt` that do not automatically `putvar`.
Used aforementioned variants to extract options that have explicit
`putvar` calls associated with them in the subsequent code.  When the
explicit `putvar` call was conditional on some potentially complex
condition, moved the `putvar` call out to the main control flow of the
script so that it always runs if necessary.

----

As a driveby fix, captured the error exit when doing the test run of
`rustc --version` from `CFG_LOCAL_RUST_ROOT`, and signal explicit
configure failure when it did not run successfully.  (If we cannot run
`rustc`, we really shouldn't try to keep going.)

----

Finally, in response to review feedback, went through and identified
cases where we had been calling `putvar` manually (and thus my naive
translation used `opt_nosave`/`valopt_nosave`), and then verified
whether a manual `putvar` was necessary (i.e., was each variable in
question manually computed somewhere in the `configure` script).
In cases that did not meet this criteria, I revised the code to use
the `opt`/`valopt` directly and removed the corresponding `putvar`,
cleaning things up a teeny bit.

----

Fix #17887.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions