about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorSimon Sapin <simon.sapin@exyr.org>2019-10-17 13:51:46 +0200
committerSimon Sapin <simon.sapin@exyr.org>2019-10-17 14:25:40 +0200
commit71b0049ad66eb3f1d8339979422b89e44306bc05 (patch)
tree3630e6ecf2933ab7507fffdc1bd01f4450d2e932 /src/rustllvm/RustWrapper.cpp
parenta16dca337de610986252bb800953e57bf395863f (diff)
downloadrust-71b0049ad66eb3f1d8339979422b89e44306bc05.tar.gz
rust-71b0049ad66eb3f1d8339979422b89e44306bc05.zip
Plugins deprecation: don’t suggest simply removing the attribute
Building Servo with a recent Nightly produces:

```rust
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
  --> components/script/lib.rs:14:1
   |
14 | #![plugin(script_plugins)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
   |
   = note: `#[warn(deprecated)]` on by default
```

First, linking to https://github.com/rust-lang/rust/issues/29597 is not ideal
since there is pretty much no discussion there of the deprecation
and what can be used instead.
This PR changes the link to the deprecation PR which does have more discussion.

Second, the “remove this attribute” suggestion is rather unhelpful.
Just because a feature is deprecated doesn’t mean that simply removing its use
without a replacement is acceptable.

In the case of custom lint, there is no replacement available.
Prefixing a message with “help:” when telling users that they’re screwed
honestly feels disrespectful.

This PR also changes the message to be more factual.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions