about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorNODA, Kai <nodakai@gmail.com>2014-12-07 07:05:13 +0800
committerNODA, Kai <nodakai@gmail.com>2014-12-07 07:07:26 +0800
commit87424c6a32e883b3d7328fc78341aa79ff1e3abb (patch)
tree6e68711c53d807a0b81c353ff6a5d2ada2ed421b /src/rustllvm/RustWrapper.cpp
parent358db12a89d6edf4a61cb3c8d170449faea925cc (diff)
downloadrust-87424c6a32e883b3d7328fc78341aa79ff1e3abb.tar.gz
rust-87424c6a32e883b3d7328fc78341aa79ff1e3abb.zip
Fix false positive alerts from a run-pass test on Command.
Reported as a part of rust-lang/rust#19120

The logic of rust-lang/rust@74fb798a200dc82cf5b4a18065e3ea565229adc3 was
flawed because when a CI tool run the test parallely with other tasks,
they all belong to a single session family and the test may pick up
irrelevant zombie processes before they are reaped by the CI tool
depending on timing.

Also, panic! inside a loop over all children makes the logic simpler.

By not destructing the return values of Command::spawn() until
find_zombies() finishes, I believe we can conduct a slightly stricter
test.

Signed-off-by: NODA, Kai <nodakai@gmail.com>
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions