about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorMazdak Farrokhzad <twingoow@gmail.com>2019-01-13 05:26:47 +0100
committerGitHub <noreply@github.com>2019-01-13 05:26:47 +0100
commit8e3980b8e8e77bda49856f26255028794b05a43e (patch)
treefe689f86b7f70d5ee68a85bd897f2f4fc2dde3c8 /src/rustllvm/RustWrapper.cpp
parentd3cb51c8702d1da709e26b6b8aa6a567b11c5a47 (diff)
parenteed163e11042c197c3e6aff65b1011abe1ca3980 (diff)
downloadrust-8e3980b8e8e77bda49856f26255028794b05a43e.tar.gz
rust-8e3980b8e8e77bda49856f26255028794b05a43e.zip
Rollup merge of #57436 - Xanewok:save-analysis-access-ice-fix, r=nikomatsakis
save-analysis: use a fallback when access levels couldn't be computed

Fixing an RLS regression I introduced in https://github.com/rust-lang/rust/pull/57343 :cry:

I missed a case where we get [called back with analysis when type checking fails](https://github.com/rust-lang/rust/blob/9d54812829e9d92dac35a4a0f358cdc5a2475371/src/librustc_driver/driver.rs#L1264). Since privacy checking normally is done afterwards, when we execute the `privacy_access_levels` query inside the save_analysis callback we'll calculate it for the first time and since typeck info isn't complete, we'll crash there.

Double-checked locally and it seems to have fixed the problem.

r? @nikomatsakis
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions