about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2014-09-14 00:51:05 +0000
committerbors <bors@rust-lang.org>2014-09-14 00:51:05 +0000
commit931b11549f3aab00aaaaff39cce33c0f7219b3b6 (patch)
treedb06daabf58611692de3b7d914dc8a40b168b9ed /src/rustllvm/RustWrapper.cpp
parent79a5448f41dcc6ab52663105a6b02fc5af4c503e (diff)
parent3da255d35a7f9d53e4c31d5712f88ff14eaaf45e (diff)
downloadrust-931b11549f3aab00aaaaff39cce33c0f7219b3b6.tar.gz
rust-931b11549f3aab00aaaaff39cce33c0f7219b3b6.zip
auto merge of #17189 : bkoropoff/rust/extern-existing-crate, r=alexcrichton
When checking for an existing crate, compare against the `crate_metadata::name` field, which is the crate name which was requested during resolution, rather than the result of the `crate_metadata::name()` method, which is the crate name within the crate metadata, as these may not match when using the --extern option to `rustc`.

This fixes spurious "multiple crate version" warnings under the following scenario:

- The crate `foo`, is referenced multiple times
- `--extern foo=./path/to/libbar.rlib` is specified to rustc
- The internal crate name of `libbar.rlib` is not `foo`

The behavior surrounding `Context::should_match_name` and the comments in `loader.rs` both lead me to believe that this scenario is intended to work.

Fixes #17186
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions